From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com,
jani.nikula@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 1/2] drm/i915/backlight: Rename debug message in the setup() callback
Date: Thu, 14 May 2026 11:28:47 +0530 [thread overview]
Message-ID: <20260514055848.871938-2-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260514055848.871938-1-suraj.kandpal@intel.com>
Update the drm_dbg_kms to "Setting up ..." instead of "Using .."
since a call to pwm_funcs->setup() does not necessarily mean we
will be using PCH PWM to control backlight. We could still end up
using AUX Backlight.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_backlight.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index b128896cb1c2..ab70c79c40b4 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -1280,7 +1280,7 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
}
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PCH PWM for backlight control\n",
+ "[CONNECTOR:%d:%s] Setting up native PCH PWM for backlight control\n",
connector->base.base.id, connector->base.name);
return 0;
@@ -1311,7 +1311,7 @@ static int pch_setup_backlight(struct intel_connector *connector, enum pipe unus
(pch_ctl1 & BLM_PCH_PWM_ENABLE);
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PCH PWM for backlight control\n",
+ "[CONNECTOR:%d:%s] Setting up native PCH PWM for backlight control\n",
connector->base.base.id, connector->base.name);
return 0;
@@ -1353,7 +1353,7 @@ static int i9xx_setup_backlight(struct intel_connector *connector, enum pipe unu
panel->backlight.pwm_enabled = val != 0;
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PWM for backlight control\n",
+ "[CONNECTOR:%d:%s] Setting up native PWM for backlight control\n",
connector->base.base.id, connector->base.name);
return 0;
@@ -1386,7 +1386,7 @@ static int i965_setup_backlight(struct intel_connector *connector, enum pipe unu
panel->backlight.pwm_enabled = ctl2 & BLM_PWM_ENABLE;
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PWM for backlight control\n",
+ "[CONNECTOR:%d:%s] Setting up native PWM for backlight control\n",
connector->base.base.id, connector->base.name);
return 0;
@@ -1418,7 +1418,7 @@ static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe
panel->backlight.pwm_enabled = ctl2 & BLM_PWM_ENABLE;
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PWM for backlight control (on pipe %c)\n",
+ "[CONNECTOR:%d:%s] Setting up native PWM for backlight control (on pipe %c)\n",
connector->base.base.id, connector->base.name, pipe_name(pipe));
return 0;
@@ -1458,7 +1458,7 @@ bxt_setup_backlight(struct intel_connector *connector, enum pipe unused)
panel->backlight.pwm_enabled = pwm_ctl & BXT_BLC_PWM_ENABLE;
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PWM for backlight control (controller=%d)\n",
+ "[CONNECTOR:%d:%s] Setting up native PWM for backlight control (controller=%d)\n",
connector->base.base.id, connector->base.name,
panel->backlight.controller);
@@ -1530,7 +1530,7 @@ cnp_setup_backlight(struct intel_connector *connector, enum pipe unused)
panel->backlight.pwm_enabled = pwm_ctl & BXT_BLC_PWM_ENABLE;
drm_dbg_kms(display->drm,
- "[CONNECTOR:%d:%s] Using native PCH PWM for backlight control (controller=%d)\n",
+ "[CONNECTOR:%d:%s] Setting up native PCH PWM for backlight control (controller=%d)\n",
connector->base.base.id, connector->base.name,
panel->backlight.controller);
--
2.34.1
next prev parent reply other threads:[~2026-05-14 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 5:58 [PATCH 0/2] drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path Suraj Kandpal
2026-05-14 5:58 ` Suraj Kandpal [this message]
2026-05-14 5:58 ` [PATCH 2/2] " Suraj Kandpal
2026-05-14 6:05 ` ✓ CI.KUnit: success for drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path (rev2) Patchwork
2026-05-14 7:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-14 10:12 ` [PATCH 0/2] drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path Brandt, Todd E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514055848.871938-2-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox