Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Brandt, Todd E" <todd.e.brandt@intel.com>
To: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Murthy, Arun R" <arun.r.murthy@intel.com>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
Subject: Re: [PATCH 0/2] drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path
Date: Thu, 14 May 2026 10:12:52 +0000	[thread overview]
Message-ID: <c1c8fbd30bf30f6369bf6b8c5c6926b8ccbadd82.camel@intel.com> (raw)
In-Reply-To: <20260514055848.871938-1-suraj.kandpal@intel.com>

On Thu, 2026-05-14 at 11:28 +0530, Suraj Kandpal wrote:
> In full-AUX VESA mode (aux_enable && aux_set) the driver never
> touches the
> native PCH PWM. If BIOS left the PWM CTL register enabled, the PCH
> PWM keeps
> the system alive during s2idle and blocks S0ix. This series sanitizes
> that
> stale BIOS state on first enable so S0ix is no longer blocked, while
> keeping
> runtime behaviour otherwise unchanged.
> Patch 1 is a minor debug-message rename cleanup.
> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> 
> Suraj Kandpal (2):
>   drm/i915/backlight: Rename debug message in the setup() callback
>   drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA
>     path
> 
>  .../gpu/drm/i915/display/intel_backlight.c    | 14 ++++----
>  .../drm/i915/display/intel_dp_aux_backlight.c | 32 +++++++++++++----
> --
>  2 files changed, 30 insertions(+), 16 deletions(-)
> 
 
Here's the info on my testing, I opened the bug in bugzilla and gitlab
and tested the patch.

Tested-by: Todd Brandt <todd.e.brandt@intel.com>
Reported-by: Todd Brandt <todd.e.brandt@intel.com>
Closes:
https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16043
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221486


  parent reply	other threads:[~2026-05-14 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  5:58 [PATCH 0/2] drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path Suraj Kandpal
2026-05-14  5:58 ` [PATCH 1/2] drm/i915/backlight: Rename debug message in the setup() callback Suraj Kandpal
2026-05-14  5:58 ` [PATCH 2/2] drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path Suraj Kandpal
2026-05-14  6:05 ` ✓ CI.KUnit: success for drm/i915/backlight: Sanitize BIOS-enabled PCH PWM in full-AUX VESA path (rev2) Patchwork
2026-05-14  7:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-14 10:12 ` Brandt, Todd E [this message]
2026-05-15  3:26 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1c8fbd30bf30f6369bf6b8c5c6926b8ccbadd82.camel@intel.com \
    --to=todd.e.brandt@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox