From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
badal.nilawar@intel.com, riana.tauro@intel.com,
michal.wajdeczko@intel.com, aravind.iddamsetty@linux.intel.com,
mallesh.koujalagi@intel.com
Subject: [PATCH 2/4] drm/xe/pcode: Use int instead of u32 for mailbox status
Date: Tue, 11 Aug 2026 16:52:57 -0700 [thread overview]
Message-ID: <20260811235254.153783-8-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20260811235254.153783-6-umesh.nerlige.ramappa@intel.com>
Mailbox status is of type int, but one of the functions is using a u32
to read it (likely a typo). Use int instead.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/xe/xe_pcode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
index ccc3bdeed6bb..e9125341481b 100644
--- a/drivers/gpu/drm/xe/xe_pcode.c
+++ b/drivers/gpu/drm/xe/xe_pcode.c
@@ -149,7 +149,7 @@ int xe_pcode_read(struct xe_tile *tile, u32 mbox, u32 *val, u32 *val1)
static int pcode_try_request(struct xe_tile *tile, u32 mbox,
u32 request, u32 reply_mask, u32 reply,
- u32 *status, bool atomic, int timeout_us, bool locked)
+ int *status, bool atomic, int timeout_us, bool locked)
{
int slept, wait = 10;
@@ -197,8 +197,7 @@ static int pcode_try_request(struct xe_tile *tile, u32 mbox,
int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
u32 reply_mask, u32 reply, int timeout_base_ms)
{
- u32 status;
- int ret;
+ int status, ret;
xe_tile_assert(tile, timeout_base_ms <= 3);
--
2.51.0
next prev parent reply other threads:[~2026-08-11 23:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 23:52 [PATCH 0/4] Use SIGID API for PCODE and CSC Umesh Nerlige Ramappa
2026-08-11 23:52 ` [PATCH 1/4] drm/xe/log: DO NOT REVIEW Umesh Nerlige Ramappa
2026-08-11 23:52 ` Umesh Nerlige Ramappa [this message]
2026-08-12 0:04 ` [PATCH 2/4] drm/xe/pcode: Use int instead of u32 for mailbox status sashiko-bot
2026-08-11 23:52 ` [PATCH 3/4] drm/xe/pcode: Report pcode errors using SIGID Umesh Nerlige Ramappa
2026-08-12 0:01 ` sashiko-bot
2026-08-12 13:35 ` Nilawar, Badal
2026-08-12 18:07 ` Umesh Nerlige Ramappa
2026-08-12 19:45 ` Michal Wajdeczko
2026-08-13 16:53 ` Umesh Nerlige Ramappa
2026-08-11 23:52 ` [PATCH 4/4] drm/xe/ras: Report CSC " Umesh Nerlige Ramappa
2026-08-12 19:52 ` Michal Wajdeczko
2026-08-14 18:27 ` Umesh Nerlige Ramappa
2026-08-15 7:59 ` Michal Wajdeczko
2026-08-18 22:52 ` Umesh Nerlige Ramappa
2026-08-11 23:59 ` ✗ CI.checkpatch: warning for Use SIGID API for PCODE and CSC Patchwork
2026-08-12 0:00 ` ✓ CI.KUnit: success " Patchwork
2026-08-12 0:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-12 1:48 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811235254.153783-8-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).