intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
	badal.nilawar@intel.com, riana.tauro@intel.com,
	michal.wajdeczko@intel.com, aravind.iddamsetty@linux.intel.com,
	mallesh.koujalagi@intel.com
Subject: [PATCH 3/4] drm/xe/pcode: Report pcode errors using SIGID
Date: Tue, 11 Aug 2026 16:52:58 -0700	[thread overview]
Message-ID: <20260811235254.153783-9-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20260811235254.153783-6-umesh.nerlige.ramappa@intel.com>

Use xe_log_err() to report pcode errors using SIGID.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 drivers/gpu/drm/xe/xe_pcode.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
index e9125341481b..b35c1a77effd 100644
--- a/drivers/gpu/drm/xe/xe_pcode.c
+++ b/drivers/gpu/drm/xe/xe_pcode.c
@@ -14,6 +14,7 @@
 #include "regs/xe_pmt.h"
 #include "xe_assert.h"
 #include "xe_device.h"
+#include "xe_log.h"
 #include "xe_mmio.h"
 #include "xe_pcode_api.h"
 #include "xe_pm.h"
@@ -61,9 +62,7 @@ static int pcode_mailbox_status(struct xe_tile *tile)
 	}
 
 	if (err) {
-		drm_err(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s",
-			err_decode, err_str);
-
+		xe_log_err(tile, PCODE, err_decode, "Mailbox failed: %s\n", err_str);
 		return err_decode;
 	}
 
@@ -225,6 +224,9 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
 				true, 50 * 1000, true);
 	preempt_enable();
 
+	if (!status && ret)
+		xe_log_err(tile, PCODE, ret, "Request timed out on retry");
+
 out:
 	mutex_unlock(&tile->pcode.lock);
 	return status ? status : ret;
@@ -319,8 +321,8 @@ int xe_pcode_ready(struct xe_device *xe, bool locked)
 		mutex_unlock(&tile->pcode.lock);
 
 	if (ret)
-		drm_err(&xe->drm,
-			"PCODE initialization timedout after: 3 min\n");
+		xe_log_err(xe, PCODE, -ret,
+			"Initialization timed out after: %d min\n", timeout_us / 60000000);
 
 	return ret;
 }
-- 
2.51.0


  parent reply	other threads:[~2026-08-11 23:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 23:52 [PATCH 0/4] Use SIGID API for PCODE and CSC Umesh Nerlige Ramappa
2026-08-11 23:52 ` [PATCH 1/4] drm/xe/log: DO NOT REVIEW Umesh Nerlige Ramappa
2026-08-11 23:52 ` [PATCH 2/4] drm/xe/pcode: Use int instead of u32 for mailbox status Umesh Nerlige Ramappa
2026-08-12  0:04   ` sashiko-bot
2026-08-11 23:52 ` Umesh Nerlige Ramappa [this message]
2026-08-12  0:01   ` [PATCH 3/4] drm/xe/pcode: Report pcode errors using SIGID sashiko-bot
2026-08-12 13:35   ` Nilawar, Badal
2026-08-12 18:07     ` Umesh Nerlige Ramappa
2026-08-12 19:45       ` Michal Wajdeczko
2026-08-13 16:53         ` Umesh Nerlige Ramappa
2026-08-11 23:52 ` [PATCH 4/4] drm/xe/ras: Report CSC " Umesh Nerlige Ramappa
2026-08-12 19:52   ` Michal Wajdeczko
2026-08-14 18:27     ` Umesh Nerlige Ramappa
2026-08-15  7:59       ` Michal Wajdeczko
2026-08-18 22:52         ` Umesh Nerlige Ramappa
2026-08-11 23:59 ` ✗ CI.checkpatch: warning for Use SIGID API for PCODE and CSC Patchwork
2026-08-12  0:00 ` ✓ CI.KUnit: success " Patchwork
2026-08-12  0:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-12  1:48 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811235254.153783-9-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).