Re: [PATCH 2/3] drm/xe/hw_error: Initialize hw_error_work per tile

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Ignored return value of devm_add_action_or_reset() leads to silent failure and permanently disabled workqueues on allocation failure.
--

commit 4131be68c9832cc5157abbfbeb9802dae9fcbca5
Author: Raag Jadav <raag.jadav@intel.com>

drm/xe/hw_error: Initialize hw_error_work per tile

This commit updates the hw_error_work initialization to iterate over all
tiles instead of just the root tile, preventing the use of uninitialized
work structs on non-root tiles. It also adds a devm action to cleanly
disable the workqueues during teardown.

> diff --git a/drivers/gpu/drm/xe/xe_hw_error.c b/drivers/gpu/drm/xe/xe_hw_error.c
> --- a/drivers/gpu/drm/xe/xe_hw_error.c
> +++ b/drivers/gpu/drm/xe/xe_hw_error.c

[ ... ]

> @@ -544,12 +554,15 @@ static void process_hw_errors(struct xe_device *xe)
>   */
>  void xe_hw_error_init(struct xe_device *xe)
>  {
> -	struct xe_tile *tile = xe_device_get_root_tile(xe);
> +	struct xe_tile *tile;
> +	u8 id;
>  
>  	if (!IS_DGFX(xe) || IS_SRIOV_VF(xe))
>  		return;
>  
> -	INIT_WORK(&tile->hw_error_work, hw_error_work);
> +	for_each_tile(tile, xe, id)
> +		INIT_WORK(&tile->hw_error_work, hw_error_work);
>  
>  	process_hw_errors(xe);
> +	devm_add_action_or_reset(xe->drm.dev, hw_error_fini, xe);

[Severity: Medium]
Does this code need to check the return value of devm_add_action_or_reset()
in xe_hw_error_init()?

If memory allocation fails internally, devm_add_action_or_reset() will
immediately execute hw_error_fini() (which disables the workqueues) and
return -ENOMEM. Because the return value is ignored here, the driver will
continue operating normally but with the hardware error workqueue permanently
disabled. This could lead to a silent loss of functionality where hardware
errors are no longer handled.

>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260830065603.419055-5-riana.tauro@intel.com?part=2