Re: [PATCH v2 5/5] drm/xe/wedge: Update naming to match with xe_wedge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function `xe_device_wedged` was renamed to `xe_wedged` across the codebase, but the call sites in `drivers/gpu/drm/xe/xe_guc_pc.c` were missed. This will cause an implicit function declaration error and break the build.
--

commit 0a6019f57c4cdf740c1b6783f7839f86d0fd9f5c
Author: Raag Jadav <raag.jadav@intel.com>

drm/xe/wedge: Update naming to match with xe_wedge
    
Now that we have a dedicated xe_wedge component, update all its function
names accordingly.

> diff --git a/drivers/gpu/drm/xe/xe_wedge.c b/drivers/gpu/drm/xe/xe_wedge.c
> index 04d8c5666be14..5982ea7e0f573 100644
> --- a/drivers/gpu/drm/xe/xe_wedge.c
> +++ b/drivers/gpu/drm/xe/xe_wedge.c
[ ... ]
> @@ -54,24 +54,24 @@
>   */
>  
>  /**
> - * xe_device_set_wedged_method() - Set wedge recovery method
> + * xe_wedge_set_method() - Set wedge recovery method
>   * @xe: xe device instance
>   * @method: recovery method to set
>   *
>   * Set wedge recovery method to be sent in drm wedged uevent.
>   */
> -void xe_device_set_wedged_method(struct xe_device *xe, unsigned long method)
> +void xe_wedge_set_method(struct xe_device *xe, unsigned long method)
>  {
>  	xe->wedged.method = method;
>  }
>  
>  /**
> - * xe_device_wedged() - Check for wedged device
> + * xe_wedged() - Check for wedged device
>   * @xe: xe device instance
>   *
>   * Returns: %true if device is wedged, %false otherwise.
>   */
> -bool xe_device_wedged(struct xe_device *xe)
> +bool xe_wedged(struct xe_device *xe)
>  {
>  	return atomic_read(&xe->wedged.flag);
>  }

[Severity: Low]
Does this rename break the build by missing call sites in
drivers/gpu/drm/xe/xe_guc_pc.c?

Looking at xe_guc_pc.c, it seems xe_device_wedged() is still being called in
several places:

drivers/gpu/drm/xe/xe_guc_pc.c:pc_action_reset() {
	...
	ret = xe_guc_ct_send(ct, action, ARRAY_SIZE(action), 0, 0);
	if (ret && !(xe_device_wedged(pc_to_xe(pc)) && ret == -ECANCELED))
		xe_gt_err(pc_to_gt(pc), "GuC PC reset failed: %pe\n",
			  ERR_PTR(ret));
	...
}

Similar missed renames exist in pc_action_query_task_state(),
pc_action_set_param(), pc_action_unset_param(), and xe_guc_pc_fini_hw().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831042633.1760474-1-raag.jadav@intel.com?part=5