Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, Mika Kahola <mika.kahola@intel.com>
Subject: [PATCH v2 2/2] drm/i915/display: Reset use_flipq when duplicating crtc state
Date: Wed,  2 Sep 2026 10:54:47 +0000	[thread overview]
Message-ID: <20260902105448.809455-3-mika.kahola@intel.com> (raw)
In-Reply-To: <20260902105448.809455-1-mika.kahola@intel.com>

intel_crtc_duplicate_state() resets use_dsb to false but not
use_flipq, letting a stale true value survive into the new state.

Reset use_flipq alongside use_dsb.

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index 9d0d47c79dd1..b66c2d4ba2b3 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -276,6 +276,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->dsb_color = NULL;
 	crtc_state->dsb_commit = NULL;
 	crtc_state->use_dsb = false;
+	crtc_state->use_flipq = false;
 
 	return &crtc_state->uapi;
 }
-- 
2.43.0


  parent reply	other threads:[~2026-09-02 10:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 10:54 [PATCH v2 0/2] drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc Mika Kahola
2026-09-02 10:54 ` [PATCH v2 1/2] drm/i915/display: Reject flipq for pipe or timing changes Mika Kahola
2026-09-02 11:07   ` sashiko-bot
2026-09-02 11:55   ` [PATCH v2 1/2] drm/i915/display: Reject flipq for commits with no plane updates Mika Kahola
2026-09-02 11:59   ` [PATCH v2 1/2] drm/i915/display: Reject flipq for pipe or timing changes Jani Nikula
2026-09-02 12:24     ` Kahola, Mika
2026-09-02 12:27   ` Ville Syrjälä
2026-09-02 13:52     ` Kahola, Mika
2026-09-02 10:54 ` Mika Kahola [this message]
2026-09-02 13:33   ` [PATCH v2 2/2] drm/i915/display: Reset use_flipq when duplicating crtc state Ville Syrjälä
2026-09-02 14:08     ` Kahola, Mika
2026-09-02 11:26 ` ✓ CI.KUnit: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev2) Patchwork
2026-09-02 12:13 ` ✓ CI.KUnit: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev3) Patchwork
2026-09-02 12:19 ` ✗ Xe.CI.BAT: failure for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev2) Patchwork
2026-09-02 12:59 ` ✓ Xe.CI.BAT: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev3) Patchwork
2026-09-02 22:42 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902105448.809455-3-mika.kahola@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox