Re: [PATCH v2 2/2] drm/i915/display: Reset use_flipq when duplicating crtc state

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Sep 02, 2026 at 10:54:47AM +0000, Mika Kahola wrote:
> intel_crtc_duplicate_state() resets use_dsb to false but not
> use_flipq, letting a stale true value survive into the new state.
> 
> Reset use_flipq alongside use_dsb.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>

I had the same patch in some series, but that might need a rebase so
let's go with yours.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_atomic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
> index 9d0d47c79dd1..b66c2d4ba2b3 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic.c
> @@ -276,6 +276,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
>  	crtc_state->dsb_color = NULL;
>  	crtc_state->dsb_commit = NULL;
>  	crtc_state->use_dsb = false;
> +	crtc_state->use_flipq = false;
>  
>  	return &crtc_state->uapi;
>  }
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel