Re: [PATCH v3 01/12] drm/xe/cper: Hardware error CPER reporting from xe_log

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The condition `if ((int)sigid >= INTEL_SIGID_GPU_XE_HARDWARE_START)` in `xe_emit_hardware_error_cper()` is inverted, causing the function to immediately drop all hardware error signatures.
--

commit 8d5b33ea1e6386b119b58d344413a048df730b76
Author: Badal Nilawar <badal.nilawar@intel.com>

drm/xe/cper: Hardware error CPER reporting from xe_log

This commit introduces xe_emit_hardware_error_cper() as a public entry
point for CPER reporting. It also wires up xe_log to route hardware
SIGIDs through this new helper.

> diff --git a/drivers/gpu/drm/xe/xe_cper.c b/drivers/gpu/drm/xe/xe_cper.c
> new file mode 100644
> index 0000000000000..e8017e3ee3a09
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_cper.c

[ ... ]

> +void xe_emit_hardware_error_cper(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid,
> +				 struct xe_ras_error_class *counter,
> +				 struct xe_ras_get_counter_response *response)
> +{
> +	struct xe_device *xe = pdev_to_xe_device(pdev);
> +
> +	if (!xe)
> +		return;
> +
> +	if ((int)sigid >= INTEL_SIGID_GPU_XE_HARDWARE_START)
> +		return;

[Severity: High]
Is the condition here inverted?

Looking at log_emit_cper() in xe_log.c, it ensures the signature is a
hardware error before calling this helper:

xe_log.c:log_emit_cper() {
    ...
    if (is_hw_sigid(sigid) && !IS_ERR(data))
        xe_emit_hardware_error_cper(pdev, cper_sev, sigid,
                                    (struct xe_ras_error_class *)data, NULL);
    ...
}

Where is_hw_sigid() is defined as:

static bool is_hw_sigid(enum xe_sigid sigid)
{
    return (int)sigid >= INTEL_SIGID_GPU_XE_HARDWARE_START;
}

Since xe_emit_hardware_error_cper() immediately returns if the signature
meets this exact same condition, doesn't this unintentionally drop all valid
hardware signatures and prevent the records from being emitted?

> +
> +	/* TODO */
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906172604.2215987-14-badal.nilawar@intel.com?part=1