Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: mallesh.koujalagi@intel.com,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v2 05/13] drm/xe/memirq: Report errors using structured xe_log API
Date: Tue,  8 Sep 2026 15:48:41 +0530	[thread overview]
Message-ID: <20260908101849.1219614-6-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com>

Replace memirq_err() calls with xe_log_err() using the MEMIRQ
component tag for memory-based IRQ failures

v2:
- No need to log ERR_PTR(err) explicitly (Mallesh)
- Using tile instead of xe for more local log location(sashiko bot)

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
 drivers/gpu/drm/xe/xe_memirq.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
index 9dfe965cb46e..32b9f87a10ec 100644
--- a/drivers/gpu/drm/xe/xe_memirq.c
+++ b/drivers/gpu/drm/xe/xe_memirq.c
@@ -15,6 +15,7 @@
 #include "xe_gt.h"
 #include "xe_guc.h"
 #include "xe_hw_engine.h"
+#include "xe_log.h"
 #include "xe_memirq.h"
 #include "xe_tile_printk.h"
 
@@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq)
 	return 0;
 
 out:
-	memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
+	xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n");
 	return err;
 }
 
@@ -370,8 +371,8 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc)
 	return 0;
 
 failed:
-	memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n",
-		   guc_name(guc), ERR_PTR(err));
+	xe_log_err(memirq_to_tile(memirq), MEMIRQ, err,
+		   "Failed to setup report pages in %s\n", guc_name(guc));
 	return err;
 }
 
-- 
2.54.0


  parent reply	other threads:[~2026-09-08 10:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 10:18 [PATCH v2 00/13] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-09-08 10:23   ` sashiko-bot
2026-09-08 10:18 ` [PATCH v2 02/13] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 03/13] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 04/13] drm/xe/mmio: Report BAR mapping " Dnyaneshwar Bhadane
2026-09-08 10:18 ` Dnyaneshwar Bhadane [this message]
2026-09-08 10:28   ` [PATCH v2 05/13] drm/xe/memirq: Report " sashiko-bot
2026-09-08 10:18 ` [PATCH v2 06/13] drm/xe/reg_whitelist: Report whitelist overflow " Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 07/13] drm/xe/reg_sr: Report save-restore errors " Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 08/13] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 09/13] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:26   ` sashiko-bot
2026-09-08 10:18 ` [PATCH v2 10/13] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-09-08 10:28   ` sashiko-bot
2026-09-08 10:18 ` [PATCH v2 11/13] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 12/13] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-09-08 10:18 ` [PATCH v2 13/13] drm/xe/vram: Report VRAM errors using structured xe_log API Dnyaneshwar Bhadane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908101849.1219614-6-dnyaneshwar.bhadane@intel.com \
    --to=dnyaneshwar.bhadane@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox