Re: [RFC v2 21/21] drm/xe/svm: Distinguish access-counter-triggered range setup in logs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation of debug trace context separation
--

commit 7432312b157971575fb03d4801aac465020f0d08
Author: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

drm/xe/svm: Distinguish access-counter-triggered range setup in logs

This commit modifies __xe_svm_range_setup() to differentiate range_debug()
traces between page fault and access counter trigger paths.

> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> index 78a8c72cbbd68..d773a91d24922 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
[ ... ]
> @@ -1429,7 +1432,9 @@ static int __xe_svm_range_setup(struct xe_vm *vm, struct xe_vma *vma,
>  	range_debug(range, "GET PAGES");

[Severity: Medium]
This debug trace was missed and will log identically for both paths, failing
to provide the promised traceability. Should this code distinguish the paths
here too?

>  	err = xe_svm_range_get_pages(vm, range, &ctx);
>  	if (err == -EOPNOTSUPP)
> -		range_debug(range, "PAGE FAULT - EVICTED PAGES");
> +		range_debug(range, acc_ctr_trigger ?
> +			    "ACCESS COUNTER TRIGGERED - EVICTED PAGES" :
> +			    "PAGE FAULT - EVICTED PAGES");
[ ... ]

In the same function, there is another debug log that still hardcodes the word
"fault":

drivers/gpu/drm/xe/xe_svm.c:__xe_svm_range_setup() {
    ...
		if (err) {
			if (migrate_try_count || !ctx.devmem_only) {
				drm_dbg(&vm->xe->drm,
					"VRAM allocation failed, falling back to retrying fault, asid=%u, errno=%pe\n",
					vm->usm.asid, ERR_PTR(err));
    ...
}

[Severity: Medium]
The log message incorrectly assumes it's always a 'fault', which goes against
the goal of correctly distinguishing the execution context. Are we missing an
update to this message for the access counter trigger path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909124457.1610890-23-himal.prasad.ghimiray@intel.com?part=21