Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: imre.deak@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH v2] drm/{i915, xe}: add/move intel_opregion_suspend() to intel_display_driver_shutdown_late()
Date: Wed, 23 Sep 2026 15:54:19 +0300	[thread overview]
Message-ID: <20260923125419.1755740-1-jani.nikula@intel.com> (raw)
In-Reply-To: <a913a25a45ccf18159cbabb921111ae719b44d04.1790089118.git.jani.nikula@intel.com>

Add intel_opregion_suspend() to
intel_display_driver_shutdown_late(). This unifies the behaviour with
intel_display_driver_pm_suspend_late(), calling intel_opregion_suspend()
with IRQs disabled.

For xe, this delays intel_opregion_suspend() until after IRQ and GT
shutdown.

For i915, this starts calling intel_opregion_suspend() on shutdown.

v2: Move the call to intel_display_driver_shutdown_late() (Imre)

Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_driver.c | 2 ++
 drivers/gpu/drm/xe/display/xe_display.c             | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index abab457bce3a..f11cff0e1294 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -711,6 +711,8 @@ void intel_display_driver_shutdown_late(struct intel_display *display)
 	if (!HAS_DISPLAY(display))
 		return;
 
+	intel_opregion_suspend(display, PCI_D3cold);
+
 	/*
 	 * The only requirement is to reboot with display DC states disabled,
 	 * for now leaving all display power wells in the INIT power domain
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index b013ec00b75d..1e37b1c29bb1 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -176,8 +176,6 @@ void xe_display_shutdown(struct xe_device *xe)
 		return;
 
 	intel_display_driver_shutdown(display);
-
-	intel_opregion_suspend(display, PCI_D3cold);
 }
 
 void xe_display_shutdown_late(struct xe_device *xe)
-- 
2.47.3


  parent reply	other threads:[~2026-09-23 12:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 15:00 [PATCH 0/4] drm/{i915,xe}: some suspend/shutdown/resume unification Jani Nikula
2026-09-22 15:00 ` [PATCH 1/4] drm/{i915, xe}: make intel_dmc_suspend() part of display suspend/shutdown calls Jani Nikula
2026-09-23 10:37   ` [PATCH 1/4] drm/{i915,xe}: " Imre Deak
2026-09-22 15:00 ` [PATCH 2/4] drm/{i915, xe}: move intel_opregion_suspend() to intel_display_driver_pm_suspend_late() Jani Nikula
2026-09-22 15:16   ` sashiko-bot
2026-09-23 11:20   ` [PATCH 2/4] drm/{i915,xe}: " Imre Deak
2026-09-23 12:53     ` Jani Nikula
2026-09-22 15:00 ` [PATCH 3/4] drm/{i915, xe}: add/move intel_opregion_suspend() to intel_display_driver_shutdown() Jani Nikula
2026-09-23 11:23   ` [PATCH 3/4] drm/{i915,xe}: " Imre Deak
2026-09-23 12:54   ` Jani Nikula [this message]
2026-09-23 13:41     ` [PATCH v2] drm/{i915,xe}: add/move intel_opregion_suspend() to intel_display_driver_shutdown_late() Imre Deak
2026-09-22 15:00 ` [PATCH 4/4] drm/{i915, xe}: keep moving stuff to intel_display_driver_pm_resume() Jani Nikula
2026-09-22 15:59 ` ✓ CI.KUnit: success for drm/{i915,xe}: some suspend/shutdown/resume unification Patchwork
2026-09-22 18:44 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-23  3:51 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-23 13:03 ` ✓ CI.KUnit: success for drm/{i915,xe}: some suspend/shutdown/resume unification (rev2) Patchwork
2026-09-23 14:33 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24  2:51 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-28 15:34 ` ✓ CI.KUnit: success for drm/{i915,xe}: some suspend/shutdown/resume unification (rev3) Patchwork
2026-09-28 16:30 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-28 19:32 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923125419.1755740-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox