Re: [PATCH 3/4] drm/{i915,xe}: add/move intel_opregion_suspend() to intel_display_driver_shutdown()

[Imre Deak <imre.deak@intel.com>]

On Tue, Sep 22, 2026 at 06:00:51PM +0300, Jani Nikula wrote:
> Add intel_opregion_suspend() to intel_display_driver_shutdown(). For xe,
> there's no change, but for i915, this starts calling
> intel_opregion_suspend() on shutdown.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_driver.c | 2 ++
>  drivers/gpu/drm/xe/display/xe_display.c             | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
> index abab457bce3a..d452506ecbc4 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_driver.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
> @@ -704,6 +704,8 @@ void intel_display_driver_shutdown(struct intel_display *display)
>  	__intel_display_driver_pm_suspend(display, true);
>  
>  	intel_encoder_shutdown_all(display);
> +
> +	intel_opregion_suspend(display, PCI_D3cold);

Could it be moved to intel_display_driver_shutdown_late() instead to
make it symmetric with suspend and to call it after IRQs are disabled
already?

>  }
>  
>  void intel_display_driver_shutdown_late(struct intel_display *display)
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index b013ec00b75d..1e37b1c29bb1 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -176,8 +176,6 @@ void xe_display_shutdown(struct xe_device *xe)
>  		return;
>  
>  	intel_display_driver_shutdown(display);
> -
> -	intel_opregion_suspend(display, PCI_D3cold);
>  }
>  
>  void xe_display_shutdown_late(struct xe_device *xe)
> -- 
> 2.47.3
>