Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] drm/xe: Skip GT TLB invalidation when VM has no queues mapped
@ 2026-09-29 23:35 Matthew Brost
  2026-09-29 23:43 ` ✓ CI.KUnit: success for drm/xe: Skip GT TLB invalidation when VM has no queues mapped (rev2) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Matthew Brost @ 2026-09-29 23:35 UTC (permalink / raw)
  To: intel-xe

If no exec queues from a VM are mapped on a GT, issuing a PPGTT TLB
invalidation for that GT can require an rc6 wake which is expensive.

Skip the media TLB invalidation when the VM has no exec queues
mapped on it. If TLB invalidations are already in-flight on that GT
we can't break fence ordering, so issue a dummy GGTT invalidation
instead to maintain seqno ordering.

This optimization is particularly impactful for SVM workloads which
may or may not use the media GT. Average TLB invalidation time drops
from ~75us to ~18us in such benchmarks on certain BMG parts - the
improvement varies based on platform.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>

---
v2:
 - Make GT generic rather than just media GT (Thomas)
 - Fix accounting bug in empty vs non-empty (CI)
v3:
 - Don't skip on platforms which don't support an asid (Sashiko)
---
 drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 25 +++++++++++++++++++++++--
 drivers/gpu/drm/xe/xe_vm.c            | 12 ++----------
 2 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
index 111fef781b2a..fcbbb8714dfc 100644
--- a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
+++ b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c
@@ -232,11 +232,32 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno,
 				     struct drm_suballoc *prl_sa)
 {
 	struct xe_guc *guc = tlb_inval->private;
+	struct xe_device *xe = guc_to_xe(guc);
+	struct xe_vm *vm;
+	int err, id = guc_to_gt(guc)->info.id;
 
 	lockdep_assert_held(&tlb_inval->seqno_lock);
 
-	return send_tlb_inval_ppgtt(guc, seqno, start, end, asid,
-				    XE_GUC_TLB_INVAL_PAGE_SELECTIVE, prl_sa);
+	if (!xe->info.has_asid)
+		return send_tlb_inval_ppgtt(guc, seqno, start, end, asid,
+					    XE_GUC_TLB_INVAL_PAGE_SELECTIVE,
+					    prl_sa);
+
+	vm = xe_device_asid_to_vm(xe, asid);
+	if (IS_ERR(vm))
+		return PTR_ERR(vm);
+
+	down_read(&vm->exec_queues.lock);
+	if (!vm->exec_queues.count[id] && xe_tlb_inval_idle(tlb_inval))
+		err = -ECANCELED;
+	else
+		err = send_tlb_inval_ppgtt(guc, seqno, start, end, asid,
+					   XE_GUC_TLB_INVAL_PAGE_SELECTIVE,
+					   prl_sa);
+	up_read(&vm->exec_queues.lock);
+	xe_vm_put(vm);
+
+	return err;
 }
 
 static int send_tlb_inval_ctx_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno,
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 1785bd3ade12..884cf3779a8e 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -5483,8 +5483,7 @@ int xe_vm_alloc_cpu_addr_mirror_vma(struct xe_vm *vm, uint64_t start, uint64_t r
  * @vm: The VM.
  * @q: The exec_queue
  *
- * Add exec queue to VM, skipped if the device does not have context based TLB
- * invalidations.
+ * Add exec queue to VM.
  */
 void xe_vm_add_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
 {
@@ -5497,9 +5496,6 @@ void xe_vm_add_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
 	xe_assert(xe, vm->xef);
 	xe_assert(xe, vm == q->vm);
 
-	if (!xe->info.has_ctx_tlb_inval)
-		return;
-
 	down_write(&vm->exec_queues.lock);
 	list_add(&q->vm_exec_queue_link, &vm->exec_queues.list[q->gt->info.id]);
 	++vm->exec_queues.count[q->gt->info.id];
@@ -5511,14 +5507,10 @@ void xe_vm_add_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
  * @vm: The VM.
  * @q: The exec_queue
  *
- * Remove exec queue from VM, skipped if the device does not have context based
- * TLB invalidations.
+ * Remove exec queue from VM.
  */
 void xe_vm_remove_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
 {
-	if (!vm->xe->info.has_ctx_tlb_inval)
-		return;
-
 	down_write(&vm->exec_queues.lock);
 	if (!list_empty(&q->vm_exec_queue_link)) {
 		list_del(&q->vm_exec_queue_link);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-30  8:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 23:35 [PATCH v3] drm/xe: Skip GT TLB invalidation when VM has no queues mapped Matthew Brost
2026-09-29 23:43 ` ✓ CI.KUnit: success for drm/xe: Skip GT TLB invalidation when VM has no queues mapped (rev2) Patchwork
2026-09-30  1:54 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-30  8:39 ` ✗ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox