Re: [PATCH v7 5/5] drm/xe/ggtt: Add KUnit tests for usable and shareable pools

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Jani Nikula <jani.nikula@linux.intel.com> wrote on wto [2026-paź-27 18:31:53 +0200]:
> On Wed, 21 Oct 2026, Piórkowski, Piotr <piotr.piorkowski@intel.com> wrote:
> > diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> > index b7e3d626e8cb8..3dd029bc76dfc 100644
> > --- a/drivers/gpu/drm/xe/xe_ggtt.c
> > +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> > @@ -1395,3 +1395,7 @@ u64 xe_ggtt_node_size(const struct xe_ggtt_node *node)
> >  {
> >  	return node->base.size;
> >  }
> > +
> > +#if IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST)
> > +#include "tests/xe_ggtt_kunit.c"
> > +#endif
> 
> Why IS_BUILTIN()?
> 
> It smells like a mistake.
> 
> 
> BR,
> Jani.
Hello Jani,

I simply used a pattern that had already been used earlier in the other files — to be honest,
I didn't give it any further thought.

List of files with #if IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST)
xe_lmtt.c
xe_guc_db_mgr.c
xe_guc_relay.c
xe_guc_id_mgr.c
xe_sriov_pf_service.c
xe_guc_buf.c
xe_gt_sriov_pf_config.c
xe_guc_klv_helpers.c
xe_sriov_packet.c
xe_log.c

If we have to use IS_ENABLED In that case, I guess we'll have to fix that
in the other places as well.

Thanks,
Piotr
> 
> 
> -- 
> Jani Nikula, Intel

--