Re: [PATCH v3 18/19] drm/xe/bo: Add attributes field to xe_bo

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 29-05-2025 05:17, Matthew Brost wrote:
> On Tue, May 27, 2025 at 10:10:02PM +0530, Himal Prasad Ghimiray wrote:
>> A single BO can be linked to multiple VMAs, making VMA attributes
>> insufficient for determining the placement and PTE update attributes
>> of the BO. To address this, an attributes field has been added to the
>> BO.
>>
>> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_bo_types.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_bo_types.h b/drivers/gpu/drm/xe/xe_bo_types.h
>> index eb5e83c5f233..70960368a5a8 100644
>> --- a/drivers/gpu/drm/xe/xe_bo_types.h
>> +++ b/drivers/gpu/drm/xe/xe_bo_types.h
>> @@ -62,6 +62,11 @@ struct xe_bo {
>>   	 */
>>   	struct list_head client_link;
>>   #endif
>> +	/** @attr: User controlled attributes for bo */
>> +	struct {
>> +		/** @atomic_access: type of atomic access bo needs */
> 
> , protected by BO dma-resv lock.
> 
> Missed above in previous rev, RB stands.

Will add in next rev. Thanks.

> 
> Matt
> 
>> +		u32 atomic_access;
>> +	} attr;
>>   	/**
>>   	 * @pxp_key_instance: PXP key instance this BO was created against. A
>>   	 * 0 in this variable indicates that the BO does not use PXP encryption.
>> -- 
>> 2.34.1
>>