Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v6 0/9] drm/xe/sysctrl: Clean up error handling in
@ 2026-08-31 10:44 Mallesh Koujalagi
  2026-08-31 10:44 ` [PATCH v6 1/9] drm/xe/sysctrl: Return error codes from sysctrl_wait_bit_clear() Mallesh Koujalagi
                   ` (11 more replies)
  0 siblings, 12 replies; 24+ messages in thread
From: Mallesh Koujalagi @ 2026-08-31 10:44 UTC (permalink / raw)
  To: intel-xe, rodrigo.vivi, matthew.brost
  Cc: anshuman.gupta, badal.nilawar, vinay.belgaumkar, riana.tauro,
	karthik.poosa, sk.anirban, raag.jadav, michal.wajdeczko,
	aravind.iddamsetty, umesh.nerlige.ramappa, dnyaneshwar.bhadane,
	anoop.c.vijay, Mallesh Koujalagi

The patch series improves error handling in the System Controller mailbox
driver by making error propagation more consistent and using
xe_log_err() for structured error reporting.

It also removes a few redundant checks and simplifies helper
interfaces where no error path exists.

v2:
- Use -EOVERFLOW.
- Drop sysctrl in xe_log_err. (Michal)
- Drop redundant %pe.
- Print response->count.

v3:
- Rebase.

v4:
- Replace xe_warn to xe_log_err_info for. (Michal)
- Use xe_assert().
- Change sysctrl_wait_bit_* to return errno.
- Make sysctrl_write_frame return type as void.
- Log mismatched header info.

v5:
- Fix align issue. (Michal)
- Use %#x after REG_FIELD_GET change.
- Use REG_FIELD_GET instead of FIELD_GET.
- Modify logging message.
- Change Error as EXFULL.
- Update logging message.

v6:
- Move REG_FIELD_GET to different patch. (Michal)
- Update response message.
- Move all REG_FIELD_GET to single patch.
- Update log message. (Michal)
- Change correct errno. (Michal)

Mallesh Koujalagi (9):
  drm/xe/sysctrl: Return error codes from sysctrl_wait_bit_clear()
  drm/xe/sysctrl: Return error codes from sysctrl_wait_bit_set()
  drm/xe/sysctrl: Make sysctrl_write_frame() void
  drm/xe/sysctrl: Make sysctrl_read_frame() void
  drm/xe/sysctrl: Use xe_assert() for payload size validation
  drm/xe/sysctrl: Replace FIELD_GET() with REG_FIELD_GET()
  drm/xe/sysctrl: Improve firmware response error logging
  drm/xe/sysctrl: Log group and command ID on mailbox failure
  drm/xe/sysctrl: Report 'System Controller event' error using SIGID

 drivers/gpu/drm/xe/xe_sysctrl_event.c   | 14 ++--
 drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 96 +++++++++++--------------
 drivers/gpu/drm/xe/xe_sysctrl_mailbox.h |  6 +-
 3 files changed, 54 insertions(+), 62 deletions(-)

-- 
2.48.1


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2026-09-04  6:03 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 10:44 [PATCH v6 0/9] drm/xe/sysctrl: Clean up error handling in Mallesh Koujalagi
2026-08-31 10:44 ` [PATCH v6 1/9] drm/xe/sysctrl: Return error codes from sysctrl_wait_bit_clear() Mallesh Koujalagi
2026-08-31 10:55   ` sashiko-bot
2026-09-04  6:01   ` Tauro, Riana
2026-08-31 10:44 ` [PATCH v6 2/9] drm/xe/sysctrl: Return error codes from sysctrl_wait_bit_set() Mallesh Koujalagi
2026-08-31 10:59   ` sashiko-bot
2026-08-31 10:45 ` [PATCH v6 3/9] drm/xe/sysctrl: Make sysctrl_write_frame() void Mallesh Koujalagi
2026-08-31 10:45 ` [PATCH v6 4/9] drm/xe/sysctrl: Make sysctrl_read_frame() void Mallesh Koujalagi
2026-09-02 16:16   ` Michal Wajdeczko
2026-09-03  4:45     ` Mallesh, Koujalagi
2026-08-31 10:45 ` [PATCH v6 5/9] drm/xe/sysctrl: Use xe_assert() for payload size validation Mallesh Koujalagi
2026-08-31 10:45 ` [PATCH v6 6/9] drm/xe/sysctrl: Replace FIELD_GET() with REG_FIELD_GET() Mallesh Koujalagi
2026-08-31 11:07   ` sashiko-bot
2026-08-31 10:45 ` [PATCH v6 7/9] drm/xe/sysctrl: Improve firmware response error logging Mallesh Koujalagi
2026-08-31 11:00   ` sashiko-bot
2026-09-02 16:22   ` Michal Wajdeczko
2026-09-03  4:59     ` Mallesh, Koujalagi
2026-08-31 10:45 ` [PATCH v6 8/9] drm/xe/sysctrl: Log group and command ID on mailbox failure Mallesh Koujalagi
2026-08-31 11:00   ` sashiko-bot
2026-08-31 10:45 ` [PATCH v6 9/9] drm/xe/sysctrl: Report 'System Controller event' error using SIGID Mallesh Koujalagi
2026-08-31 11:00   ` sashiko-bot
2026-08-31 14:37 ` ✓ CI.KUnit: success for drm/xe/sysctrl: Clean up error handling in (rev3) Patchwork
2026-08-31 15:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-31 17:52 ` ✗ Xe.CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox