From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Harrison, John C" <john.c.harrison@intel.com>,
"Dong, Zhanjun" <zhanjun.dong@intel.com>,
"Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"Brost, Matthew" <matthew.brost@intel.com>
Subject: Re: [PATCH v6 4/6] drm/xe/guc: Move xe_hw_engine_snapshot creation back to xe_hw_engine.c
Date: Fri, 31 Jan 2025 18:56:08 +0000 [thread overview]
Message-ID: <2df2e1ac9bbd72c9766e7fffdfe4c6e87489b219.camel@intel.com> (raw)
In-Reply-To: <Z5wAq14aXXIccYhI@intel.com>
On Thu, 2025-01-30 at 17:43 -0500, Vivi, Rodrigo wrote:
> On Tue, Jan 28, 2025 at 10:36:50AM -0800, Alan Previn wrote:
alan:snip
> > @@ -55,8 +55,7 @@ void xe_hw_engine_handle_irq(struct xe_hw_engine *hwe, u16 intr_vec);
> > void xe_hw_engine_enable_ring(struct xe_hw_engine *hwe);
> > u32 xe_hw_engine_mask_per_class(struct xe_gt *gt,
> > enum xe_engine_class engine_class);
> > -struct xe_hw_engine_snapshot *
> > -xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe, struct xe_exec_queue *q);
> > +void xe_engine_snapshot_capture_for_queue(struct xe_exec_queue *q);
>
> here as well. please respect the name space.
alan: my bad - will fix this (and the same in last patch).
>
> > void xe_hw_engine_snapshot_free(struct xe_hw_engine_snapshot *snapshot);
> > void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drm_printer *p);
> > void xe_hw_engine_print(struct xe_hw_engine *hwe, struct drm_printer *p);
> > --
> > 2.34.1
> >
next prev parent reply other threads:[~2025-01-31 18:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 18:36 [PATCH v6 0/6] Maintenence of devcoredump <-> GuC-Err-Capture plumbing Alan Previn
2025-01-28 18:36 ` [PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output Alan Previn
2025-01-30 22:37 ` Rodrigo Vivi
2025-01-31 18:44 ` Teres Alexis, Alan Previn
2025-02-10 19:01 ` Dong, Zhanjun
2025-01-28 18:36 ` [PATCH v6 2/6] drm/xe/guc: Don't store capture nodes in xe_devcoredump_snapshot Alan Previn
2025-01-30 17:57 ` Teres Alexis, Alan Previn
2025-02-10 23:41 ` Dong, Zhanjun
2025-02-12 19:25 ` Teres Alexis, Alan Previn
2025-01-28 18:36 ` [PATCH v6 3/6] drm/xe/guc: Split engine state print between xe_hw_engine vs xe_guc_capture Alan Previn
2025-01-30 22:42 ` Rodrigo Vivi
2025-01-31 18:55 ` Teres Alexis, Alan Previn
2025-02-10 18:45 ` Teres Alexis, Alan Previn
2025-01-28 18:36 ` [PATCH v6 4/6] drm/xe/guc: Move xe_hw_engine_snapshot creation back to xe_hw_engine.c Alan Previn
2025-01-30 22:43 ` Rodrigo Vivi
2025-01-31 18:56 ` Teres Alexis, Alan Previn [this message]
2025-01-28 18:36 ` [PATCH v6 5/6] drm/xe/xe_hw_engine: Update hw_engine_snapshot_capture for debugfs Alan Previn
2025-01-28 20:45 ` kernel test robot
2025-01-28 18:36 ` [PATCH v6 6/6] drm/xe/guc: Update comments on GuC-Err-Capture flows Alan Previn
2025-01-28 21:19 ` ✓ CI.Patch_applied: success for Maintenence of devcoredump <-> GuC-Err-Capture plumbing Patchwork
2025-01-28 21:21 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-28 21:22 ` ✓ CI.KUnit: success " Patchwork
2025-01-28 21:38 ` ✓ CI.Build: " Patchwork
2025-01-28 21:40 ` ✗ CI.Hooks: failure " Patchwork
2025-01-28 21:41 ` ✓ CI.checksparse: success " Patchwork
2025-01-28 22:01 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-29 12:54 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-30 17:13 ` Teres Alexis, Alan Previn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df2e1ac9bbd72c9766e7fffdfe4c6e87489b219.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox