Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/1] drm/xe/guc: Fix GuC log/ct output via debugfs
@ 2025-01-07 20:22 Julia Filipchuk
  2025-01-07 20:57 ` ✓ CI.Patch_applied: success for series starting with [v3,1/1] " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 22+ messages in thread
From: Julia Filipchuk @ 2025-01-07 20:22 UTC (permalink / raw)
  To: intel-xe; +Cc: Julia Filipchuk

Change to disable asci85 GuC logging only when output to devcoredump
(was temporarily disabled for all code paths).

v2: Ignore only for devcoredump case (not dmesg output).
v3: Rebase to resolve parent tag mismatch.

Signed-off-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 8 +++++---
 include/drm/drm_print.h             | 2 ++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 6980304c8903..8e5d1f9866a7 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -424,10 +424,12 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
 	 * Splitting blobs across multiple lines is not compatible with the mesa
 	 * debug decoder tool. Note that even dropping the explicit '\n' below
 	 * doesn't help because the GuC log is so big some underlying implementation
-	 * still splits the lines at 512K characters. So just bail completely for
-	 * the moment.
+	 * still splits the lines at 512K characters.
+	 *
+	 * Only disable from devcoredump output.
 	 */
-	return;
+	if (p->coredump)
+		return;
 
 #define DMESG_MAX_LINE_LEN	800
 #define MIN_SPACE		(ASCII85_BUFSZ + 2)		/* 85 + "\n\0" */
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index f77fe1531cf8..f5ea7f38ba09 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -182,6 +182,7 @@ struct drm_printer {
 		unsigned int counter;
 	} line;
 	enum drm_debug_category category;
+	bool coredump;
 };
 
 void __drm_printfn_coredump(struct drm_printer *p, struct va_format *vaf);
@@ -335,6 +336,7 @@ drm_coredump_printer(struct drm_print_iterator *iter)
 		.printfn = __drm_printfn_coredump,
 		.puts = __drm_puts_coredump,
 		.arg = iter,
+		.coredump = true,
 	};
 
 	/* Set the internal offset of the iterator to zero */
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2025-01-23 14:21 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-07 20:22 [PATCH v3 1/1] drm/xe/guc: Fix GuC log/ct output via debugfs Julia Filipchuk
2025-01-07 20:57 ` ✓ CI.Patch_applied: success for series starting with [v3,1/1] " Patchwork
2025-01-07 20:58 ` ✓ CI.checkpatch: " Patchwork
2025-01-07 20:59 ` ✓ CI.KUnit: " Patchwork
2025-01-07 21:10 ` [PATCH v3 1/1] " Lucas De Marchi
2025-01-08 20:14   ` John Harrison
2025-01-08 22:11     ` Lucas De Marchi
2025-01-08 23:59       ` John Harrison
2025-01-09 15:39         ` Lucas De Marchi
2025-01-09 20:40           ` John Harrison
2025-01-09 22:43             ` Lucas De Marchi
2025-01-22 16:45               ` John Harrison
2025-01-22 16:59                 ` Souza, Jose
2025-01-22 18:29                   ` Souza, Jose
2025-01-22 21:09                     ` John Harrison
2025-01-23 14:02                       ` Souza, Jose
2025-01-23 14:21                         ` Lucas De Marchi
2025-01-07 21:25 ` ✓ CI.Build: success for series starting with [v3,1/1] " Patchwork
2025-01-07 21:28 ` ✓ CI.Hooks: " Patchwork
2025-01-07 21:30 ` ✓ CI.checksparse: " Patchwork
2025-01-07 21:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-09 10:47 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox