Re: [PATCH 5/5] drm/xe/tests: Use xe_root_mmio_gt instead of xe_device_get_gt

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 9/26/2025 5:59 PM, Jonathan Cavitt wrote:
> xe_root_mmio_gt(xe) is equivalent to xe_device_get_gt(xe, 0) in terms of
> return value, but it takes up less line space and is slightly more
> efficient during execution.  Replace instances of the latter with the
> former in the xe test code.

I guess the rationale here is not about efficiency, but rather that
tests just expects root GT0 to be always available as part of the
test setup, so there is no point is using more flexible function that
actually may fail in some cases

otherwise, LGTM

(as in tests we likely wont be able to disable GT0 by configfs ;)

> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c   | 2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c | 2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c    | 2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c | 2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_relay_test.c  | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c b/drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c
> index d266882adc0e..33dbcb262204 100644
> --- a/drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c
> +++ b/drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c
> @@ -63,7 +63,7 @@ static int guc_buf_test_init(struct kunit *test)
>  	xe_kunit_helper_xe_device_test_init(test);
>  
>  	ggtt = xe_device_get_root_tile(test->priv)->mem.ggtt;
> -	guc = &xe_device_get_gt(test->priv, 0)->uc.guc;
> +	guc = &xe_root_mmio_gt(test->priv)->uc.guc;
>  
>  	KUNIT_ASSERT_EQ(test, 0,
>  			xe_ggtt_init_kunit(ggtt, DUT_GGTT_START,
> diff --git a/drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c b/drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c
> index a87a7b4b040a..59a7c2d57fe2 100644
> --- a/drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c
> @@ -13,7 +13,7 @@ static int guc_dbm_test_init(struct kunit *test)
>  	struct xe_guc_db_mgr *dbm;
>  
>  	xe_kunit_helper_xe_device_test_init(test);
> -	dbm = &xe_device_get_gt(test->priv, 0)->uc.guc.dbm;
> +	dbm = &xe_root_mmio_gt(test->priv)->uc.guc.dbm;
>  
>  	mutex_init(dbm_mutex(dbm));
>  	test->priv = dbm;
> diff --git a/drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c b/drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c
> index 3b213fcae916..d211dfa09538 100644
> --- a/drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c
> @@ -355,7 +355,7 @@ static void g2g_distribute(struct kunit *test, struct xe_device *xe, struct xe_b
>  	struct xe_gt *root_gt, *gt;
>  	int i;
>  
> -	root_gt = xe_device_get_gt(xe, 0);
> +	root_gt = xe_root_mmio_gt(xe);
>  	root_gt->uc.guc.g2g.bo = bo;
>  	root_gt->uc.guc.g2g.owned = true;
>  	kunit_info(test, "[%d.%d] Assigned 0x%p\n", gt_to_tile(root_gt)->id, root_gt->info.id, bo);
> diff --git a/drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c b/drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c
> index ee30a1939eb0..3c84bcacd0ac 100644
> --- a/drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c
> @@ -13,7 +13,7 @@ static int guc_id_mgr_test_init(struct kunit *test)
>  	struct xe_guc_id_mgr *idm;
>  
>  	xe_kunit_helper_xe_device_test_init(test);
> -	idm = &xe_device_get_gt(test->priv, 0)->uc.guc.submission_state.idm;
> +	idm = &xe_root_mmio_gt(test->priv)->uc.guc.submission_state.idm;
>  
>  	mutex_init(idm_mutex(idm));
>  	test->priv = idm;
> diff --git a/drivers/gpu/drm/xe/tests/xe_guc_relay_test.c b/drivers/gpu/drm/xe/tests/xe_guc_relay_test.c
> index 13701451b923..645c8b6de3db 100644
> --- a/drivers/gpu/drm/xe/tests/xe_guc_relay_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_guc_relay_test.c
> @@ -38,7 +38,7 @@ static int relay_test_init(struct kunit *test)
>  	xe = test->priv;
>  	KUNIT_ASSERT_EQ(test, xe_sriov_init(xe), 0);
>  
> -	relay = &xe_device_get_gt(xe, 0)->uc.guc.relay;
> +	relay = &xe_root_mmio_gt(xe)->uc.guc.relay;
>  	kunit_activate_static_stub(test, relay_get_totalvfs,
>  				   replacement_relay_get_totalvfs);
>