Re: [PATCH 3/5] drm/xe: Don't call xe_device_get_gt twice in xe_hw_engine_lookup

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 9/26/2025 5:59 PM, Jonathan Cavitt wrote:
> We already initialize a
> struct xe_gt *gt = xe_device_get_gt(xe, eci.gt_id)
> in xe_hw_engine_lookup to ensure the given gt_id is valid.
> We don't need to call xe_device_get_gt again to pass the same gt to
> xe_gt_hw_engine in xe_hw_engine_lookup.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_hw_engine.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index 1cf623b4a5bc..f4b9857d6195 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -1071,7 +1071,6 @@ xe_hw_engine_lookup(struct xe_device *xe,
>  	idx = array_index_nospec(eci.engine_class,
>  				 ARRAY_SIZE(user_to_xe_engine_class));
>  
> -	return xe_gt_hw_engine(xe_device_get_gt(xe, eci.gt_id),
> -			       user_to_xe_engine_class[idx],
> +	return xe_gt_hw_engine(gt, user_to_xe_engine_class[idx],
>  			       eci.engine_instance, true);
>  }