Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Zhanjun Dong <zhanjun.dong@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH v7 6/7] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup
Date: Fri, 20 Feb 2026 21:40:36 +0100	[thread overview]
Message-ID: <346779f5-1a18-47d2-8cfb-8f80eb9fe98b@intel.com> (raw)
In-Reply-To: <20260219180701.2418453-7-zhanjun.dong@intel.com>



On 2/19/2026 7:07 PM, Zhanjun Dong wrote:
> If the firmware fails to load in GT resets the device is wedged also
> initiating a GuC state cleanup.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_uc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index d9aa845a308d..9db656b95bff 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -172,7 +172,6 @@ static int vf_uc_load_hw(struct xe_uc *uc)
>  	return 0;
>  
>  err_out:
> -	xe_guc_sanitize(&uc->guc);

as jump to this label is now a NOP, maybe we should just convert all goto's to immediate return's ?

>  	return err;
>  }
>  
> @@ -234,7 +233,6 @@ int xe_uc_load_hw(struct xe_uc *uc)
>  	return 0;
>  
>  err_out:
> -	xe_guc_sanitize(&uc->guc);

ditto

>  	return ret;
>  }
>  


  reply	other threads:[~2026-02-20 20:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 18:06 [PATCH v7 0/7] Attempt to fixup reset, wedge, unload corner cases Zhanjun Dong
2026-02-19 18:06 ` [PATCH v7 1/7] drm/xe: Always kill exec queues in xe_guc_submit_pause_abort Zhanjun Dong
2026-02-19 18:06 ` [PATCH v7 2/7] drm/xe: Forcefully tear down exec queues in GuC submit fini Zhanjun Dong
2026-02-20 20:36   ` Michal Wajdeczko
2026-02-20 23:36     ` Matthew Brost
2026-02-19 18:06 ` [PATCH v7 3/7] drm/xe: Trigger queue cleanup if not in wedged mode 2 Zhanjun Dong
2026-02-19 18:06 ` [PATCH v7 4/7] drm/xe: Use XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET enum instead of magic number Zhanjun Dong
2026-02-20 18:12   ` Matthew Brost
2026-02-19 18:06 ` [PATCH v7 5/7] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED Zhanjun Dong
2026-02-19 18:07 ` [PATCH v7 6/7] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup Zhanjun Dong
2026-02-20 20:40   ` Michal Wajdeczko [this message]
2026-02-19 18:07 ` [PATCH v7 7/7] drm/xe: Open-code GGTT MMIO access protection Zhanjun Dong
2026-02-19 18:34 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases Patchwork
2026-02-20  8:37 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-20 12:59 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=346779f5-1a18-47d2-8cfb-8f80eb9fe98b@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox