Re: [PATCH v7 4/7] drm/xe: Use XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET enum instead of magic number

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Feb 19, 2026 at 01:06:58PM -0500, Zhanjun Dong wrote:
> Replace the magic number 2 with the proper enum value
> XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET for better code readability
> and maintainability.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 91c7600a59f5..cd434caec9c2 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1334,12 +1334,13 @@ void xe_guc_submit_wedge(struct xe_guc *guc)
>  	if (!guc->submission_state.initialized)
>  		return;
>  
> -	if (xe->wedged.mode == 2) {
> +	if (xe->wedged.mode == XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET) {
>  		err = devm_add_action_or_reset(guc_to_xe(guc)->drm.dev,
>  					       guc_submit_wedged_fini, guc);
>  		if (err) {
> -			xe_gt_err(gt, "Failed to register clean-up on wedged.mode=2; "
> -				  "Although device is wedged.\n");
> +			xe_gt_err(gt, "Failed to register clean-up on wedged.mode=%s; "
> +				  "Although device is wedged.\n",
> +				  xe_wedged_mode_to_string(XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET));
>  			return;
>  		}
>  
> -- 
> 2.34.1
>