Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] drm/xe/mert: Normalize xe_mert.h include guards
Date: Fri, 9 Jan 2026 16:59:57 +0100	[thread overview]
Message-ID: <35fe757f-4a47-4917-8ace-8fc497bd693b@intel.com> (raw)
In-Reply-To: <20260109151219.26206-2-michal.wajdeczko@intel.com>


On 1/9/2026 16:12, Michal Wajdeczko wrote:
> Most of our header files are using include guard names with single
> underscore and we don't use trailing comments on final #endif.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>

Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_mert.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_mert.h b/drivers/gpu/drm/xe/xe_mert.h
> index 2e14c5dec008..0de8243e46bd 100644
> --- a/drivers/gpu/drm/xe/xe_mert.h
> +++ b/drivers/gpu/drm/xe/xe_mert.h
> @@ -3,8 +3,8 @@
>    * Copyright(c) 2025, Intel Corporation. All rights reserved.
>    */
>   
> -#ifndef __XE_MERT_H__
> -#define __XE_MERT_H__
> +#ifndef _XE_MERT_H_
> +#define _XE_MERT_H_
>   
>   #include <linux/completion.h>
>   #include <linux/spinlock.h>
> @@ -29,4 +29,4 @@ void xe_mert_irq_handler(struct xe_device *xe, u32 master_ctl);
>   static inline void xe_mert_irq_handler(struct xe_device *xe, u32 master_ctl) { }
>   #endif
>   
> -#endif /* __XE_MERT_H__ */
> +#endif

  reply	other threads:[~2026-01-09 16:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 15:12 [PATCH 0/5] drm/xe/mert: Minor improvements to MERT code Michal Wajdeczko
2026-01-09 15:12 ` [PATCH 1/5] drm/xe/mert: Normalize xe_mert.h include guards Michal Wajdeczko
2026-01-09 15:59   ` Laguna, Lukasz [this message]
2026-01-09 15:12 ` [PATCH 2/5] drm/xe/mert: Fix kernel-doc for struct xe_mert Michal Wajdeczko
2026-01-09 16:00   ` Laguna, Lukasz
2026-01-09 15:12 ` [PATCH 3/5] drm/xe/mert: Always refer to MERT using xe_device Michal Wajdeczko
2026-01-09 17:04   ` Laguna, Lukasz
2026-01-11 21:38   ` [PATCH v2 " Michal Wajdeczko
2026-01-09 15:12 ` [PATCH 4/5] drm/xe/mert: Use local mert variable to simplify the code Michal Wajdeczko
2026-01-09 16:21   ` Laguna, Lukasz
2026-01-09 15:12 ` [PATCH 5/5] drm/xe/mert: Move MERT initialization to xe_mert.c Michal Wajdeczko
2026-01-09 17:07   ` Laguna, Lukasz
2026-01-09 15:19 ` ✓ CI.KUnit: success for drm/xe/mert: Minor improvements to MERT code Patchwork
2026-01-09 16:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-09 16:49 ` [PATCH 0/5] " Laguna, Lukasz
2026-01-09 20:02 ` ✓ Xe.CI.Full: success for " Patchwork
2026-01-11 21:50 ` ✓ CI.KUnit: success for drm/xe/mert: Minor improvements to MERT code (rev2) Patchwork
2026-01-11 22:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-11 23:18 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35fe757f-4a47-4917-8ace-8fc497bd693b@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox