From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] drm/xe/mert: Minor improvements to MERT code
Date: Fri, 9 Jan 2026 17:49:59 +0100 [thread overview]
Message-ID: <eeafeb5b-d09b-4781-97a2-d5d797d65649@intel.com> (raw)
In-Reply-To: <20260109151219.26206-1-michal.wajdeczko@intel.com>
As you are making MERT code improvements, could you consider changing
the log level of the message below on the occasion?
drm_dbg(&xe->drm, "MERT catastrophic error: Unexpected fault
(0x%x)\n", err);
This error is not expected and may indicate a hardware issue, so it
seems to be more appropriate to log it as a warning or error rather than
using dbg.
Thanks,
Lukasz
On 1/9/2026 16:12, Michal Wajdeczko wrote:
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
>
> Michal Wajdeczko (5):
> drm/xe/mert: Normalize xe_mert.h include guards
> drm/xe/mert: Fix kernel-doc for struct xe_mert
> drm/xe/mert: Always refer to MERT using xe_device
> drm/xe/mert: Use local mert variable to simplify the code
> drm/xe/mert: Move MERT initialization to xe_mert.c
>
> drivers/gpu/drm/xe/xe_lmtt.c | 2 +-
> drivers/gpu/drm/xe/xe_mert.c | 32 +++++++++++++++++++++++---------
> drivers/gpu/drm/xe/xe_mert.h | 15 +++++++++------
> drivers/gpu/drm/xe/xe_sriov_pf.c | 4 +---
> 4 files changed, 34 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2026-01-09 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:12 [PATCH 0/5] drm/xe/mert: Minor improvements to MERT code Michal Wajdeczko
2026-01-09 15:12 ` [PATCH 1/5] drm/xe/mert: Normalize xe_mert.h include guards Michal Wajdeczko
2026-01-09 15:59 ` Laguna, Lukasz
2026-01-09 15:12 ` [PATCH 2/5] drm/xe/mert: Fix kernel-doc for struct xe_mert Michal Wajdeczko
2026-01-09 16:00 ` Laguna, Lukasz
2026-01-09 15:12 ` [PATCH 3/5] drm/xe/mert: Always refer to MERT using xe_device Michal Wajdeczko
2026-01-09 17:04 ` Laguna, Lukasz
2026-01-11 21:38 ` [PATCH v2 " Michal Wajdeczko
2026-01-09 15:12 ` [PATCH 4/5] drm/xe/mert: Use local mert variable to simplify the code Michal Wajdeczko
2026-01-09 16:21 ` Laguna, Lukasz
2026-01-09 15:12 ` [PATCH 5/5] drm/xe/mert: Move MERT initialization to xe_mert.c Michal Wajdeczko
2026-01-09 17:07 ` Laguna, Lukasz
2026-01-09 15:19 ` ✓ CI.KUnit: success for drm/xe/mert: Minor improvements to MERT code Patchwork
2026-01-09 16:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-09 16:49 ` Laguna, Lukasz [this message]
2026-01-09 20:02 ` ✓ Xe.CI.Full: " Patchwork
2026-01-11 21:50 ` ✓ CI.KUnit: success for drm/xe/mert: Minor improvements to MERT code (rev2) Patchwork
2026-01-11 22:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-11 23:18 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeafeb5b-d09b-4781-97a2-d5d797d65649@intel.com \
--to=lukasz.laguna@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox