Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe: Check skip_guc_pc before setting SLPC flag
@ 2024-01-05  0:33 Vinay Belgaumkar
  2024-01-05  0:36 ` ✓ CI.Patch_applied: success for drm/xe: Check skip_guc_pc before setting SLPC flag (rev3) Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Vinay Belgaumkar @ 2024-01-05  0:33 UTC (permalink / raw)
  To: intel-xe; +Cc: Lucas De Marchi

Don't set SLPC GuC feature ctl flag if skip_guc_pc is true.

v2: Skip the freq related sysfs creation as well (Badal)

Fixes: 975e4a3795d4 ("drm/xe: Manually setup C6 when skip_guc_pc is set")
Fixes: bef52b5c7a19 ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_freq.c | 3 +++
 drivers/gpu/drm/xe/xe_guc.c     | 7 ++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c
index 3adfa6686e7c..e5b0f4ecdbe8 100644
--- a/drivers/gpu/drm/xe/xe_gt_freq.c
+++ b/drivers/gpu/drm/xe/xe_gt_freq.c
@@ -196,6 +196,9 @@ void xe_gt_freq_init(struct xe_gt *gt)
 	struct xe_device *xe = gt_to_xe(gt);
 	int err;
 
+	if (xe->info.skip_guc_pc)
+		return;
+
 	gt->freq = kobject_create_and_add("freq0", gt->sysfs);
 	if (!gt->freq) {
 		drm_warn(&xe->drm, "failed to add freq0 directory to %s\n",
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 811e8b201270..0e112b144ec8 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -62,7 +62,12 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 
 static u32 guc_ctl_feature_flags(struct xe_guc *guc)
 {
-	return GUC_CTL_ENABLE_SLPC;
+	u32 flags = 0;
+
+	if (!(guc_to_xe(guc))->info.skip_guc_pc)
+		flags |= GUC_CTL_ENABLE_SLPC;
+
+	return flags;
 }
 
 static u32 guc_ctl_log_params_flags(struct xe_guc *guc)
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-01-08 18:19 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-05  0:33 [PATCH v2] drm/xe: Check skip_guc_pc before setting SLPC flag Vinay Belgaumkar
2024-01-05  0:36 ` ✓ CI.Patch_applied: success for drm/xe: Check skip_guc_pc before setting SLPC flag (rev3) Patchwork
2024-01-05  0:37 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-05  0:37 ` ✓ CI.KUnit: success " Patchwork
2024-01-05  0:45 ` ✓ CI.Build: " Patchwork
2024-01-05  0:46 ` ✓ CI.Hooks: " Patchwork
2024-01-05  0:47 ` ✓ CI.checksparse: " Patchwork
2024-01-05  1:22 ` ✓ CI.BAT: " Patchwork
2024-01-05  6:49 ` [PATCH v2] drm/xe: Check skip_guc_pc before setting SLPC flag Nilawar, Badal
2024-01-08 18:14 ` Lucas De Marchi
2024-01-08 18:18   ` Belgaumkar, Vinay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox