Re: [PATCH 01/10] drm/xe/gt: Add engine masks for each class

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 11/27/2025 2:45 AM, Daniele Ceraolo Spurio wrote:
> Follow up patches will need the engine masks for VCS and VECS engines.
> Since we already have a macro for the CCS engines, just extend the same
> approach to all classes.

but the problem is that this existing macro is already little confusing as we have:

	XE_HW_ENGINE_CCS_MASK
and
	CCS_MASK

where only former is a real engine mask, while latter is not masking anything

maybe we should rename the CCS_MASK to

	CCS_INSTANCES

and then extend that naming to

	RCS_INSTANCES
	VCS_INSTANCES
	...


> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt.h | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.h b/drivers/gpu/drm/xe/xe_gt.h
> index 9d710049da45..e70789dfac6e 100644
> --- a/drivers/gpu/drm/xe/xe_gt.h
> +++ b/drivers/gpu/drm/xe/xe_gt.h
> @@ -20,7 +20,14 @@
>  		for_each_if(((hwe__) = (gt__)->hw_engines + (id__)) && \
>  			  xe_hw_engine_is_valid((hwe__)))
>  
> -#define CCS_MASK(gt) (((gt)->info.engine_mask & XE_HW_ENGINE_CCS_MASK) >> XE_HW_ENGINE_CCS0)
> +#define __ENGINE_CLASS_MASK(gt, name) \
> +	(((gt)->info.engine_mask & XE_HW_ENGINE_##name##_MASK) >> XE_HW_ENGINE_##name##0)
> +
> +#define RCS_MASK(gt) __ENGINE_CLASS_MASK(gt, RCS)
> +#define VCS_MASK(gt) __ENGINE_CLASS_MASK(gt, VCS)
> +#define VECS_MASK(gt) __ENGINE_CLASS_MASK(gt, VECS)
> +#define CCS_MASK(gt) __ENGINE_CLASS_MASK(gt, CCS)
> +#define GSCCS_MASK(gt) __ENGINE_CLASS_MASK(gt, GSCCS)
>  
>  #define GT_VER(gt) ({ \
>  	typeof(gt) gt_ = (gt); \