Re: [PATCH v8 10/10] drm/i915/vrr: Enable cmrr

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 7/30/2026 4:29 PM, Mitul Golani wrote:
> Set crtc_state->vrr.cmrr.enable at the end of
> intel_vrr_cmrr_compute_config() so that CMRR is actually enabled once
> the M/N parameters have been computed. This is the final step that
> turns on CMRR, with all the parameter computation handled in the
> earlier patches.
> 
> --v2:
> - Everything else except enable compute to handle before this patch
> (Chaitanya)
> 
> --v3:
> - Remove redundant return from compute config
> 
> --v4:
> - Update CMRR commit message (Chaitanya)
> 

LGTM,

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 653581ed4e90..e36db1174440 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -269,6 +269,8 @@ intel_vrr_cmrr_compute_config(struct intel_crtc_state *crtc_state)
>   	adjusted_mode->crtc_vtotal = div64_u64_rem(dividend,
>   						   crtc_state->vrr.cmrr.cmrr_n,
>   						   &crtc_state->vrr.cmrr.cmrr_m);
> +
> +	crtc_state->vrr.cmrr.enable = true;
>   }
>   
>   static