Re: [PATCH] drm/xe: Fix static analysis tool reported errors

[Riana Tauro <riana.tauro@intel.com>]

Hi Karthik

On 3/25/2024 9:23 AM, Karthik Poosa wrote:
> Add a NULL pointer check.
> 
> v2: Release resources before returning error. (Riana)
> 
> v3: Change drm_err to XE_WARN_ON. (Anshuman)
> 
> Fixes: 09d88e3beb64 ("drm/xe/pm: Init pcode and restore vram on power lost")
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pm.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index cc650a92c2fc..bbb2ec25aee4 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -383,6 +383,12 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>   	 * really lost power. Detecting primary Gt power is sufficient.
>   	 */
>   	gt = xe_device_get_gt(xe, 0);
> +	if (!gt) {
> +		XE_WARN_ON(gt);
I don't think this is right. Shouldn't it be XE_WARN_ON(!gt).
Also i think the review comment was to add it in the if statement.

if (XE_WARN_ON(!gt)) {
	err= -ENXIO;
	goto out;
}

Thanks,
Riana
> +		err = -ENXIO;
> +		goto out;
> +	}
> +
>   	xe->d3cold.power_lost = xe_guc_in_reset(&gt->uc.guc);
>   
>   	if (xe->d3cold.allowed && xe->d3cold.power_lost) {