Re: [PATCH] drm/xe: Fix static analysis tool reported errors

["Poosa, Karthik" <karthik.poosa@intel.com>]

This check is not needed, already xe_device_get_gt internally checks gt 
for NULL.

On 25-03-2024 18:59, Nilawar, Badal wrote:
>
>
> On 25-03-2024 13:35, Karthik Poosa wrote:
>> Add a NULL pointer check.
>>
>> v2: Release resources before returning error. (Riana)
>>
>> v3: Update commit message. (Badal)
>>
>> v4: Change drm_err to XE_WARN_ON. (Anshuman)
>>
>> v5: Fix XE_WARN_ON check. (Riana)
>>
>> Fixes: 09d88e3beb64 ("drm/xe/pm: Init pcode and restore vram on power 
>> lost")
>> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_pm.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
>> index cc650a92c2fc..f6837bd6f9a3 100644
>> --- a/drivers/gpu/drm/xe/xe_pm.c
>> +++ b/drivers/gpu/drm/xe/xe_pm.c
>> @@ -383,6 +383,11 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>>        * really lost power. Detecting primary Gt power is sufficient.
>>        */
>>       gt = xe_device_get_gt(xe, 0);
>> +    if (XE_WARN_ON(!gt)) {
> Is this check really needed? xe_pm_ops will get installed when driver 
> probe is successful and driver probe successful means root tile 
> primary_gt exists.
>
> Regards,
> Badal
>> +        err = -ENXIO;
>> +        goto out;
>> +    }
>> +
>>       xe->d3cold.power_lost = xe_guc_in_reset(&gt->uc.guc);
>>         if (xe->d3cold.allowed && xe->d3cold.power_lost) {