Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing
@ 2024-12-03  3:37 Alan Previn
  2024-12-03  3:37 ` [PATCH v2 1/1] drm/xe/guc/capture: " Alan Previn
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Alan Previn @ 2024-12-03  3:37 UTC (permalink / raw)
  To: intel-xe
  Cc: Alan Previn, dri-devel, Daniele Ceraolo Spurio, John Harrison,
	Matthew Brost, Zhanjun Dong

The GuC-Error-Capture is currently reaching into xe_devcoredump
structure to store its own place-holder snaphot to workaround
the race between G2H-Error-Capture-Notification vs Drm-Scheduler
triggering GuC-Submission-exec-queue-timeout/kill.

Part of that race workaround design included GuC-Error-Capture taking
on some of the front-end functions for xe_hw_engine_snapshot
generation because of the orthogonal debugfs for raw dumps of engine
registers without any job association. We want this to also be handled,
even if indirectly, by GuC-Error-Capture since there is a lot to manage
when it comes to reading and printing the register lists.

However, logically speaking, GuC-Error-Capture node management,
despite being the majority of an engine-snapshot work, is still
a subset of xe_hw_engine_snapshot.

This series intends to re-design the plumbing for future
maintenence and scalability, rearranging the layering
back to what its should be (xe_devcoredump_snapshot owns
xe_hw_engine_snapshot owns xe_guc_capture_snapshot)..

Alan Previn (1):
  drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture
    plumbing

 drivers/gpu/drm/xe/xe_devcoredump.c           |   3 -
 drivers/gpu/drm/xe/xe_devcoredump_types.h     |   6 -
 drivers/gpu/drm/xe/xe_guc_capture.c           | 406 ++++++++----------
 drivers/gpu/drm/xe/xe_guc_capture.h           |  10 +-
 .../drm/xe/xe_guc_capture_snapshot_types.h    |  68 +++
 drivers/gpu/drm/xe/xe_guc_submit.c            |  21 +-
 drivers/gpu/drm/xe/xe_hw_engine.c             | 117 +++--
 drivers/gpu/drm/xe/xe_hw_engine.h             |   4 +-
 drivers/gpu/drm/xe/xe_hw_engine_types.h       |  13 +-
 9 files changed, 359 insertions(+), 289 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h

-- 
2.34.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-12-03 17:40 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03  3:37 [PATCH v2 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing Alan Previn
2024-12-03  3:37 ` [PATCH v2 1/1] drm/xe/guc/capture: " Alan Previn
2024-12-03  3:48 ` ✓ CI.Patch_applied: success for Maintenence of devcoredump <-> GuC-Err-Capture plumbing (rev2) Patchwork
2024-12-03  3:49 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-03  3:50 ` ✓ CI.KUnit: success " Patchwork
2024-12-03  4:08 ` ✓ CI.Build: " Patchwork
2024-12-03  4:10 ` ✓ CI.Hooks: " Patchwork
2024-12-03  4:12 ` ✓ CI.checksparse: " Patchwork
2024-12-03  4:42 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-03  5:57 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-03 17:40   ` Teres Alexis, Alan Previn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox