Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	<intel-gfx@lists.freedesktop.org>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915/vrr: s/intel_vrr_flipline_offset/intel_vrr_vmin_flipline_offset/
Date: Fri, 19 Sep 2025 16:19:36 +0530	[thread overview]
Message-ID: <42aa2eb8-5295-4e9b-a587-b30449b5321c@intel.com> (raw)
In-Reply-To: <20250918232226.25295-3-ville.syrjala@linux.intel.com>


On 9/19/2025 4:52 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Rename intel_vrr_flipline_offset() to intel_vrr_vmin_flipline_offset()
> to better reflect the fact that it gives us the minimum offset allowed
> between vmin and flipline.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index e725b4581e81..9e007aab1452 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -106,7 +106,7 @@ int intel_vrr_vblank_delay(const struct intel_crtc_state *crtc_state)
>   		intel_vrr_extra_vblank_delay(display);
>   }
>   
> -static int intel_vrr_flipline_offset(struct intel_display *display)
> +static int intel_vrr_vmin_flipline_offset(struct intel_display *display)
>   {
>   	/*
>   	 * ICL/TGL hardware imposes flipline>=vmin+1
> @@ -288,7 +288,7 @@ int intel_vrr_fixed_rr_hw_vmin(const struct intel_crtc_state *crtc_state)
>   	struct intel_display *display = to_intel_display(crtc_state);
>   
>   	return intel_vrr_fixed_rr_hw_vtotal(crtc_state) -
> -		intel_vrr_flipline_offset(display);
> +		intel_vrr_vmin_flipline_offset(display);
>   }
>   
>   static
> @@ -599,7 +599,7 @@ static int intel_vrr_hw_vmin(const struct intel_crtc_state *crtc_state)
>   	struct intel_display *display = to_intel_display(crtc_state);
>   
>   	return intel_vrr_hw_value(crtc_state, crtc_state->vrr.vmin) -
> -		intel_vrr_flipline_offset(display);
> +		intel_vrr_vmin_flipline_offset(display);
>   }
>   
>   static int intel_vrr_hw_vmax(const struct intel_crtc_state *crtc_state)
> @@ -765,7 +765,7 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
>   			crtc_state->vrr.vmax += intel_vrr_real_vblank_delay(crtc_state);
>   			crtc_state->vrr.vmin += intel_vrr_real_vblank_delay(crtc_state);
>   
> -			crtc_state->vrr.vmin += intel_vrr_flipline_offset(display);
> +			crtc_state->vrr.vmin += intel_vrr_vmin_flipline_offset(display);
>   		}
>   
>   		/*

  reply	other threads:[~2025-09-19 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 23:22 [PATCH 0/2] drm/i915/vrr: Hide even more ICL/TGL weirdness Ville Syrjala
2025-09-18 23:22 ` [PATCH 1/2] drm/i915/vrr: Hide the ICL/TGL intel_vrr_flipline_offset() mangling better Ville Syrjala
2025-09-19 10:49   ` Nautiyal, Ankit K
2025-09-18 23:22 ` [PATCH 2/2] drm/i915/vrr: s/intel_vrr_flipline_offset/intel_vrr_vmin_flipline_offset/ Ville Syrjala
2025-09-19 10:49   ` Nautiyal, Ankit K [this message]
2025-09-18 23:29 ` ✓ CI.KUnit: success for drm/i915/vrr: Hide even more ICL/TGL weirdness Patchwork
2025-09-19  0:03 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42aa2eb8-5295-4e9b-a587-b30449b5321c@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox