Re: [PATCH] drm/xe: select CONFIGFS_FS dependency

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 12/19/2025 5:32 PM, Matt Roper wrote:
> On Fri, Dec 19, 2025 at 11:04:06AM -0500, Rodrigo Vivi wrote:
>> On Fri, Dec 19, 2025 at 01:35:14PM +0530, Riana Tauro wrote:
>>> Xe driver uses configfs functions to expose configuration to userspace.
>>> If CONFIGFS_FS is built as module (=m) when Xe is built-in (=y),
>>> undefined reference errors occur.
>>
>> Perhaps we don't need  this middle phrase. Only the first and the last.
>> But anyway, we need the patch in. I just pushed it.
>>
>> Thanks,
>> Rodrigo.
>>
>>> Add select CONFIGFS_FS to ensure configfs is built at minimum required
>>> level.
> 
> If we make this change, shouldn't we also remove all of the #ifdef logic
> we have to support running without configfs?

but is it a good idea to always back select CONFIGFS ?
maybe the actual fix should be like this:

-xe-$(CONFIG_CONFIGFS_FS) += xe_configfs.o
+
+ifdef CONFIG_CONFIGFS_FS
+       xe-y += xe_configfs.o
+endif


> 
> 
> Matt
> 
>>>
>>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202512190827.IeXYj4qg-lkp@intel.com/
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202512181854.hPyTAXc5-lkp@intel.com/
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202512190407.CcUFXX2F-lkp@intel.com/
>>> Fixes: 16280ded45fb ("drm/xe: Add configfs to enable survivability mode")
>>> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
>>> ---
>>>  drivers/gpu/drm/xe/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>>> index 4b288eb3f5b0..1094c5fc5bdf 100644
>>> --- a/drivers/gpu/drm/xe/Kconfig
>>> +++ b/drivers/gpu/drm/xe/Kconfig
>>> @@ -46,6 +46,7 @@ config DRM_XE
>>>  	select WANT_DEV_COREDUMP
>>>  	select AUXILIARY_BUS
>>>  	select REGMAP if I2C
>>> +	select CONFIGFS_FS
>>>  	help
>>>  	  Driver for Intel Xe2 series GPUs and later. Experimental support
>>>  	  for Xe series is also available.
>>> -- 
>>> 2.47.1
>>>
>