public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Kumar G, Naresh" <naresh.kumar.g@intel.com>
Cc: "Upadhyay, Tejas" <tejas.upadhyay@intel.com>,
	"Shah, Ankur N" <ankur.n.shah@intel.com>,
	"Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>,
	"Mrozek, Michal" <michal.mrozek@intel.com>
Subject: Re: [PATCH 1/1] drm/xe: Set GT rp min frequency as 1.2GHz default for BMG/CRI
Date: Wed, 18 Feb 2026 09:04:37 +0000	[thread overview]
Message-ID: <4603e26486bdeeafac19dc8a4d0c64aa3fa988bb.camel@intel.com> (raw)
In-Reply-To: <20260216135107.3148167-4-naresh.kumar.g@intel.com>

On Mon, 2026-02-16 at 19:21 +0530, Nareshkumar Gollakoti wrote:
>  While previously applied only to the BMG G21(Battle image) platform
>  via workaround Wa_14022085890,this 1.2 GHz minimum is now the
> default
>  for BMG and CRI platforms.
> 
>  Setting this frequency floor(1.2GHz) default is critical in multi
> GPU
>  environment for supporting effective Peer-to-Peer(P2P) transactions.
> 
> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_pc.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c
> b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 5e5495a39a3c..881054c9cf92 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -860,6 +860,7 @@ static int pc_adjust_freq_bounds(struct xe_guc_pc
> *pc)
>  {
>  	struct xe_tile *tile = gt_to_tile(pc_to_gt(pc));
>  	int ret;
> +	struct xe_device *xe = pc_to_xe(pc);
>  
>  	lockdep_assert_held(&pc->freq_lock);
>  
> @@ -885,7 +886,13 @@ static int pc_adjust_freq_bounds(struct
> xe_guc_pc *pc)
>  	if (pc_get_min_freq(pc) > pc->rp0_freq)
>  		ret = pc_set_min_freq(pc, pc->rp0_freq);
>  
> -	if (XE_DEVICE_WA(tile_to_xe(tile), 14022085890))
> +	/*
> +	 * Setting GT RP min frequency to 1.2GHz by default for
> +	 * all BMG and CRI(For BMG G21 WA do the same).
> +	 */
> +	if (XE_DEVICE_WA(tile_to_xe(tile), 14022085890) ||
> +	    (xe->info.platform == XE_BATTLEMAGE ||
> +			 xe->info.platform == XE_CRESCENTISLAND))
>  		ret = pc_set_min_freq(pc, max(BMG_MIN_FREQ,
> pc_get_min_freq(pc)));

Copying the reply given to the cover letter for completeness:

Wasn't the idea to do this only for the Arc PRO BMGs (server SKUs)?
Perhaps the compute team would want to chime in here for the scope of
this workaround.

Thanks,
Thomas





>  
>  out:

  reply	other threads:[~2026-02-18  9:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 13:51 [PATCH 0/1] drm/xe: Set GT rp min frequency as 1.2GHz default for BMG/CRI Nareshkumar Gollakoti
2026-02-16 13:51 ` [PATCH 1/1] " Nareshkumar Gollakoti
2026-02-18  9:04   ` Hellstrom, Thomas [this message]
2026-02-20  9:06     ` Mrozek, Michal
2026-02-26  8:50     ` Kumar G, Naresh
2026-02-26 12:03   ` Hellstrom, Thomas
2026-02-26 22:36   ` Belgaumkar, Vinay
2026-02-26 23:37   ` Summers, Stuart
2026-02-27  0:30     ` Matt Roper
2026-03-03 13:41       ` Kumar G, Naresh
2026-02-16 14:17 ` [PATCH 0/1] " Hellstrom, Thomas
2026-02-16 14:40   ` Thomas Hellström
2026-02-16 15:17 ` ✓ CI.KUnit: success for " Patchwork
2026-02-16 16:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-16 20:48 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4603e26486bdeeafac19dc8a4d0c64aa3fa988bb.camel@intel.com \
    --to=thomas.hellstrom@intel.com \
    --cc=ankur.n.shah@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.mrozek@intel.com \
    --cc=naresh.kumar.g@intel.com \
    --cc=tejas.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox