Re: [PATCH 1/1] drm/xe: Set GT rp min frequency as 1.2GHz default for BMG/CRI

["Summers, Stuart" <stuart.summers@intel.com>]

On Mon, 2026-02-16 at 19:21 +0530, Nareshkumar Gollakoti wrote:
>  While previously applied only to the BMG G21(Battle image) platform
>  via workaround Wa_14022085890,this 1.2 GHz minimum is now the

nit: space after comma

> default
>  for BMG and CRI platforms.
> 
>  Setting this frequency floor(1.2GHz) default is critical in multi
> GPU
>  environment for supporting effective Peer-to-Peer(P2P) transactions.
> 
> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_pc.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c
> b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 5e5495a39a3c..881054c9cf92 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -860,6 +860,7 @@ static int pc_adjust_freq_bounds(struct xe_guc_pc
> *pc)
>  {
>         struct xe_tile *tile = gt_to_tile(pc_to_gt(pc));
>         int ret;
> +       struct xe_device *xe = pc_to_xe(pc);
>  
>         lockdep_assert_held(&pc->freq_lock);
>  
> @@ -885,7 +886,13 @@ static int pc_adjust_freq_bounds(struct
> xe_guc_pc *pc)
>         if (pc_get_min_freq(pc) > pc->rp0_freq)
>                 ret = pc_set_min_freq(pc, pc->rp0_freq);
>  
> -       if (XE_DEVICE_WA(tile_to_xe(tile), 14022085890))
> +       /*
> +        * Setting GT RP min frequency to 1.2GHz by default for
> +        * all BMG and CRI(For BMG G21 WA do the same).

Should we add a comment here that this is the active frequency, so if
the device is idle we aren't expecting high power output across the
board with this?

> +        */
> +       if (XE_DEVICE_WA(tile_to_xe(tile), 14022085890) ||
> +           (xe->info.platform == XE_BATTLEMAGE ||
> +                        xe->info.platform == XE_CRESCENTISLAND))

Thomas already mentioned the indentation. Would be nice to get an ack
also from Vinay (cc'd) on this one.

Otherwise:
Reviewed-by: Stuart Summers <stuart.summers@intel.com>

Thanks,
Stuart

>                 ret = pc_set_min_freq(pc, max(BMG_MIN_FREQ,
> pc_get_min_freq(pc)));
>  
>  out: