REGRESSION on drm-tip

REGRESSION on drm-tip

[Borah, Chaitanya Kumar]

Hello Christian,

This is Chaitanya (again!).

This mail is regarding another regression we are seeing in our CI 
runs[1] on drm-tip (with both xe and i915).

`````````````````````````````````````````````````````````````````````````````````
<4> [157.687644] ------------[ cut here ]------------
<4> [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139 
__set_task_frozen+0x7f/0xb0
...
<4> [157.687923] PKRU: 55555554
<4> [157.687924] Call Trace:
<4> [157.687925]  <TASK>
<4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10
<4> [157.687929]  task_call_func+0x6d/0x120
<4> [157.687932]  ? cgroup_freezing+0x89/0x200
<4> [157.687937]  freeze_task+0x98/0x100
<4> [157.687940]  try_to_freeze_tasks+0xd2/0x440
<4> [157.687946]  freeze_processes+0x56/0xd0
<4> [157.687948]  hibernate+0x129/0x4a0
<4> [157.687951]  state_store+0xd3/0xe0
<4> [157.687954]  kobj_attr_store+0x12/0x40
<4> [157.687959]  sysfs_kf_write+0x4d/0x80
<4> [157.687963]  kernfs_fop_write_iter+0x188/0x240
<4> [157.687967]  vfs_write+0x283/0x540
<4> [157.687969]  ? free_to_partial_list+0x46d/0x640
<4> [157.687976]  ksys_write+0x6f/0xf0
<4> [157.687980]  __x64_sys_write+0x19/0x30
<4> [157.687982]  x64_sys_call+0x79/0x26a0
<4> [157.687984]  do_syscall_64+0x93/0xd60
<4> [157.687987]  ? putname+0x65/0x90
<4> [157.687990]  ? kmem_cache_free+0x553/0x680
<4> [157.687995]  ? putname+0x65/0x90
<4> [157.687997]  ? putname+0x65/0x90
<4> [157.687999]  ? do_sys_openat2+0x8b/0xd0
<4> [157.688003]  ? __x64_sys_openat+0x54/0xa0
<4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
<4> [157.688009]  ? __fput+0x1bf/0x2f0
<4> [157.688012]  ? fput_close_sync+0x3d/0xa0
<4> [157.688015]  ? __x64_sys_close+0x3e/0x90
<4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
<4> [157.688019]  ? putname+0x65/0x90
<4> [157.688021]  ? putname+0x65/0x90
<4> [157.688023]  ? do_sys_openat2+0x8b/0xd0
<4> [157.688024]  ? __fput+0x1bf/0x2f0
<4> [157.688028]  ? __x64_sys_openat+0x54/0xa0
<4> [157.688032]  ? do_syscall_64+0x1b7/0xd60
<4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
<4> [157.688036]  ? irqentry_exit+0x77/0xb0
<4> [157.688038]  ? exc_page_fault+0xbd/0x2c0
<4> [157.688042]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
<4> [157.688044] RIP: 0033:0x72523c91c574
`````````````````````````````````````````````````````````````````````````````````
Details log can be found in [2].

After bisecting the tree, the following patch [3] seems to be the first 
"bad" commit

`````````````````````````````````````````````````````````````````````````````````````````````````````````
commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
Author: Christian Brauner <brauner@kernel.org>
Date:   Wed Nov 5 14:39:45 2025 +0100

     power: always freeze efivarfs
`````````````````````````````````````````````````````````````````````````````````````````````````````````

We also verified that if we revert the patch the issue is not seen.

Could you please check why the patch causes this regression and provide 
a fix if necessary?

Thank you.

Regards

Chaitanya

[1]
https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend
[2]
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17595/shard-mtlp-6/igt@gem_exec_suspend@basic-s4-devices.html
[3] 
https://gitlab.com/freedesktop-mirror/drm-tip/-/commit/a3f8f8662771285511ae26c4c8d3ba1cd22159b9

RE: REGRESSION on drm-tip

[Saarinen, Jani]

Hi, 

> -----Original Message-----
> From: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
> Sent: Thursday, 27 November 2025 8.26
> To: brauner@kernel.org
> Cc: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Saarinen, Jani
> <jani.saarinen@intel.com>; Kurmi, Suresh Kumar
> <suresh.kumar.kurmi@intel.com>; De Marchi, Lucas
> <lucas.demarchi@intel.com>
> Subject: REGRESSION on drm-tip
> 
> Hello Christian,
> 
> This is Chaitanya (again!).
> 
> This mail is regarding another regression we are seeing in our CI runs[1] on drm-
> tip (with both xe and i915).
> 
> `````````````````````````````````````````````````````````````````````````````````
> <4> [157.687644] ------------[ cut here ]------------ <4> [157.687768] WARNING:
> CPU: 5 PID: 2277 at kernel/freezer.c:139
> __set_task_frozen+0x7f/0xb0
> ...
> <4> [157.687923] PKRU: 55555554
> <4> [157.687924] Call Trace:
> <4> [157.687925]  <TASK>
> <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10 <4> [157.687929]
> task_call_func+0x6d/0x120 <4> [157.687932]  ? cgroup_freezing+0x89/0x200
> <4> [157.687937]  freeze_task+0x98/0x100 <4> [157.687940]
> try_to_freeze_tasks+0xd2/0x440 <4> [157.687946]
> freeze_processes+0x56/0xd0 <4> [157.687948]  hibernate+0x129/0x4a0 <4>
> [157.687951]  state_store+0xd3/0xe0 <4> [157.687954]
> kobj_attr_store+0x12/0x40 <4> [157.687959]  sysfs_kf_write+0x4d/0x80 <4>
> [157.687963]  kernfs_fop_write_iter+0x188/0x240 <4> [157.687967]
> vfs_write+0x283/0x540 <4> [157.687969]  ? free_to_partial_list+0x46d/0x640
> <4> [157.687976]  ksys_write+0x6f/0xf0 <4> [157.687980]
> __x64_sys_write+0x19/0x30 <4> [157.687982]  x64_sys_call+0x79/0x26a0 <4>
> [157.687984]  do_syscall_64+0x93/0xd60 <4> [157.687987]  ?
> putname+0x65/0x90 <4> [157.687990]  ? kmem_cache_free+0x553/0x680 <4>
> [157.687995]  ? putname+0x65/0x90 <4> [157.687997]  ? putname+0x65/0x90
> <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0 <4> [157.688003]  ?
> __x64_sys_openat+0x54/0xa0 <4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688009]  ? __fput+0x1bf/0x2f0 <4> [157.688012]  ?
> fput_close_sync+0x3d/0xa0 <4> [157.688015]  ? __x64_sys_close+0x3e/0x90
> <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60 <4> [157.688019]  ?
> putname+0x65/0x90 <4> [157.688021]  ? putname+0x65/0x90 <4> [157.688023]
> ? do_sys_openat2+0x8b/0xd0 <4> [157.688024]  ? __fput+0x1bf/0x2f0 <4>
> [157.688028]  ? __x64_sys_openat+0x54/0xa0 <4> [157.688032]  ?
> do_syscall_64+0x1b7/0xd60 <4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688036]  ? irqentry_exit+0x77/0xb0 <4> [157.688038]  ?
> exc_page_fault+0xbd/0x2c0 <4> [157.688042]
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> <4> [157.688044] RIP: 0033:0x72523c91c574
> `````````````````````````````````````````````````````````````````````````````````
> Details log can be found in [2].
> 
> After bisecting the tree, the following patch [3] seems to be the first "bad" commit
> 
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> Author: Christian Brauner <brauner@kernel.org>
> Date:   Wed Nov 5 14:39:45 2025 +0100
> 
>      power: always freeze efivarfs
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> 
> We also verified that if we revert the patch the issue is not seen.

Yes, revert works as you see from https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_158163v2/index.html?testfilter=suspend 
For any fix, post it to intel-gfx and xe and you should get results (if BAT passes) 
> 
> Could you please check why the patch causes this regression and provide a fix if necessary?
> 
> Thank you.
> 
> Regards
> 
> Chaitanya
> 
> [1] https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend
> [2] https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17595/shard-mtlp-6/igt@gem_exec_suspend@basic-s4-devices.html
> [3] https://gitlab.com/freedesktop-mirror/drm-tip/-> /commit/a3f8f8662771285511ae26c4c8d3ba1cd22159b9

RE: REGRESSION on drm-tip

[Saarinen, Jani]

Hi, 
Add addition below. 

> -----Original Message-----
> From: Saarinen, Jani
> Sent: Thursday, 27 November 2025 18.02
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>;
> brauner@kernel.org
> Cc: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Kurmi, Suresh
> Kumar <Suresh.Kumar.Kurmi@intel.com>; De Marchi, Lucas
> <lucas.demarchi@intel.com>
> Subject: RE: REGRESSION on drm-tip
> 
> Hi,
> 
> > -----Original Message-----
> > From: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
> > Sent: Thursday, 27 November 2025 8.26
> > To: brauner@kernel.org
> > Cc: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org;
> > Saarinen, Jani <jani.saarinen@intel.com>; Kurmi, Suresh Kumar
> > <suresh.kumar.kurmi@intel.com>; De Marchi, Lucas
> > <lucas.demarchi@intel.com>
> > Subject: REGRESSION on drm-tip
> >
> > Hello Christian,
> >
> > This is Chaitanya (again!).
> >
> > This mail is regarding another regression we are seeing in our CI
> > runs[1] on drm- tip (with both xe and i915).
> >
> > ``````````````````````````````````````````````````````````````````````
> > ``````````` <4> [157.687644] ------------[ cut here ]------------ <4>
> > [157.687768] WARNING:
> > CPU: 5 PID: 2277 at kernel/freezer.c:139
> > __set_task_frozen+0x7f/0xb0
> > ...
> > <4> [157.687923] PKRU: 55555554
> > <4> [157.687924] Call Trace:
> > <4> [157.687925]  <TASK>
> > <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10 <4> [157.687929]
> > task_call_func+0x6d/0x120 <4> [157.687932]  ?
> > cgroup_freezing+0x89/0x200 <4> [157.687937]  freeze_task+0x98/0x100
> > <4> [157.687940]
> > try_to_freeze_tasks+0xd2/0x440 <4> [157.687946]
> > freeze_processes+0x56/0xd0 <4> [157.687948]  hibernate+0x129/0x4a0 <4>
> > [157.687951]  state_store+0xd3/0xe0 <4> [157.687954]
> > kobj_attr_store+0x12/0x40 <4> [157.687959]  sysfs_kf_write+0x4d/0x80
> > <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240 <4> [157.687967]
> > vfs_write+0x283/0x540 <4> [157.687969]  ?
> > free_to_partial_list+0x46d/0x640 <4> [157.687976]
> > ksys_write+0x6f/0xf0 <4> [157.687980]
> > __x64_sys_write+0x19/0x30 <4> [157.687982]  x64_sys_call+0x79/0x26a0
> > <4> [157.687984]  do_syscall_64+0x93/0xd60 <4> [157.687987]  ?
> > putname+0x65/0x90 <4> [157.687990]  ? kmem_cache_free+0x553/0x680 <4>
> > [157.687995]  ? putname+0x65/0x90 <4> [157.687997]  ?
> > putname+0x65/0x90 <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0 <4>
> [157.688003]  ?
> > __x64_sys_openat+0x54/0xa0 <4> [157.688007]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688009]  ? __fput+0x1bf/0x2f0 <4>
> [157.688012]  ?
> > fput_close_sync+0x3d/0xa0 <4> [157.688015]  ?
> > __x64_sys_close+0x3e/0x90 <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688019]  ?
> > putname+0x65/0x90 <4> [157.688021]  ? putname+0x65/0x90 <4>
> > putname+[157.688023]
> > ? do_sys_openat2+0x8b/0xd0 <4> [157.688024]  ? __fput+0x1bf/0x2f0 <4>
> > [157.688028]  ? __x64_sys_openat+0x54/0xa0 <4> [157.688032]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688034]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688036]  ? irqentry_exit+0x77/0xb0 <4>
> [157.688038]  ?
> > exc_page_fault+0xbd/0x2c0 <4> [157.688042]
> > entry_SYSCALL_64_after_hwframe+0x76/0x7e
> > <4> [157.688044] RIP: 0033:0x72523c91c574
> > ``````````````````````````````````````````````````````````````````````
> > ```````````
> > Details log can be found in [2].
> >
> > After bisecting the tree, the following patch [3] seems to be the
> > first "bad" commit
> >
> > ``````````````````````````````````````````````````````````````````````
> > ```````````````````````````````````
> > commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> > Author: Christian Brauner <brauner@kernel.org>
> > Date:   Wed Nov 5 14:39:45 2025 +0100
> >
> >      power: always freeze efivarfs
> > ``````````````````````````````````````````````````````````````````````
> > ```````````````````````````````````
> >
> > We also verified that if we revert the patch the issue is not seen.
> 
> Yes, revert works as you see from https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_158163v2/index.html?testfilter=suspend
Missed, same for Xe https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-158162v1/index.html?testfilter=suspend 

Br,
Jani

> For any fix, post it to intel-gfx and xe and you should get results (if BAT passes)
> >
> > Could you please check why the patch causes this regression and provide a fix if
> necessary?
> >
> > Thank you.
> >
> > Regards
> >
> > Chaitanya
> >
> > [1]
> > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend
> > [2]
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17595/shard-mtlp-6/igt
> > @gem_exec_suspend@basic-s4-devices.html
> > [3] https://gitlab.com/freedesktop-mirror/drm-tip/->
> > /commit/a3f8f8662771285511ae26c4c8d3ba1cd22159b9

Re: REGRESSION on drm-tip

[Ville Syrjälä]

On Thu, Nov 27, 2025 at 11:55:54AM +0530, Borah, Chaitanya Kumar wrote:
> Hello Christian,
> 
> This is Chaitanya (again!).
> 
> This mail is regarding another regression we are seeing in our CI 
> runs[1] on drm-tip (with both xe and i915).
> 
> `````````````````````````````````````````````````````````````````````````````````
> <4> [157.687644] ------------[ cut here ]------------
> <4> [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139 
> __set_task_frozen+0x7f/0xb0
> ...
> <4> [157.687923] PKRU: 55555554
> <4> [157.687924] Call Trace:
> <4> [157.687925]  <TASK>
> <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10
> <4> [157.687929]  task_call_func+0x6d/0x120
> <4> [157.687932]  ? cgroup_freezing+0x89/0x200
> <4> [157.687937]  freeze_task+0x98/0x100
> <4> [157.687940]  try_to_freeze_tasks+0xd2/0x440
> <4> [157.687946]  freeze_processes+0x56/0xd0
> <4> [157.687948]  hibernate+0x129/0x4a0
> <4> [157.687951]  state_store+0xd3/0xe0
> <4> [157.687954]  kobj_attr_store+0x12/0x40
> <4> [157.687959]  sysfs_kf_write+0x4d/0x80
> <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240
> <4> [157.687967]  vfs_write+0x283/0x540
> <4> [157.687969]  ? free_to_partial_list+0x46d/0x640
> <4> [157.687976]  ksys_write+0x6f/0xf0
> <4> [157.687980]  __x64_sys_write+0x19/0x30
> <4> [157.687982]  x64_sys_call+0x79/0x26a0
> <4> [157.687984]  do_syscall_64+0x93/0xd60
> <4> [157.687987]  ? putname+0x65/0x90
> <4> [157.687990]  ? kmem_cache_free+0x553/0x680
> <4> [157.687995]  ? putname+0x65/0x90
> <4> [157.687997]  ? putname+0x65/0x90
> <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688003]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688009]  ? __fput+0x1bf/0x2f0
> <4> [157.688012]  ? fput_close_sync+0x3d/0xa0
> <4> [157.688015]  ? __x64_sys_close+0x3e/0x90
> <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688019]  ? putname+0x65/0x90
> <4> [157.688021]  ? putname+0x65/0x90
> <4> [157.688023]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688024]  ? __fput+0x1bf/0x2f0
> <4> [157.688028]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688032]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688036]  ? irqentry_exit+0x77/0xb0
> <4> [157.688038]  ? exc_page_fault+0xbd/0x2c0
> <4> [157.688042]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> <4> [157.688044] RIP: 0033:0x72523c91c574
> `````````````````````````````````````````````````````````````````````````````````
> Details log can be found in [2].
> 
> After bisecting the tree, the following patch [3] seems to be the first 
> "bad" commit
> 
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> Author: Christian Brauner <brauner@kernel.org>
> Date:   Wed Nov 5 14:39:45 2025 +0100
> 
>      power: always freeze efivarfs

-       if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
+	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))

?

-- 
Ville Syrjälä
Intel

Re: REGRESSION on drm-tip

[Borah, Chaitanya Kumar]

On 11/28/2025 4:34 AM, Ville Syrjälä wrote:
>> `````````````````````````````````````````````````````````````````````````````````````````````````````````
>> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
>> Author: Christian Brauner<brauner@kernel.org>
>> Date:   Wed Nov 5 14:39:45 2025 +0100
>>
>>       power: always freeze efivarfs
> -       if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> +	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> 
> ?

This change helps.
@Christian do you plan to send out a fix for it?

Thank you Ville for pointing it out.

Regards
Chaitanya

RE: REGRESSION on drm-tip

[Saarinen, Jani]

> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Friday, 28 November 2025 1.04
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
> Cc: brauner@kernel.org; intel-gfx@lists.freedesktop.org; intel-
> xe@lists.freedesktop.org; Saarinen, Jani <jani.saarinen@intel.com>; Kurmi,
> Suresh Kumar <suresh.kumar.kurmi@intel.com>; De Marchi, Lucas
> <lucas.demarchi@intel.com>
> Subject: Re: REGRESSION on drm-tip
> 
> On Thu, Nov 27, 2025 at 11:55:54AM +0530, Borah, Chaitanya Kumar wrote:
> > Hello Christian,
> >
> > This is Chaitanya (again!).
> >
> > This mail is regarding another regression we are seeing in our CI
> > runs[1] on drm-tip (with both xe and i915).
> >
> > ``````````````````````````````````````````````````````````````````````
> > ``````````` <4> [157.687644] ------------[ cut here ]------------ <4>
> > [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139
> > __set_task_frozen+0x7f/0xb0
> > ...
> > <4> [157.687923] PKRU: 55555554
> > <4> [157.687924] Call Trace:
> > <4> [157.687925]  <TASK>
> > <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10 <4> [157.687929]
> > task_call_func+0x6d/0x120 <4> [157.687932]  ?
> > cgroup_freezing+0x89/0x200 <4> [157.687937]  freeze_task+0x98/0x100
> > <4> [157.687940]  try_to_freeze_tasks+0xd2/0x440 <4> [157.687946]
> > freeze_processes+0x56/0xd0 <4> [157.687948]  hibernate+0x129/0x4a0 <4>
> > [157.687951]  state_store+0xd3/0xe0 <4> [157.687954]
> > kobj_attr_store+0x12/0x40 <4> [157.687959]  sysfs_kf_write+0x4d/0x80
> > <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240 <4> [157.687967]
> > vfs_write+0x283/0x540 <4> [157.687969]  ?
> > free_to_partial_list+0x46d/0x640 <4> [157.687976]
> > ksys_write+0x6f/0xf0 <4> [157.687980]  __x64_sys_write+0x19/0x30 <4>
> > [157.687982]  x64_sys_call+0x79/0x26a0 <4> [157.687984]
> > do_syscall_64+0x93/0xd60 <4> [157.687987]  ? putname+0x65/0x90 <4>
> > [157.687990]  ? kmem_cache_free+0x553/0x680 <4> [157.687995]  ?
> > putname+0x65/0x90 <4> [157.687997]  ? putname+0x65/0x90 <4>
> > [157.687999]  ? do_sys_openat2+0x8b/0xd0 <4> [157.688003]  ?
> > __x64_sys_openat+0x54/0xa0 <4> [157.688007]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688009]  ? __fput+0x1bf/0x2f0 <4>
> > [157.688012]  ? fput_close_sync+0x3d/0xa0 <4> [157.688015]  ?
> > __x64_sys_close+0x3e/0x90 <4> [157.688017]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688019]  ? putname+0x65/0x90 <4>
> > [157.688021]  ? putname+0x65/0x90 <4> [157.688023]  ?
> > do_sys_openat2+0x8b/0xd0 <4> [157.688024]  ? __fput+0x1bf/0x2f0 <4>
> > [157.688028]  ? __x64_sys_openat+0x54/0xa0 <4> [157.688032]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688034]  ?
> > do_syscall_64+0x1b7/0xd60 <4> [157.688036]  ? irqentry_exit+0x77/0xb0
> > <4> [157.688038]  ? exc_page_fault+0xbd/0x2c0 <4> [157.688042]
> > entry_SYSCALL_64_after_hwframe+0x76/0x7e
> > <4> [157.688044] RIP: 0033:0x72523c91c574
> > ``````````````````````````````````````````````````````````````````````
> > ```````````
> > Details log can be found in [2].
> >
> > After bisecting the tree, the following patch [3] seems to be the
> > first "bad" commit
> >
> > ``````````````````````````````````````````````````````````````````````
> > ```````````````````````````````````
> > commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> > Author: Christian Brauner <brauner@kernel.org>
> > Date:   Wed Nov 5 14:39:45 2025 +0100
> >
> >      power: always freeze efivarfs
> 
> -       if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> +	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> 
> ?
> 
Should we go with fix or revert? We should decide as still badly broken. 
Still only i915 view: https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend 

> --
> Ville Syrjälä
> Intel

Re: BISECTED REGRESSION on v6.18 (was: REGRESSION on drm-tip)

[Jani Nikula]

On Thu, 27 Nov 2025, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
> Hello Christian,
>
> This is Chaitanya (again!).
>
> This mail is regarding another regression we are seeing in our CI 
> runs[1] on drm-tip (with both xe and i915).

Referring to drm-tip is downplaying the problem. The bisected regression
is in v6.18 release. It's breaking suspend/resume across a lot of
platforms on two drivers, i915 and xe.

a3f8f8662771 ("power: always freeze efivarfs")

As far as regressions go, it's pretty bad. Please prioritize.


BR,
Jani.



>
> `````````````````````````````````````````````````````````````````````````````````
> <4> [157.687644] ------------[ cut here ]------------
> <4> [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139 
> __set_task_frozen+0x7f/0xb0
> ...
> <4> [157.687923] PKRU: 55555554
> <4> [157.687924] Call Trace:
> <4> [157.687925]  <TASK>
> <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10
> <4> [157.687929]  task_call_func+0x6d/0x120
> <4> [157.687932]  ? cgroup_freezing+0x89/0x200
> <4> [157.687937]  freeze_task+0x98/0x100
> <4> [157.687940]  try_to_freeze_tasks+0xd2/0x440
> <4> [157.687946]  freeze_processes+0x56/0xd0
> <4> [157.687948]  hibernate+0x129/0x4a0
> <4> [157.687951]  state_store+0xd3/0xe0
> <4> [157.687954]  kobj_attr_store+0x12/0x40
> <4> [157.687959]  sysfs_kf_write+0x4d/0x80
> <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240
> <4> [157.687967]  vfs_write+0x283/0x540
> <4> [157.687969]  ? free_to_partial_list+0x46d/0x640
> <4> [157.687976]  ksys_write+0x6f/0xf0
> <4> [157.687980]  __x64_sys_write+0x19/0x30
> <4> [157.687982]  x64_sys_call+0x79/0x26a0
> <4> [157.687984]  do_syscall_64+0x93/0xd60
> <4> [157.687987]  ? putname+0x65/0x90
> <4> [157.687990]  ? kmem_cache_free+0x553/0x680
> <4> [157.687995]  ? putname+0x65/0x90
> <4> [157.687997]  ? putname+0x65/0x90
> <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688003]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688009]  ? __fput+0x1bf/0x2f0
> <4> [157.688012]  ? fput_close_sync+0x3d/0xa0
> <4> [157.688015]  ? __x64_sys_close+0x3e/0x90
> <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688019]  ? putname+0x65/0x90
> <4> [157.688021]  ? putname+0x65/0x90
> <4> [157.688023]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688024]  ? __fput+0x1bf/0x2f0
> <4> [157.688028]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688032]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688036]  ? irqentry_exit+0x77/0xb0
> <4> [157.688038]  ? exc_page_fault+0xbd/0x2c0
> <4> [157.688042]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> <4> [157.688044] RIP: 0033:0x72523c91c574
> `````````````````````````````````````````````````````````````````````````````````
> Details log can be found in [2].
>
> After bisecting the tree, the following patch [3] seems to be the first 
> "bad" commit
>
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> Author: Christian Brauner <brauner@kernel.org>
> Date:   Wed Nov 5 14:39:45 2025 +0100
>
>      power: always freeze efivarfs
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
>
> We also verified that if we revert the patch the issue is not seen.
>
> Could you please check why the patch causes this regression and provide 
> a fix if necessary?
>
> Thank you.
>
> Regards
>
> Chaitanya
>
> [1]
> https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend
> [2]
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17595/shard-mtlp-6/igt@gem_exec_suspend@basic-s4-devices.html
> [3] 
> https://gitlab.com/freedesktop-mirror/drm-tip/-/commit/a3f8f8662771285511ae26c4c8d3ba1cd22159b9

-- 
Jani Nikula, Intel

Re: BISECTED REGRESSION on v6.18 (was: REGRESSION on drm-tip)

[Jani Nikula]

On Wed, 03 Dec 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 27 Nov 2025, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> Hello Christian,
>>
>> This is Chaitanya (again!).
>>
>> This mail is regarding another regression we are seeing in our CI 
>> runs[1] on drm-tip (with both xe and i915).
>
> Referring to drm-tip is downplaying the problem. The bisected regression
> is in v6.18 release. It's breaking suspend/resume across a lot of
> platforms on two drivers, i915 and xe.
>
> a3f8f8662771 ("power: always freeze efivarfs")
>
> As far as regressions go, it's pretty bad. Please prioritize.

Added some missing Cc's.

>
>
> BR,
> Jani.
>
>
>
>>
>> `````````````````````````````````````````````````````````````````````````````````
>> <4> [157.687644] ------------[ cut here ]------------
>> <4> [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139 
>> __set_task_frozen+0x7f/0xb0
>> ...
>> <4> [157.687923] PKRU: 55555554
>> <4> [157.687924] Call Trace:
>> <4> [157.687925]  <TASK>
>> <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10
>> <4> [157.687929]  task_call_func+0x6d/0x120
>> <4> [157.687932]  ? cgroup_freezing+0x89/0x200
>> <4> [157.687937]  freeze_task+0x98/0x100
>> <4> [157.687940]  try_to_freeze_tasks+0xd2/0x440
>> <4> [157.687946]  freeze_processes+0x56/0xd0
>> <4> [157.687948]  hibernate+0x129/0x4a0
>> <4> [157.687951]  state_store+0xd3/0xe0
>> <4> [157.687954]  kobj_attr_store+0x12/0x40
>> <4> [157.687959]  sysfs_kf_write+0x4d/0x80
>> <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240
>> <4> [157.687967]  vfs_write+0x283/0x540
>> <4> [157.687969]  ? free_to_partial_list+0x46d/0x640
>> <4> [157.687976]  ksys_write+0x6f/0xf0
>> <4> [157.687980]  __x64_sys_write+0x19/0x30
>> <4> [157.687982]  x64_sys_call+0x79/0x26a0
>> <4> [157.687984]  do_syscall_64+0x93/0xd60
>> <4> [157.687987]  ? putname+0x65/0x90
>> <4> [157.687990]  ? kmem_cache_free+0x553/0x680
>> <4> [157.687995]  ? putname+0x65/0x90
>> <4> [157.687997]  ? putname+0x65/0x90
>> <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0
>> <4> [157.688003]  ? __x64_sys_openat+0x54/0xa0
>> <4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
>> <4> [157.688009]  ? __fput+0x1bf/0x2f0
>> <4> [157.688012]  ? fput_close_sync+0x3d/0xa0
>> <4> [157.688015]  ? __x64_sys_close+0x3e/0x90
>> <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
>> <4> [157.688019]  ? putname+0x65/0x90
>> <4> [157.688021]  ? putname+0x65/0x90
>> <4> [157.688023]  ? do_sys_openat2+0x8b/0xd0
>> <4> [157.688024]  ? __fput+0x1bf/0x2f0
>> <4> [157.688028]  ? __x64_sys_openat+0x54/0xa0
>> <4> [157.688032]  ? do_syscall_64+0x1b7/0xd60
>> <4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
>> <4> [157.688036]  ? irqentry_exit+0x77/0xb0
>> <4> [157.688038]  ? exc_page_fault+0xbd/0x2c0
>> <4> [157.688042]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
>> <4> [157.688044] RIP: 0033:0x72523c91c574
>> `````````````````````````````````````````````````````````````````````````````````
>> Details log can be found in [2].
>>
>> After bisecting the tree, the following patch [3] seems to be the first 
>> "bad" commit
>>
>> `````````````````````````````````````````````````````````````````````````````````````````````````````````
>> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
>> Author: Christian Brauner <brauner@kernel.org>
>> Date:   Wed Nov 5 14:39:45 2025 +0100
>>
>>      power: always freeze efivarfs
>> `````````````````````````````````````````````````````````````````````````````````````````````````````````
>>
>> We also verified that if we revert the patch the issue is not seen.
>>
>> Could you please check why the patch causes this regression and provide 
>> a fix if necessary?
>>
>> Thank you.
>>
>> Regards
>>
>> Chaitanya
>>
>> [1]
>> https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=suspend
>> [2]
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17595/shard-mtlp-6/igt@gem_exec_suspend@basic-s4-devices.html
>> [3] 
>> https://gitlab.com/freedesktop-mirror/drm-tip/-/commit/a3f8f8662771285511ae26c4c8d3ba1cd22159b9

-- 
Jani Nikula, Intel

Re: BISECTED REGRESSION on v6.18 (was: REGRESSION on drm-tip)

[Rafael J. Wysocki]

On Wed, Dec 3, 2025 at 2:36 PM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Wed, 03 Dec 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Thu, 27 Nov 2025, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
> >> Hello Christian,
> >>
> >> This is Chaitanya (again!).
> >>
> >> This mail is regarding another regression we are seeing in our CI
> >> runs[1] on drm-tip (with both xe and i915).
> >
> > Referring to drm-tip is downplaying the problem. The bisected regression
> > is in v6.18 release. It's breaking suspend/resume across a lot of
> > platforms on two drivers, i915 and xe.
> >
> > a3f8f8662771 ("power: always freeze efivarfs")
> >
> > As far as regressions go, it's pretty bad. Please prioritize.
>
> Added some missing Cc's.

This should fix it:

https://lore.kernel.org/linux-pm/12788397.O9o76ZdvQC@rafael.j.wysocki/

Re: REGRESSION on drm-tip

[Christian Brauner]

On Thu, Nov 27, 2025 at 11:55:54AM +0530, Borah, Chaitanya Kumar wrote:
> Hello Christian,
> 
> This is Chaitanya (again!).
> 
> This mail is regarding another regression we are seeing in our CI runs[1] on
> drm-tip (with both xe and i915).
> 
> `````````````````````````````````````````````````````````````````````````````````
> <4> [157.687644] ------------[ cut here ]------------
> <4> [157.687768] WARNING: CPU: 5 PID: 2277 at kernel/freezer.c:139
> __set_task_frozen+0x7f/0xb0
> ...
> <4> [157.687923] PKRU: 55555554
> <4> [157.687924] Call Trace:
> <4> [157.687925]  <TASK>
> <4> [157.687926]  ? __pfx___set_task_frozen+0x10/0x10
> <4> [157.687929]  task_call_func+0x6d/0x120
> <4> [157.687932]  ? cgroup_freezing+0x89/0x200
> <4> [157.687937]  freeze_task+0x98/0x100
> <4> [157.687940]  try_to_freeze_tasks+0xd2/0x440
> <4> [157.687946]  freeze_processes+0x56/0xd0
> <4> [157.687948]  hibernate+0x129/0x4a0
> <4> [157.687951]  state_store+0xd3/0xe0
> <4> [157.687954]  kobj_attr_store+0x12/0x40
> <4> [157.687959]  sysfs_kf_write+0x4d/0x80
> <4> [157.687963]  kernfs_fop_write_iter+0x188/0x240
> <4> [157.687967]  vfs_write+0x283/0x540
> <4> [157.687969]  ? free_to_partial_list+0x46d/0x640
> <4> [157.687976]  ksys_write+0x6f/0xf0
> <4> [157.687980]  __x64_sys_write+0x19/0x30
> <4> [157.687982]  x64_sys_call+0x79/0x26a0
> <4> [157.687984]  do_syscall_64+0x93/0xd60
> <4> [157.687987]  ? putname+0x65/0x90
> <4> [157.687990]  ? kmem_cache_free+0x553/0x680
> <4> [157.687995]  ? putname+0x65/0x90
> <4> [157.687997]  ? putname+0x65/0x90
> <4> [157.687999]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688003]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688007]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688009]  ? __fput+0x1bf/0x2f0
> <4> [157.688012]  ? fput_close_sync+0x3d/0xa0
> <4> [157.688015]  ? __x64_sys_close+0x3e/0x90
> <4> [157.688017]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688019]  ? putname+0x65/0x90
> <4> [157.688021]  ? putname+0x65/0x90
> <4> [157.688023]  ? do_sys_openat2+0x8b/0xd0
> <4> [157.688024]  ? __fput+0x1bf/0x2f0
> <4> [157.688028]  ? __x64_sys_openat+0x54/0xa0
> <4> [157.688032]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688034]  ? do_syscall_64+0x1b7/0xd60
> <4> [157.688036]  ? irqentry_exit+0x77/0xb0
> <4> [157.688038]  ? exc_page_fault+0xbd/0x2c0
> <4> [157.688042]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> <4> [157.688044] RIP: 0033:0x72523c91c574
> `````````````````````````````````````````````````````````````````````````````````
> Details log can be found in [2].
> 
> After bisecting the tree, the following patch [3] seems to be the first
> "bad" commit
> 
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> Author: Christian Brauner <brauner@kernel.org>
> Date:   Wed Nov 5 14:39:45 2025 +0100
> 
>     power: always freeze efivarfs
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> 
> We also verified that if we revert the patch the issue is not seen.
> 
> Could you please check why the patch causes this regression and provide a
> fix if necessary?

I'm going to send a fix for this to Linus today. Thanks!
Rafael has sent me fix earlier this week.

Re: REGRESSION on drm-tip

[Christian Brauner]

On Fri, Nov 28, 2025 at 01:16:44PM +0530, Borah, Chaitanya Kumar wrote:
> 
> 
> On 11/28/2025 4:34 AM, Ville Syrjälä wrote:
> > > `````````````````````````````````````````````````````````````````````````````````````````````````````````
> > > commit a3f8f8662771285511ae26c4c8d3ba1cd22159b9
> > > Author: Christian Brauner<brauner@kernel.org>
> > > Date:   Wed Nov 5 14:39:45 2025 +0100
> > > 
> > >       power: always freeze efivarfs
> > -       if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> > +	if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
> > 
> > ?
> 
> This change helps.
> @Christian do you plan to send out a fix for it?
> 
> Thank you Ville for pointing it out.

Yes, it's in vfs.fixes. I'll send it today.
>