Re: [PATCH] drm/xe: Prevent runtime PM wake while reading rp0 frequency

["Belgaumkar, Vinay" <vinay.belgaumkar@intel.com>]

On 10/15/2025 2:46 AM, Badal Nilawar wrote:
> The rp0 frequency is a fused value that is read once during probe
> and then cached, so there’s no need to trigger a runtime wake
> when accessing rp0.
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_freq.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c
> index 4ff1b6b58d6b..701349251bbc 100644
> --- a/drivers/gpu/drm/xe/xe_gt_freq.c
> +++ b/drivers/gpu/drm/xe/xe_gt_freq.c
> @@ -99,13 +99,8 @@ static ssize_t rp0_freq_show(struct kobject *kobj,
>   {
>   	struct device *dev = kobj_to_dev(kobj);
>   	struct xe_guc_pc *pc = dev_to_pc(dev);
> -	u32 freq;
>   
> -	xe_pm_runtime_get(dev_to_xe(dev));
> -	freq = xe_guc_pc_get_rp0_freq(pc);
> -	xe_pm_runtime_put(dev_to_xe(dev));
> -
> -	return sysfs_emit(buf, "%d\n", freq);
> +	return sysfs_emit(buf, "%d\n", xe_guc_pc_get_rp0_freq(pc));

LGTM,

Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

>   }
>   static struct kobj_attribute attr_rp0_freq = __ATTR_RO(rp0_freq);
>