From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Poosa, Karthik" <karthik.poosa@intel.com>
Cc: "Nilawar, Badal" <badal.nilawar@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Belgaumkar, Vinay" <vinay.belgaumkar@intel.com>,
"Anirban, Sk" <sk.anirban@intel.com>
Subject: Re: drm/xe: Prevent runtime PM wake while reading rp0 frequency
Date: Thu, 16 Oct 2025 15:05:49 -0400 [thread overview]
Message-ID: <aPFCDefOdE7XO13B@intel.com> (raw)
In-Reply-To: <BL1PR11MB52546B55031A832837655172E5E8A@BL1PR11MB5254.namprd11.prod.outlook.com>
On Wed, Oct 15, 2025 at 11:38:48AM +0000, Poosa, Karthik wrote:
> -----Original Message-----
> From: Badal Nilawar <badal.nilawar@intel.com>
> Sent: 15 October 2025 15:16
> To: intel-xe@lists.freedesktop.org
> Cc: rodrigo.vivi@intel.com; vinay.belgaumkar@intel.com; sk.anirban@intel.com
> Subject: drm/xe: Prevent runtime PM wake while reading rp0 frequency
>
> The rp0 frequency is a fused value that is read once during probe and then cached, so there’s no need to trigger a runtime wake when accessing rp0.
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_freq.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_freq.c b/drivers/gpu/drm/xe/xe_gt_freq.c index 4ff1b6b58d6b..701349251bbc 100644
> --- a/drivers/gpu/drm/xe/xe_gt_freq.c
> +++ b/drivers/gpu/drm/xe/xe_gt_freq.c
> @@ -99,13 +99,8 @@ static ssize_t rp0_freq_show(struct kobject *kobj, {
> struct device *dev = kobj_to_dev(kobj);
> struct xe_guc_pc *pc = dev_to_pc(dev);
> - u32 freq;
>
> - xe_pm_runtime_get(dev_to_xe(dev));
> - freq = xe_guc_pc_get_rp0_freq(pc);
> - xe_pm_runtime_put(dev_to_xe(dev));
> -
> - return sysfs_emit(buf, "%d\n", freq);
> + return sysfs_emit(buf, "%d\n", xe_guc_pc_get_rp0_freq(pc));
> }
> static struct kobj_attribute attr_rp0_freq = __ATTR_RO(rp0_freq);
>
> LGTM.
> Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>
pushed to drm-xe-next, thanks for the patch and reviews
>
next prev parent reply other threads:[~2025-10-16 19:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 9:46 [PATCH] drm/xe: Prevent runtime PM wake while reading rp0 frequency Badal Nilawar
2025-10-15 11:38 ` Poosa, Karthik
2025-10-16 19:05 ` Rodrigo Vivi [this message]
2025-10-15 14:41 ` ✗ CI.checkpatch: warning for " Patchwork
2025-10-15 14:42 ` ✓ CI.KUnit: success " Patchwork
2025-10-15 15:20 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-15 19:19 ` [PATCH] " Belgaumkar, Vinay
2025-10-16 0:10 ` ✗ Xe.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPFCDefOdE7XO13B@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=sk.anirban@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox