Re: [PATCH v8 4/4] drm/xe/vf: Fixup CTB send buffer messages after migration

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 11.04.2025 16:39, Lis, Tomasz wrote:
> 
> On 10.04.2025 19:58, Michal Wajdeczko wrote:
>> On 09.04.2025 23:13, Tomasz Lis wrote:

...

>>> + */
>>> +static void ct_fixup_ggtt_in_message(struct xe_guc_ct *ct,
>>> +                       struct iosys_map *cmds, u32 head,
>>> +                       u32 len, u32 size, s64 shift)
>> -:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
>> parenthesis
>> #84: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1655:
>> +static void ct_fixup_ggtt_in_message(struct xe_guc_ct *ct,
>> +                       struct iosys_map *cmds, u32 head,
>>
>> did you really run checkpatch.pl as promised ?
> Many functions got renamed on your request.

so it's my fault?

...

>>> +static int ct_fixup_ggtt_in_buffer(struct xe_guc_ct *ct, struct
>>> guc_ctb *h2g,
>>> +                     s64 shift, u32 *mhead, s32 avail)
>> -:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
>> parenthesis
>> #135: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1706:
>> +static int ct_fixup_ggtt_in_buffer(struct xe_guc_ct *ct, struct guc_ctb
>> *h2g,
>> +                     s64 shift, u32 *mhead, s32 avail)
> 
> will fix. And do checkpatch again.
> 

not just 'again' or this 'next' time

it has to be run *each* time you plan to submit patches [1] so you want
waste CI and/or reviewers time

[1]
https://docs.kernel.org/process/submitting-patches.html#style-check-your-changes