* [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap
@ 2025-04-07 14:18 Matthew Auld
2025-04-07 14:18 ` [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check Matthew Auld
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Matthew Auld @ 2025-04-07 14:18 UTC (permalink / raw)
To: intel-xe; +Cc: Thomas Hellström, Matthew Brost, stable
The is_vram() is checking the current placement, however if we consider
exported VRAM with dynamic dma-buf, it looks possible for the xe driver
to async evict the memory, notifying the importer, however importer does
not have to call unmap_attachment() immediately, but rather just as
"soon as possible", like when the dma-resv idles. Following from this we
would then pipeline the move, attaching the fence to the manager, and
then update the current placement. But when the unmap_attachment() runs
at some later point we might see that is_vram() is now false, and take
the complete wrong path when dma-unmapping the sg, leading to
explosions.
To fix this check if the sgl was mapping a struct page.
v2:
- The attachment can be mapped multiple times it seems, so we can't
really rely on encoding something in the attachment->priv. Instead
see if the page_link has an encoded struct page. For vram we expect
this to be NULL.
Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4563
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
---
drivers/gpu/drm/xe/xe_dma_buf.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
index f67803e15a0e..f7a20264ea33 100644
--- a/drivers/gpu/drm/xe/xe_dma_buf.c
+++ b/drivers/gpu/drm/xe/xe_dma_buf.c
@@ -145,10 +145,7 @@ static void xe_dma_buf_unmap(struct dma_buf_attachment *attach,
struct sg_table *sgt,
enum dma_data_direction dir)
{
- struct dma_buf *dma_buf = attach->dmabuf;
- struct xe_bo *bo = gem_to_xe_bo(dma_buf->priv);
-
- if (!xe_bo_is_vram(bo)) {
+ if (sg_page(sgt->sgl)) {
dma_unmap_sgtable(attach->dev, sgt, dir, 0);
sg_free_table(sgt);
kfree(sgt);
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
@ 2025-04-07 14:18 ` Matthew Auld
2025-04-07 14:32 ` Christian König
2025-04-07 14:38 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Matthew Auld @ 2025-04-07 14:18 UTC (permalink / raw)
To: intel-xe; +Cc: Christian König, amd-gfx, stable
The page_link lower bits of the first sg could contain something like
SG_END, if we are mapping a single VRAM page or contiguous blob which
fits into one sg entry. Rather pull out the struct page, and use that in
our check to know if we mapped struct pages vs VRAM.
Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.8+
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
index 9f627caedc3f..c9842a0e2a1c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
@@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
struct sg_table *sgt,
enum dma_data_direction dir)
{
- if (sgt->sgl->page_link) {
+ if (sg_page(sgt->sgl)) {
dma_unmap_sgtable(attach->dev, sgt, dir, 0);
sg_free_table(sgt);
kfree(sgt);
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:18 ` [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check Matthew Auld
@ 2025-04-07 14:32 ` Christian König
2025-04-07 14:44 ` Matthew Auld
2025-04-07 15:05 ` Alex Deucher
0 siblings, 2 replies; 11+ messages in thread
From: Christian König @ 2025-04-07 14:32 UTC (permalink / raw)
To: Matthew Auld, intel-xe; +Cc: Christian König, amd-gfx, stable
Am 07.04.25 um 16:18 schrieb Matthew Auld:
> The page_link lower bits of the first sg could contain something like
> SG_END, if we are mapping a single VRAM page or contiguous blob which
> fits into one sg entry. Rather pull out the struct page, and use that in
> our check to know if we mapped struct pages vs VRAM.
>
> Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.8+
Good point, haven't thought about that at all since we only abuse the sg table as DMA addr container.
Reviewed-by: Christian König <christian.koenig@amd.com>
Were is patch #1 from this series?
Thanks,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index 9f627caedc3f..c9842a0e2a1c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
> struct sg_table *sgt,
> enum dma_data_direction dir)
> {
> - if (sgt->sgl->page_link) {
> + if (sg_page(sgt->sgl)) {
> dma_unmap_sgtable(attach->dev, sgt, dir, 0);
> sg_free_table(sgt);
> kfree(sgt);
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
2025-04-07 14:18 ` [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check Matthew Auld
@ 2025-04-07 14:38 ` Patchwork
2025-04-07 14:39 ` ✓ CI.checkpatch: " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2025-04-07 14:38 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
URL : https://patchwork.freedesktop.org/series/147332/
State : success
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 100ba24787e8 drm-tip: 2025y-04m-07d-13h-47m-40s UTC integration manifest
=== git am output follows ===
Applying: drm/xe/dma_buf: stop relying on placement in unmap
Applying: drm/amdgpu/dma_buf: fix page_link check
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ CI.checkpatch: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
2025-04-07 14:18 ` [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check Matthew Auld
2025-04-07 14:38 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap Patchwork
@ 2025-04-07 14:39 ` Patchwork
2025-04-07 14:40 ` ✓ CI.KUnit: " Patchwork
2025-04-07 14:43 ` ✗ CI.Build: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2025-04-07 14:39 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
URL : https://patchwork.freedesktop.org/series/147332/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
99e5a866b5e13f134e606a3e29d9508d97826fb3
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 591bd171ed0ed921e274af4de1def4b8ad70c66e
Author: Matthew Auld <matthew.auld@intel.com>
Date: Mon Apr 7 15:18:25 2025 +0100
drm/amdgpu/dma_buf: fix page_link check
The page_link lower bits of the first sg could contain something like
SG_END, if we are mapping a single VRAM page or contiguous blob which
fits into one sg entry. Rather pull out the struct page, and use that in
our check to know if we mapped struct pages vs VRAM.
Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.8+
Reviewed-by: Christian König <christian.koenig@amd.com>
+ /mt/dim checkpatch 100ba24787e877cd422caa7d08cb046ef4bb769c drm-intel
14d392b7452d drm/xe/dma_buf: stop relying on placement in unmap
591bd171ed0e drm/amdgpu/dma_buf: fix page_link check
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ CI.KUnit: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
` (2 preceding siblings ...)
2025-04-07 14:39 ` ✓ CI.checkpatch: " Patchwork
@ 2025-04-07 14:40 ` Patchwork
2025-04-07 14:43 ` ✗ CI.Build: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2025-04-07 14:40 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
URL : https://patchwork.freedesktop.org/series/147332/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[14:39:12] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:39:16] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:39:42] Starting KUnit Kernel (1/1)...
[14:39:42] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:39:42] ================== guc_buf (11 subtests) ===================
[14:39:42] [PASSED] test_smallest
[14:39:42] [PASSED] test_largest
[14:39:42] [PASSED] test_granular
[14:39:42] [PASSED] test_unique
[14:39:42] [PASSED] test_overlap
[14:39:42] [PASSED] test_reusable
[14:39:42] [PASSED] test_too_big
[14:39:42] [PASSED] test_flush
[14:39:42] [PASSED] test_lookup
[14:39:42] [PASSED] test_data
[14:39:42] [PASSED] test_class
[14:39:42] ===================== [PASSED] guc_buf =====================
[14:39:42] =================== guc_dbm (7 subtests) ===================
[14:39:42] [PASSED] test_empty
[14:39:42] [PASSED] test_default
[14:39:42] ======================== test_size ========================
[14:39:42] [PASSED] 4
[14:39:42] [PASSED] 8
[14:39:42] [PASSED] 32
[14:39:42] [PASSED] 256
[14:39:42] ==================== [PASSED] test_size ====================
[14:39:42] ======================= test_reuse ========================
[14:39:42] [PASSED] 4
[14:39:42] [PASSED] 8
[14:39:42] [PASSED] 32
[14:39:42] [PASSED] 256
[14:39:42] =================== [PASSED] test_reuse ====================
[14:39:42] =================== test_range_overlap ====================
[14:39:42] [PASSED] 4
[14:39:42] [PASSED] 8
[14:39:42] [PASSED] 32
[14:39:42] [PASSED] 256
[14:39:42] =============== [PASSED] test_range_overlap ================
[14:39:42] =================== test_range_compact ====================
[14:39:42] [PASSED] 4
[14:39:42] [PASSED] 8
[14:39:42] [PASSED] 32
[14:39:42] [PASSED] 256
[14:39:42] =============== [PASSED] test_range_compact ================
[14:39:42] ==================== test_range_spare =====================
[14:39:42] [PASSED] 4
[14:39:42] [PASSED] 8
[14:39:42] [PASSED] 32
[14:39:42] [PASSED] 256
[14:39:42] ================ [PASSED] test_range_spare =================
[14:39:42] ===================== [PASSED] guc_dbm =====================
[14:39:42] =================== guc_idm (6 subtests) ===================
[14:39:42] [PASSED] bad_init
[14:39:42] [PASSED] no_init
[14:39:42] [PASSED] init_fini
[14:39:42] [PASSED] check_used
[14:39:42] [PASSED] check_quota
[14:39:42] [PASSED] check_all
[14:39:42] ===================== [PASSED] guc_idm =====================
[14:39:42] ================== no_relay (3 subtests) ===================
[14:39:42] [PASSED] xe_drops_guc2pf_if_not_ready
[14:39:42] [PASSED] xe_drops_guc2vf_if_not_ready
[14:39:42] [PASSED] xe_rejects_send_if_not_ready
[14:39:42] ==================== [PASSED] no_relay =====================
[14:39:42] ================== pf_relay (14 subtests) ==================
[14:39:42] [PASSED] pf_rejects_guc2pf_too_short
[14:39:42] [PASSED] pf_rejects_guc2pf_too_long
[14:39:42] [PASSED] pf_rejects_guc2pf_no_payload
[14:39:42] [PASSED] pf_fails_no_payload
[14:39:42] [PASSED] pf_fails_bad_origin
[14:39:42] [PASSED] pf_fails_bad_type
[14:39:42] [PASSED] pf_txn_reports_error
[14:39:42] [PASSED] pf_txn_sends_pf2guc
[14:39:42] [PASSED] pf_sends_pf2guc
[14:39:42] [SKIPPED] pf_loopback_nop
[14:39:42] [SKIPPED] pf_loopback_echo
[14:39:42] [SKIPPED] pf_loopback_fail
[14:39:42] [SKIPPED] pf_loopback_busy
[14:39:42] [SKIPPED] pf_loopback_retry
[14:39:42] ==================== [PASSED] pf_relay =====================
[14:39:42] ================== vf_relay (3 subtests) ===================
[14:39:42] [PASSED] vf_rejects_guc2vf_too_short
[14:39:42] [PASSED] vf_rejects_guc2vf_too_long
[14:39:42] [PASSED] vf_rejects_guc2vf_no_payload
[14:39:42] ==================== [PASSED] vf_relay =====================
[14:39:42] ================= pf_service (11 subtests) =================
[14:39:42] [PASSED] pf_negotiate_any
[14:39:42] [PASSED] pf_negotiate_base_match
[14:39:42] [PASSED] pf_negotiate_base_newer
[14:39:42] [PASSED] pf_negotiate_base_next
[14:39:42] [SKIPPED] pf_negotiate_base_older
[14:39:42] [PASSED] pf_negotiate_base_prev
[14:39:42] [PASSED] pf_negotiate_latest_match
[14:39:42] [PASSED] pf_negotiate_latest_newer
[14:39:42] [PASSED] pf_negotiate_latest_next
[14:39:42] [SKIPPED] pf_negotiate_latest_older
[14:39:42] [SKIPPED] pf_negotiate_latest_prev
[14:39:42] =================== [PASSED] pf_service ====================
[14:39:42] ===================== lmtt (1 subtest) =====================
[14:39:42] ======================== test_ops =========================
[14:39:42] [PASSED] 2-level
[14:39:42] [PASSED] multi-level
[14:39:42] ==================== [PASSED] test_ops =====================
[14:39:42] ====================== [PASSED] lmtt =======================
[14:39:42] =================== xe_mocs (2 subtests) ===================
[14:39:42] ================ xe_live_mocs_kernel_kunit ================
[14:39:42] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[14:39:42] ================ xe_live_mocs_reset_kunit =================
[14:39:42] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[14:39:42] ==================== [SKIPPED] xe_mocs =====================
[14:39:42] ================= xe_migrate (2 subtests) ==================
[14:39:42] ================= xe_migrate_sanity_kunit =================
[14:39:42] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[14:39:42] ================== xe_validate_ccs_kunit ==================
[14:39:42] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[14:39:42] =================== [SKIPPED] xe_migrate ===================
[14:39:42] ================== xe_dma_buf (1 subtest) ==================
[14:39:42] ==================== xe_dma_buf_kunit =====================
[14:39:42] ================ [SKIPPED] xe_dma_buf_kunit ================
[14:39:42] =================== [SKIPPED] xe_dma_buf ===================
[14:39:42] ================= xe_bo_shrink (1 subtest) =================
[14:39:42] =================== xe_bo_shrink_kunit ====================
[14:39:42] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[14:39:42] ================== [SKIPPED] xe_bo_shrink ==================
[14:39:42] ==================== xe_bo (2 subtests) ====================
[14:39:42] ================== xe_ccs_migrate_kunit ===================
[14:39:42] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[14:39:42] ==================== xe_bo_evict_kunit ====================
[14:39:42] =============== [SKIPPED] xe_bo_evict_kunit ================
[14:39:42] ===================== [SKIPPED] xe_bo ======================
[14:39:42] ==================== args (11 subtests) ====================
[14:39:42] [PASSED] count_args_test
[14:39:42] [PASSED] call_args_example
[14:39:42] [PASSED] call_args_test
[14:39:42] [PASSED] drop_first_arg_example
[14:39:42] [PASSED] drop_first_arg_test
[14:39:42] [PASSED] first_arg_example
[14:39:42] [PASSED] first_arg_test
[14:39:42] [PASSED] last_arg_example
[14:39:42] [PASSED] last_arg_test
[14:39:42] [PASSED] pick_arg_example
[14:39:42] [PASSED] sep_comma_example
[14:39:42] ====================== [PASSED] args =======================
[14:39:42] =================== xe_pci (2 subtests) ====================
[14:39:42] [PASSED] xe_gmdid_graphics_ip
[14:39:42] [PASSED] xe_gmdid_media_ip
[14:39:42] ===================== [PASSED] xe_pci ======================
[14:39:42] =================== xe_rtp (2 subtests) ====================
[14:39:42] =============== xe_rtp_process_to_sr_tests ================
[14:39:42] [PASSED] coalesce-same-reg
[14:39:42] [PASSED] no-match-no-add
[14:39:42] [PASSED] match-or
[14:39:42] [PASSED] match-or-xfail
[14:39:42] [PASSED] no-match-no-add-multiple-rules
[14:39:42] [PASSED] two-regs-two-entries
[14:39:42] [PASSED] clr-one-set-other
[14:39:42] [PASSED] set-field
[14:39:42] [PASSED] conflict-duplicate
[14:39:42] [PASSED] conflict-not-disjoint
stty: 'standard input': Inappropriate ioctl for device
[14:39:42] [PASSED] conflict-reg-type
[14:39:42] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[14:39:42] ================== xe_rtp_process_tests ===================
[14:39:42] [PASSED] active1
[14:39:42] [PASSED] active2
[14:39:42] [PASSED] active-inactive
[14:39:42] [PASSED] inactive-active
[14:39:42] [PASSED] inactive-1st_or_active-inactive
[14:39:42] [PASSED] inactive-2nd_or_active-inactive
[14:39:42] [PASSED] inactive-last_or_active-inactive
[14:39:42] [PASSED] inactive-no_or_active-inactive
[14:39:42] ============== [PASSED] xe_rtp_process_tests ===============
[14:39:42] ===================== [PASSED] xe_rtp ======================
[14:39:42] ==================== xe_wa (1 subtest) =====================
[14:39:42] ======================== xe_wa_gt =========================
[14:39:42] [PASSED] TIGERLAKE (B0)
[14:39:42] [PASSED] DG1 (A0)
[14:39:42] [PASSED] DG1 (B0)
[14:39:42] [PASSED] ALDERLAKE_S (A0)
[14:39:42] [PASSED] ALDERLAKE_S (B0)
[14:39:42] [PASSED] ALDERLAKE_S (C0)
[14:39:42] [PASSED] ALDERLAKE_S (D0)
[14:39:42] [PASSED] ALDERLAKE_P (A0)
[14:39:42] [PASSED] ALDERLAKE_P (B0)
[14:39:42] [PASSED] ALDERLAKE_P (C0)
[14:39:42] [PASSED] ALDERLAKE_S_RPLS (D0)
[14:39:42] [PASSED] ALDERLAKE_P_RPLU (E0)
[14:39:42] [PASSED] DG2_G10 (C0)
[14:39:42] [PASSED] DG2_G11 (B1)
[14:39:42] [PASSED] DG2_G12 (A1)
[14:39:42] [PASSED] METEORLAKE (g:A0, m:A0)
[14:39:43] [PASSED] METEORLAKE (g:A0, m:A0)
[14:39:43] [PASSED] METEORLAKE (g:A0, m:A0)
[14:39:43] [PASSED] LUNARLAKE (g:A0, m:A0)
[14:39:43] [PASSED] LUNARLAKE (g:B0, m:A0)
[14:39:43] [PASSED] BATTLEMAGE (g:A0, m:A1)
[14:39:43] ==================== [PASSED] xe_wa_gt =====================
[14:39:43] ====================== [PASSED] xe_wa ======================
[14:39:43] ============================================================
[14:39:43] Testing complete. Ran 133 tests: passed: 117, skipped: 16
[14:39:43] Elapsed time: 30.984s total, 4.230s configuring, 26.437s building, 0.293s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[14:39:43] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:39:44] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:40:06] Starting KUnit Kernel (1/1)...
[14:40:06] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:40:06] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[14:40:06] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[14:40:06] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[14:40:06] =========== drm_validate_clone_mode (2 subtests) ===========
[14:40:06] ============== drm_test_check_in_clone_mode ===============
[14:40:06] [PASSED] in_clone_mode
[14:40:06] [PASSED] not_in_clone_mode
[14:40:06] ========== [PASSED] drm_test_check_in_clone_mode ===========
[14:40:06] =============== drm_test_check_valid_clones ===============
[14:40:06] [PASSED] not_in_clone_mode
[14:40:06] [PASSED] valid_clone
[14:40:06] [PASSED] invalid_clone
[14:40:06] =========== [PASSED] drm_test_check_valid_clones ===========
[14:40:06] ============= [PASSED] drm_validate_clone_mode =============
[14:40:06] ============= drm_validate_modeset (1 subtest) =============
[14:40:06] [PASSED] drm_test_check_connector_changed_modeset
[14:40:06] ============== [PASSED] drm_validate_modeset ===============
[14:40:06] ====== drm_test_bridge_get_current_state (2 subtests) ======
[14:40:06] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[14:40:06] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[14:40:06] ======== [PASSED] drm_test_bridge_get_current_state ========
[14:40:06] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[14:40:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[14:40:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[14:40:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[14:40:06] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[14:40:06] ================== drm_buddy (7 subtests) ==================
[14:40:06] [PASSED] drm_test_buddy_alloc_limit
[14:40:06] [PASSED] drm_test_buddy_alloc_optimistic
[14:40:06] [PASSED] drm_test_buddy_alloc_pessimistic
[14:40:06] [PASSED] drm_test_buddy_alloc_pathological
[14:40:06] [PASSED] drm_test_buddy_alloc_contiguous
[14:40:06] [PASSED] drm_test_buddy_alloc_clear
[14:40:06] [PASSED] drm_test_buddy_alloc_range_bias
[14:40:06] ==================== [PASSED] drm_buddy ====================
[14:40:06] ============= drm_cmdline_parser (40 subtests) =============
[14:40:06] [PASSED] drm_test_cmdline_force_d_only
[14:40:06] [PASSED] drm_test_cmdline_force_D_only_dvi
[14:40:06] [PASSED] drm_test_cmdline_force_D_only_hdmi
[14:40:06] [PASSED] drm_test_cmdline_force_D_only_not_digital
[14:40:06] [PASSED] drm_test_cmdline_force_e_only
[14:40:06] [PASSED] drm_test_cmdline_res
[14:40:06] [PASSED] drm_test_cmdline_res_vesa
[14:40:06] [PASSED] drm_test_cmdline_res_vesa_rblank
[14:40:06] [PASSED] drm_test_cmdline_res_rblank
[14:40:06] [PASSED] drm_test_cmdline_res_bpp
[14:40:06] [PASSED] drm_test_cmdline_res_refresh
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[14:40:06] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[14:40:06] [PASSED] drm_test_cmdline_res_margins_force_on
[14:40:06] [PASSED] drm_test_cmdline_res_vesa_margins
[14:40:06] [PASSED] drm_test_cmdline_name
[14:40:06] [PASSED] drm_test_cmdline_name_bpp
[14:40:06] [PASSED] drm_test_cmdline_name_option
[14:40:06] [PASSED] drm_test_cmdline_name_bpp_option
[14:40:06] [PASSED] drm_test_cmdline_rotate_0
[14:40:06] [PASSED] drm_test_cmdline_rotate_90
[14:40:06] [PASSED] drm_test_cmdline_rotate_180
[14:40:06] [PASSED] drm_test_cmdline_rotate_270
[14:40:06] [PASSED] drm_test_cmdline_hmirror
[14:40:06] [PASSED] drm_test_cmdline_vmirror
[14:40:06] [PASSED] drm_test_cmdline_margin_options
[14:40:06] [PASSED] drm_test_cmdline_multiple_options
[14:40:06] [PASSED] drm_test_cmdline_bpp_extra_and_option
[14:40:06] [PASSED] drm_test_cmdline_extra_and_option
[14:40:06] [PASSED] drm_test_cmdline_freestanding_options
[14:40:06] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[14:40:06] [PASSED] drm_test_cmdline_panel_orientation
[14:40:06] ================ drm_test_cmdline_invalid =================
[14:40:06] [PASSED] margin_only
[14:40:06] [PASSED] interlace_only
[14:40:06] [PASSED] res_missing_x
[14:40:06] [PASSED] res_missing_y
[14:40:06] [PASSED] res_bad_y
[14:40:06] [PASSED] res_missing_y_bpp
[14:40:06] [PASSED] res_bad_bpp
[14:40:06] [PASSED] res_bad_refresh
[14:40:06] [PASSED] res_bpp_refresh_force_on_off
[14:40:06] [PASSED] res_invalid_mode
[14:40:06] [PASSED] res_bpp_wrong_place_mode
[14:40:06] [PASSED] name_bpp_refresh
[14:40:06] [PASSED] name_refresh
[14:40:06] [PASSED] name_refresh_wrong_mode
[14:40:06] [PASSED] name_refresh_invalid_mode
[14:40:06] [PASSED] rotate_multiple
[14:40:06] [PASSED] rotate_invalid_val
[14:40:06] [PASSED] rotate_truncated
[14:40:06] [PASSED] invalid_option
[14:40:06] [PASSED] invalid_tv_option
[14:40:06] [PASSED] truncated_tv_option
[14:40:06] ============ [PASSED] drm_test_cmdline_invalid =============
[14:40:06] =============== drm_test_cmdline_tv_options ===============
[14:40:06] [PASSED] NTSC
[14:40:06] [PASSED] NTSC_443
[14:40:06] [PASSED] NTSC_J
[14:40:06] [PASSED] PAL
[14:40:06] [PASSED] PAL_M
[14:40:06] [PASSED] PAL_N
[14:40:06] [PASSED] SECAM
[14:40:06] [PASSED] MONO_525
[14:40:06] [PASSED] MONO_625
[14:40:06] =========== [PASSED] drm_test_cmdline_tv_options ===========
[14:40:06] =============== [PASSED] drm_cmdline_parser ================
[14:40:06] ========== drmm_connector_hdmi_init (20 subtests) ==========
[14:40:06] [PASSED] drm_test_connector_hdmi_init_valid
[14:40:06] [PASSED] drm_test_connector_hdmi_init_bpc_8
[14:40:06] [PASSED] drm_test_connector_hdmi_init_bpc_10
[14:40:06] [PASSED] drm_test_connector_hdmi_init_bpc_12
[14:40:06] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[14:40:06] [PASSED] drm_test_connector_hdmi_init_bpc_null
[14:40:06] [PASSED] drm_test_connector_hdmi_init_formats_empty
[14:40:06] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[14:40:06] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:40:06] [PASSED] supported_formats=0x9 yuv420_allowed=1
[14:40:06] [PASSED] supported_formats=0x9 yuv420_allowed=0
[14:40:06] [PASSED] supported_formats=0x3 yuv420_allowed=1
[14:40:06] [PASSED] supported_formats=0x3 yuv420_allowed=0
[14:40:06] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:40:06] [PASSED] drm_test_connector_hdmi_init_null_ddc
[14:40:06] [PASSED] drm_test_connector_hdmi_init_null_product
[14:40:06] [PASSED] drm_test_connector_hdmi_init_null_vendor
[14:40:06] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[14:40:06] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[14:40:06] [PASSED] drm_test_connector_hdmi_init_product_valid
[14:40:06] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[14:40:06] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[14:40:06] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[14:40:06] ========= drm_test_connector_hdmi_init_type_valid =========
[14:40:06] [PASSED] HDMI-A
[14:40:06] [PASSED] HDMI-B
[14:40:06] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[14:40:06] ======== drm_test_connector_hdmi_init_type_invalid ========
[14:40:06] [PASSED] Unknown
[14:40:06] [PASSED] VGA
[14:40:06] [PASSED] DVI-I
[14:40:06] [PASSED] DVI-D
[14:40:06] [PASSED] DVI-A
[14:40:06] [PASSED] Composite
[14:40:06] [PASSED] SVIDEO
[14:40:06] [PASSED] LVDS
[14:40:06] [PASSED] Component
[14:40:06] [PASSED] DIN
[14:40:06] [PASSED] DP
[14:40:06] [PASSED] TV
[14:40:06] [PASSED] eDP
[14:40:06] [PASSED] Virtual
[14:40:06] [PASSED] DSI
[14:40:06] [PASSED] DPI
[14:40:06] [PASSED] Writeback
[14:40:06] [PASSED] SPI
[14:40:06] [PASSED] USB
[14:40:06] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[14:40:06] ============ [PASSED] drmm_connector_hdmi_init =============
[14:40:06] ============= drmm_connector_init (3 subtests) =============
[14:40:06] [PASSED] drm_test_drmm_connector_init
[14:40:06] [PASSED] drm_test_drmm_connector_init_null_ddc
[14:40:06] ========= drm_test_drmm_connector_init_type_valid =========
[14:40:06] [PASSED] Unknown
[14:40:06] [PASSED] VGA
[14:40:06] [PASSED] DVI-I
[14:40:06] [PASSED] DVI-D
[14:40:06] [PASSED] DVI-A
[14:40:06] [PASSED] Composite
[14:40:06] [PASSED] SVIDEO
[14:40:06] [PASSED] LVDS
[14:40:06] [PASSED] Component
[14:40:06] [PASSED] DIN
[14:40:06] [PASSED] DP
[14:40:06] [PASSED] HDMI-A
[14:40:06] [PASSED] HDMI-B
[14:40:06] [PASSED] TV
[14:40:06] [PASSED] eDP
[14:40:06] [PASSED] Virtual
[14:40:06] [PASSED] DSI
[14:40:06] [PASSED] DPI
[14:40:06] [PASSED] Writeback
[14:40:06] [PASSED] SPI
[14:40:06] [PASSED] USB
[14:40:06] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[14:40:06] =============== [PASSED] drmm_connector_init ===============
[14:40:06] ========= drm_connector_dynamic_init (6 subtests) ==========
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_init
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_init_properties
[14:40:06] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[14:40:06] [PASSED] Unknown
[14:40:06] [PASSED] VGA
[14:40:06] [PASSED] DVI-I
[14:40:06] [PASSED] DVI-D
[14:40:06] [PASSED] DVI-A
[14:40:06] [PASSED] Composite
[14:40:06] [PASSED] SVIDEO
[14:40:06] [PASSED] LVDS
[14:40:06] [PASSED] Component
[14:40:06] [PASSED] DIN
[14:40:06] [PASSED] DP
[14:40:06] [PASSED] HDMI-A
[14:40:06] [PASSED] HDMI-B
[14:40:06] [PASSED] TV
[14:40:06] [PASSED] eDP
[14:40:06] [PASSED] Virtual
[14:40:06] [PASSED] DSI
[14:40:06] [PASSED] DPI
[14:40:06] [PASSED] Writeback
[14:40:06] [PASSED] SPI
[14:40:06] [PASSED] USB
[14:40:06] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[14:40:06] ======== drm_test_drm_connector_dynamic_init_name =========
[14:40:06] [PASSED] Unknown
[14:40:06] [PASSED] VGA
[14:40:06] [PASSED] DVI-I
[14:40:06] [PASSED] DVI-D
[14:40:06] [PASSED] DVI-A
[14:40:06] [PASSED] Composite
[14:40:06] [PASSED] SVIDEO
[14:40:06] [PASSED] LVDS
[14:40:06] [PASSED] Component
[14:40:06] [PASSED] DIN
[14:40:06] [PASSED] DP
[14:40:06] [PASSED] HDMI-A
[14:40:06] [PASSED] HDMI-B
[14:40:06] [PASSED] TV
[14:40:06] [PASSED] eDP
[14:40:06] [PASSED] Virtual
[14:40:06] [PASSED] DSI
[14:40:06] [PASSED] DPI
[14:40:06] [PASSED] Writeback
[14:40:06] [PASSED] SPI
[14:40:06] [PASSED] USB
[14:40:06] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[14:40:06] =========== [PASSED] drm_connector_dynamic_init ============
[14:40:06] ==== drm_connector_dynamic_register_early (4 subtests) =====
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[14:40:06] ====== [PASSED] drm_connector_dynamic_register_early =======
[14:40:06] ======= drm_connector_dynamic_register (7 subtests) ========
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[14:40:06] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[14:40:06] ========= [PASSED] drm_connector_dynamic_register ==========
[14:40:06] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[14:40:06] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[14:40:06] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[14:40:06] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[14:40:06] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[14:40:06] ========== drm_test_get_tv_mode_from_name_valid ===========
[14:40:06] [PASSED] NTSC
[14:40:06] [PASSED] NTSC-443
[14:40:06] [PASSED] NTSC-J
[14:40:06] [PASSED] PAL
[14:40:06] [PASSED] PAL-M
[14:40:06] [PASSED] PAL-N
[14:40:06] [PASSED] SECAM
[14:40:06] [PASSED] Mono
[14:40:06] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[14:40:06] [PASSED] drm_test_get_tv_mode_from_name_truncated
[14:40:06] ============ [PASSED] drm_get_tv_mode_from_name ============
[14:40:06] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[14:40:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[14:40:06] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[14:40:06] [PASSED] VIC 96
[14:40:06] [PASSED] VIC 97
[14:40:06] [PASSED] VIC 101
[14:40:06] [PASSED] VIC 102
[14:40:06] [PASSED] VIC 106
[14:40:06] [PASSED] VIC 107
[14:40:06] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[14:40:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[14:40:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[14:40:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[14:40:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[14:40:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[14:40:06] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[14:40:06] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[14:40:06] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[14:40:06] [PASSED] Automatic
[14:40:06] [PASSED] Full
[14:40:06] [PASSED] Limited 16:235
[14:40:06] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[14:40:06] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[14:40:06] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[14:40:06] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[14:40:06] === drm_test_drm_hdmi_connector_get_output_format_name ====
[14:40:06] [PASSED] RGB
[14:40:06] [PASSED] YUV 4:2:0
[14:40:06] [PASSED] YUV 4:2:2
[14:40:06] [PASSED] YUV 4:4:4
[14:40:06] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[14:40:06] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[14:40:06] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[14:40:06] ============= drm_damage_helper (21 subtests) ==============
[14:40:06] [PASSED] drm_test_damage_iter_no_damage
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_src_moved
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_not_visible
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[14:40:06] [PASSED] drm_test_damage_iter_no_damage_no_fb
[14:40:06] [PASSED] drm_test_damage_iter_simple_damage
[14:40:06] [PASSED] drm_test_damage_iter_single_damage
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_outside_src
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_src_moved
[14:40:06] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[14:40:06] [PASSED] drm_test_damage_iter_damage
[14:40:06] [PASSED] drm_test_damage_iter_damage_one_intersect
[14:40:06] [PASSED] drm_test_damage_iter_damage_one_outside
[14:40:06] [PASSED] drm_test_damage_iter_damage_src_moved
[14:40:06] [PASSED] drm_test_damage_iter_damage_not_visible
[14:40:06] ================ [PASSED] drm_damage_helper ================
[14:40:06] ============== drm_dp_mst_helper (3 subtests) ==============
[14:40:06] ============== drm_test_dp_mst_calc_pbn_mode ==============
[14:40:06] [PASSED] Clock 154000 BPP 30 DSC disabled
[14:40:06] [PASSED] Clock 234000 BPP 30 DSC disabled
[14:40:06] [PASSED] Clock 297000 BPP 24 DSC disabled
[14:40:06] [PASSED] Clock 332880 BPP 24 DSC enabled
[14:40:06] [PASSED] Clock 324540 BPP 24 DSC enabled
[14:40:06] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[14:40:06] ============== drm_test_dp_mst_calc_pbn_div ===============
[14:40:06] [PASSED] Link rate 2000000 lane count 4
[14:40:06] [PASSED] Link rate 2000000 lane count 2
[14:40:06] [PASSED] Link rate 2000000 lane count 1
[14:40:06] [PASSED] Link rate 1350000 lane count 4
[14:40:06] [PASSED] Link rate 1350000 lane count 2
[14:40:06] [PASSED] Link rate 1350000 lane count 1
[14:40:06] [PASSED] Link rate 1000000 lane count 4
[14:40:06] [PASSED] Link rate 1000000 lane count 2
[14:40:06] [PASSED] Link rate 1000000 lane count 1
[14:40:06] [PASSED] Link rate 810000 lane count 4
[14:40:06] [PASSED] Link rate 810000 lane count 2
[14:40:06] [PASSED] Link rate 810000 lane count 1
[14:40:06] [PASSED] Link rate 540000 lane count 4
[14:40:06] [PASSED] Link rate 540000 lane count 2
[14:40:06] [PASSED] Link rate 540000 lane count 1
[14:40:06] [PASSED] Link rate 270000 lane count 4
[14:40:06] [PASSED] Link rate 270000 lane count 2
[14:40:06] [PASSED] Link rate 270000 lane count 1
[14:40:06] [PASSED] Link rate 162000 lane count 4
[14:40:06] [PASSED] Link rate 162000 lane count 2
[14:40:06] [PASSED] Link rate 162000 lane count 1
[14:40:06] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[14:40:06] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[14:40:06] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[14:40:06] [PASSED] DP_POWER_UP_PHY with port number
[14:40:06] [PASSED] DP_POWER_DOWN_PHY with port number
[14:40:06] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[14:40:06] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[14:40:06] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[14:40:06] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[14:40:06] [PASSED] DP_QUERY_PAYLOAD with port number
[14:40:06] [PASSED] DP_QUERY_PAYLOAD with VCPI
[14:40:06] [PASSED] DP_REMOTE_DPCD_READ with port number
[14:40:06] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[14:40:06] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[14:40:06] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[14:40:06] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[14:40:06] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[14:40:06] [PASSED] DP_REMOTE_I2C_READ with port number
[14:40:06] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[14:40:06] [PASSED] DP_REMOTE_I2C_READ with transactions array
[14:40:06] [PASSED] DP_REMOTE_I2C_WRITE with port number
[14:40:06] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[14:40:06] [PASSED] DP_REMOTE_I2C_WRITE with data array
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[14:40:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[14:40:06] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[14:40:06] ================ [PASSED] drm_dp_mst_helper ================
[14:40:06] ================== drm_exec (7 subtests) ===================
[14:40:06] [PASSED] sanitycheck
[14:40:06] [PASSED] test_lock
[14:40:06] [PASSED] test_lock_unlock
[14:40:06] [PASSED] test_duplicates
[14:40:06] [PASSED] test_prepare
[14:40:06] [PASSED] test_prepare_array
[14:40:06] [PASSED] test_multiple_loops
[14:40:06] ==================== [PASSED] drm_exec =====================
[14:40:06] =========== drm_format_helper_test (18 subtests) ===========
[14:40:06] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[14:40:06] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[14:40:06] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[14:40:06] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[14:40:06] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[14:40:06] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[14:40:06] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[14:40:06] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[14:40:06] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[14:40:06] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[14:40:06] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[14:40:06] ============== drm_test_fb_xrgb8888_to_mono ===============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[14:40:06] ==================== drm_test_fb_swab =====================
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ================ [PASSED] drm_test_fb_swab =================
[14:40:06] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[14:40:06] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[14:40:06] [PASSED] single_pixel_source_buffer
[14:40:06] [PASSED] single_pixel_clip_rectangle
[14:40:06] [PASSED] well_known_colors
[14:40:06] [PASSED] destination_pitch
[14:40:06] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[14:40:06] ================= drm_test_fb_clip_offset =================
[14:40:06] [PASSED] pass through
[14:40:06] [PASSED] horizontal offset
[14:40:06] [PASSED] vertical offset
[14:40:06] [PASSED] horizontal and vertical offset
[14:40:06] [PASSED] horizontal offset (custom pitch)
[14:40:06] [PASSED] vertical offset (custom pitch)
[14:40:06] [PASSED] horizontal and vertical offset (custom pitch)
[14:40:06] ============= [PASSED] drm_test_fb_clip_offset =============
[14:40:06] ============== drm_test_fb_build_fourcc_list ==============
[14:40:06] [PASSED] no native formats
[14:40:06] [PASSED] XRGB8888 as native format
[14:40:06] [PASSED] remove duplicates
[14:40:06] [PASSED] convert alpha formats
[14:40:06] [PASSED] random formats
[14:40:06] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[14:40:06] =================== drm_test_fb_memcpy ====================
[14:40:06] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[14:40:06] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[14:40:06] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[14:40:06] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[14:40:06] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[14:40:06] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[14:40:06] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[14:40:06] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[14:40:06] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[14:40:06] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[14:40:06] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[14:40:06] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[14:40:06] =============== [PASSED] drm_test_fb_memcpy ================
[14:40:06] ============= [PASSED] drm_format_helper_test ==============
[14:40:06] ================= drm_format (18 subtests) =================
[14:40:06] [PASSED] drm_test_format_block_width_invalid
[14:40:06] [PASSED] drm_test_format_block_width_one_plane
[14:40:06] [PASSED] drm_test_format_block_width_two_plane
[14:40:06] [PASSED] drm_test_format_block_width_three_plane
[14:40:06] [PASSED] drm_test_format_block_width_tiled
[14:40:06] [PASSED] drm_test_format_block_height_invalid
[14:40:06] [PASSED] drm_test_format_block_height_one_plane
[14:40:06] [PASSED] drm_test_format_block_height_two_plane
[14:40:06] [PASSED] drm_test_format_block_height_three_plane
[14:40:06] [PASSED] drm_test_format_block_height_tiled
[14:40:06] [PASSED] drm_test_format_min_pitch_invalid
[14:40:06] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[14:40:06] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[14:40:06] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[14:40:06] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[14:40:06] [PASSED] drm_test_format_min_pitch_two_plane
[14:40:06] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[14:40:06] [PASSED] drm_test_format_min_pitch_tiled
[14:40:06] =================== [PASSED] drm_format ====================
[14:40:06] ============== drm_framebuffer (10 subtests) ===============
[14:40:06] ========== drm_test_framebuffer_check_src_coords ==========
[14:40:06] [PASSED] Success: source fits into fb
[14:40:06] [PASSED] Fail: overflowing fb with x-axis coordinate
[14:40:06] [PASSED] Fail: overflowing fb with y-axis coordinate
[14:40:06] [PASSED] Fail: overflowing fb with source width
[14:40:06] [PASSED] Fail: overflowing fb with source height
[14:40:06] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[14:40:06] [PASSED] drm_test_framebuffer_cleanup
[14:40:06] =============== drm_test_framebuffer_create ===============
[14:40:06] [PASSED] ABGR8888 normal sizes
[14:40:06] [PASSED] ABGR8888 max sizes
[14:40:06] [PASSED] ABGR8888 pitch greater than min required
[14:40:06] [PASSED] ABGR8888 pitch less than min required
[14:40:06] [PASSED] ABGR8888 Invalid width
[14:40:06] [PASSED] ABGR8888 Invalid buffer handle
[14:40:06] [PASSED] No pixel format
[14:40:06] [PASSED] ABGR8888 Width 0
[14:40:06] [PASSED] ABGR8888 Height 0
[14:40:06] [PASSED] ABGR8888 Out of bound height * pitch combination
[14:40:06] [PASSED] ABGR8888 Large buffer offset
[14:40:06] [PASSED] ABGR8888 Buffer offset for inexistent plane
[14:40:06] [PASSED] ABGR8888 Invalid flag
[14:40:06] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[14:40:06] [PASSED] ABGR8888 Valid buffer modifier
[14:40:06] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[14:40:06] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] NV12 Normal sizes
[14:40:06] [PASSED] NV12 Max sizes
[14:40:06] [PASSED] NV12 Invalid pitch
[14:40:06] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[14:40:06] [PASSED] NV12 different modifier per-plane
[14:40:06] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[14:40:06] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] NV12 Modifier for inexistent plane
[14:40:06] [PASSED] NV12 Handle for inexistent plane
[14:40:06] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[14:40:06] [PASSED] YVU420 Normal sizes
[14:40:06] [PASSED] YVU420 Max sizes
[14:40:06] [PASSED] YVU420 Invalid pitch
[14:40:06] [PASSED] YVU420 Different pitches
[14:40:06] [PASSED] YVU420 Different buffer offsets/pitches
[14:40:06] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[14:40:06] [PASSED] YVU420 Valid modifier
[14:40:06] [PASSED] YVU420 Different modifiers per plane
[14:40:06] [PASSED] YVU420 Modifier for inexistent plane
[14:40:06] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[14:40:06] [PASSED] X0L2 Normal sizes
[14:40:06] [PASSED] X0L2 Max sizes
[14:40:06] [PASSED] X0L2 Invalid pitch
[14:40:06] [PASSED] X0L2 Pitch greater than minimum required
[14:40:06] [PASSED] X0L2 Handle for inexistent plane
[14:40:06] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[14:40:06] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[14:40:06] [PASSED] X0L2 Valid modifier
[14:40:06] [PASSED] X0L2 Modifier for inexistent plane
[14:40:06] =========== [PASSED] drm_test_framebuffer_create ===========
[14:40:06] [PASSED] drm_test_framebuffer_free
[14:40:06] [PASSED] drm_test_framebuffer_init
[14:40:06] [PASSED] drm_test_framebuffer_init_bad_format
[14:40:06] [PASSED] drm_test_framebuffer_init_dev_mismatch
[14:40:06] [PASSED] drm_test_framebuffer_lookup
[14:40:06] [PASSED] drm_test_framebuffer_lookup_inexistent
[14:40:06] [PASSED] drm_test_framebuffer_modifiers_not_supported
[14:40:06] ================= [PASSED] drm_framebuffer =================
[14:40:06] ================ drm_gem_shmem (8 subtests) ================
[14:40:06] [PASSED] drm_gem_shmem_test_obj_create
[14:40:06] [PASSED] drm_gem_shmem_test_obj_create_private
[14:40:06] [PASSED] drm_gem_shmem_test_pin_pages
[14:40:06] [PASSED] drm_gem_shmem_test_vmap
[14:40:06] [PASSED] drm_gem_shmem_test_get_pages_sgt
[14:40:06] [PASSED] drm_gem_shmem_test_get_sg_table
[14:40:06] [PASSED] drm_gem_shmem_test_madvise
[14:40:06] [PASSED] drm_gem_shmem_test_purge
[14:40:06] ================== [PASSED] drm_gem_shmem ==================
[14:40:06] === drm_atomic_helper_connector_hdmi_check (23 subtests) ===
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[14:40:06] [PASSED] drm_test_check_disable_connector
[14:40:06] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[14:40:06] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback
[14:40:06] [PASSED] drm_test_check_max_tmds_rate_format_fallback
[14:40:06] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[14:40:06] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[14:40:06] [PASSED] drm_test_check_output_bpc_dvi
[14:40:06] [PASSED] drm_test_check_output_bpc_format_vic_1
[14:40:06] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[14:40:06] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[14:40:06] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[14:40:06] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[14:40:06] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[14:40:06] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[14:40:06] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[14:40:06] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[14:40:06] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[14:40:06] [PASSED] drm_test_check_broadcast_rgb_value
[14:40:06] [PASSED] drm_test_check_bpc_8_value
[14:40:06] [PASSED] drm_test_check_bpc_10_value
[14:40:06] [PASSED] drm_test_check_bpc_12_value
[14:40:06] [PASSED] drm_test_check_format_value
[14:40:06] [PASSED] drm_test_check_tmds_char_value
[14:40:06] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[14:40:06] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[14:40:06] [PASSED] drm_test_check_mode_valid
[14:40:06] [PASSED] drm_test_check_mode_valid_reject
[14:40:06] [PASSED] drm_test_check_mode_valid_reject_rate
[14:40:06] [PASSED] drm_test_check_mode_valid_reject_max_clock
[14:40:06] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[14:40:06] ================= drm_managed (2 subtests) =================
[14:40:06] [PASSED] drm_test_managed_release_action
[14:40:06] [PASSED] drm_test_managed_run_action
[14:40:06] =================== [PASSED] drm_managed ===================
[14:40:06] =================== drm_mm (6 subtests) ====================
[14:40:06] [PASSED] drm_test_mm_init
[14:40:06] [PASSED] drm_test_mm_debug
[14:40:06] [PASSED] drm_test_mm_align32
[14:40:06] [PASSED] drm_test_mm_align64
[14:40:06] [PASSED] drm_test_mm_lowest
[14:40:06] [PASSED] drm_test_mm_highest
[14:40:06] ===================== [PASSED] drm_mm ======================
[14:40:06] ============= drm_modes_analog_tv (5 subtests) =============
[14:40:06] [PASSED] drm_test_modes_analog_tv_mono_576i
[14:40:06] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[14:40:06] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[14:40:06] [PASSED] drm_test_modes_analog_tv_pal_576i
[14:40:06] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[14:40:06] =============== [PASSED] drm_modes_analog_tv ===============
[14:40:06] ============== drm_plane_helper (2 subtests) ===============
[14:40:06] =============== drm_test_check_plane_state ================
[14:40:06] [PASSED] clipping_simple
[14:40:06] [PASSED] clipping_rotate_reflect
[14:40:06] [PASSED] positioning_simple
[14:40:06] [PASSED] upscaling
[14:40:06] [PASSED] downscaling
[14:40:06] [PASSED] rounding1
[14:40:06] [PASSED] rounding2
[14:40:06] [PASSED] rounding3
[14:40:06] [PASSED] rounding4
[14:40:06] =========== [PASSED] drm_test_check_plane_state ============
[14:40:06] =========== drm_test_check_invalid_plane_state ============
[14:40:06] [PASSED] positioning_invalid
[14:40:06] [PASSED] upscaling_invalid
[14:40:06] [PASSED] downscaling_invalid
[14:40:06] ======= [PASSED] drm_test_check_invalid_plane_state ========
[14:40:06] ================ [PASSED] drm_plane_helper =================
[14:40:06] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[14:40:06] ====== drm_test_connector_helper_tv_get_modes_check =======
[14:40:06] [PASSED] None
[14:40:06] [PASSED] PAL
[14:40:06] [PASSED] NTSC
[14:40:06] [PASSED] Both, NTSC Default
[14:40:06] [PASSED] Both, PAL Default
[14:40:06] [PASSED] Both, NTSC Default, with PAL on command-line
[14:40:06] [PASSED] Both, PAL Default, with NTSC on command-line
[14:40:06] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[14:40:06] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[14:40:06] ================== drm_rect (9 subtests) ===================
[14:40:06] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[14:40:06] [PASSED] drm_test_rect_clip_scaled_not_clipped
[14:40:06] [PASSED] drm_test_rect_clip_scaled_clipped
[14:40:06] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[14:40:06] ================= drm_test_rect_intersect =================
[14:40:06] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[14:40:06] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[14:40:06] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[14:40:06] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[14:40:06] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[14:40:06] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[14:40:06] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[14:40:06] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[14:40:06] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[14:40:06] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[14:40:06] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[14:40:06] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[14:40:06] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[14:40:06] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[14:40:06] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[14:40:06] ============= [PASSED] drm_test_rect_intersect =============
[14:40:06] ================ drm_test_rect_calc_hscale ================
[14:40:06] [PASSED] normal use
[14:40:06] [PASSED] out of max range
[14:40:06] [PASSED] out of min range
[14:40:06] [PASSED] zero dst
[14:40:06] [PASSED] negative src
[14:40:06] [PASSED] negative dst
[14:40:06] ============ [PASSED] drm_test_rect_calc_hscale ============
[14:40:06] ================ drm_test_rect_calc_vscale ================
[14:40:06] [PASSED] normal use
[14:40:06] [PASSED] out of max range
[14:40:06] [PASSED] out of min range
[14:40:06] [PASSED] zero dst
[14:40:06] [PASSED] negative src
[14:40:06] [PASSED] negative dst
[14:40:06] ============ [PASSED] drm_test_rect_calc_vscale ============
[14:40:06] ================== drm_test_rect_rotate ===================
[14:40:06] [PASSED] reflect-x
[14:40:06] [PASSED] reflect-y
[14:40:06] [PASSED] rotate-0
[14:40:06] [PASSED] rotate-90
[14:40:06] [PASSED] rotate-180
[14:40:06] [PASSED] rotate-270
[14:40:06] ============== [PASSED] drm_test_rect_rotate ===============
[14:40:06] ================ drm_test_rect_rotate_inv =================
[14:40:06] [PASSED] reflect-x
[14:40:06] [PASSED] reflect-y
[14:40:06] [PASSED] rotate-0
[14:40:06] [PASSED] rotate-90
[14:40:06] [PASSED] rotate-180
[14:40:06] [PASSED] rotate-270
[14:40:06] ============ [PASSED] drm_test_rect_rotate_inv =============
stty: 'standard input': Inappropriate ioctl for device
[14:40:06] ==================== [PASSED] drm_rect =====================
[14:40:06] ============================================================
[14:40:06] Testing complete. Ran 608 tests: passed: 608
[14:40:06] Elapsed time: 23.095s total, 1.754s configuring, 21.122s building, 0.178s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[14:40:06] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:40:08] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:40:15] Starting KUnit Kernel (1/1)...
[14:40:15] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:40:15] ================= ttm_device (5 subtests) ==================
[14:40:15] [PASSED] ttm_device_init_basic
[14:40:15] [PASSED] ttm_device_init_multiple
[14:40:15] [PASSED] ttm_device_fini_basic
[14:40:15] [PASSED] ttm_device_init_no_vma_man
[14:40:15] ================== ttm_device_init_pools ==================
[14:40:15] [PASSED] No DMA allocations, no DMA32 required
[14:40:15] [PASSED] DMA allocations, DMA32 required
[14:40:15] [PASSED] No DMA allocations, DMA32 required
[14:40:15] [PASSED] DMA allocations, no DMA32 required
[14:40:15] ============== [PASSED] ttm_device_init_pools ==============
[14:40:15] =================== [PASSED] ttm_device ====================
[14:40:15] ================== ttm_pool (8 subtests) ===================
[14:40:15] ================== ttm_pool_alloc_basic ===================
[14:40:15] [PASSED] One page
[14:40:15] [PASSED] More than one page
[14:40:15] [PASSED] Above the allocation limit
[14:40:15] [PASSED] One page, with coherent DMA mappings enabled
[14:40:15] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:40:15] ============== [PASSED] ttm_pool_alloc_basic ===============
[14:40:15] ============== ttm_pool_alloc_basic_dma_addr ==============
[14:40:15] [PASSED] One page
[14:40:15] [PASSED] More than one page
[14:40:15] [PASSED] Above the allocation limit
[14:40:15] [PASSED] One page, with coherent DMA mappings enabled
[14:40:15] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:40:15] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[14:40:15] [PASSED] ttm_pool_alloc_order_caching_match
[14:40:15] [PASSED] ttm_pool_alloc_caching_mismatch
[14:40:15] [PASSED] ttm_pool_alloc_order_mismatch
[14:40:15] [PASSED] ttm_pool_free_dma_alloc
[14:40:15] [PASSED] ttm_pool_free_no_dma_alloc
[14:40:15] [PASSED] ttm_pool_fini_basic
[14:40:15] ==================== [PASSED] ttm_pool =====================
[14:40:15] ================ ttm_resource (8 subtests) =================
[14:40:15] ================= ttm_resource_init_basic =================
[14:40:15] [PASSED] Init resource in TTM_PL_SYSTEM
[14:40:15] [PASSED] Init resource in TTM_PL_VRAM
[14:40:15] [PASSED] Init resource in a private placement
[14:40:15] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[14:40:15] ============= [PASSED] ttm_resource_init_basic =============
[14:40:15] [PASSED] ttm_resource_init_pinned
[14:40:15] [PASSED] ttm_resource_fini_basic
[14:40:15] [PASSED] ttm_resource_manager_init_basic
[14:40:15] [PASSED] ttm_resource_manager_usage_basic
[14:40:15] [PASSED] ttm_resource_manager_set_used_basic
[14:40:15] [PASSED] ttm_sys_man_alloc_basic
[14:40:15] [PASSED] ttm_sys_man_free_basic
[14:40:15] ================== [PASSED] ttm_resource ===================
[14:40:15] =================== ttm_tt (15 subtests) ===================
[14:40:15] ==================== ttm_tt_init_basic ====================
[14:40:15] [PASSED] Page-aligned size
[14:40:15] [PASSED] Extra pages requested
[14:40:15] ================ [PASSED] ttm_tt_init_basic ================
[14:40:15] [PASSED] ttm_tt_init_misaligned
[14:40:15] [PASSED] ttm_tt_fini_basic
[14:40:15] [PASSED] ttm_tt_fini_sg
[14:40:15] [PASSED] ttm_tt_fini_shmem
[14:40:15] [PASSED] ttm_tt_create_basic
[14:40:15] [PASSED] ttm_tt_create_invalid_bo_type
[14:40:15] [PASSED] ttm_tt_create_ttm_exists
[14:40:15] [PASSED] ttm_tt_create_failed
[14:40:15] [PASSED] ttm_tt_destroy_basic
[14:40:15] [PASSED] ttm_tt_populate_null_ttm
[14:40:15] [PASSED] ttm_tt_populate_populated_ttm
[14:40:15] [PASSED] ttm_tt_unpopulate_basic
[14:40:15] [PASSED] ttm_tt_unpopulate_empty_ttm
[14:40:15] [PASSED] ttm_tt_swapin_basic
[14:40:15] ===================== [PASSED] ttm_tt ======================
[14:40:15] =================== ttm_bo (14 subtests) ===================
[14:40:15] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[14:40:15] [PASSED] Cannot be interrupted and sleeps
[14:40:15] [PASSED] Cannot be interrupted, locks straight away
[14:40:15] [PASSED] Can be interrupted, sleeps
[14:40:15] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[14:40:15] [PASSED] ttm_bo_reserve_locked_no_sleep
[14:40:15] [PASSED] ttm_bo_reserve_no_wait_ticket
[14:40:15] [PASSED] ttm_bo_reserve_double_resv
[14:40:15] [PASSED] ttm_bo_reserve_interrupted
[14:40:15] [PASSED] ttm_bo_reserve_deadlock
[14:40:15] [PASSED] ttm_bo_unreserve_basic
[14:40:15] [PASSED] ttm_bo_unreserve_pinned
[14:40:15] [PASSED] ttm_bo_unreserve_bulk
[14:40:15] [PASSED] ttm_bo_put_basic
[14:40:15] [PASSED] ttm_bo_put_shared_resv
[14:40:15] [PASSED] ttm_bo_pin_basic
[14:40:15] [PASSED] ttm_bo_pin_unpin_resource
[14:40:15] [PASSED] ttm_bo_multiple_pin_one_unpin
[14:40:15] ===================== [PASSED] ttm_bo ======================
[14:40:15] ============== ttm_bo_validate (22 subtests) ===============
[14:40:15] ============== ttm_bo_init_reserved_sys_man ===============
[14:40:15] [PASSED] Buffer object for userspace
[14:40:15] [PASSED] Kernel buffer object
[14:40:15] [PASSED] Shared buffer object
[14:40:15] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[14:40:15] ============== ttm_bo_init_reserved_mock_man ==============
[14:40:15] [PASSED] Buffer object for userspace
[14:40:15] [PASSED] Kernel buffer object
[14:40:15] [PASSED] Shared buffer object
[14:40:15] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[14:40:15] [PASSED] ttm_bo_init_reserved_resv
[14:40:15] ================== ttm_bo_validate_basic ==================
[14:40:15] [PASSED] Buffer object for userspace
[14:40:15] [PASSED] Kernel buffer object
[14:40:15] [PASSED] Shared buffer object
[14:40:15] ============== [PASSED] ttm_bo_validate_basic ==============
[14:40:15] [PASSED] ttm_bo_validate_invalid_placement
[14:40:15] ============= ttm_bo_validate_same_placement ==============
[14:40:15] [PASSED] System manager
[14:40:15] [PASSED] VRAM manager
[14:40:15] ========= [PASSED] ttm_bo_validate_same_placement ==========
[14:40:15] [PASSED] ttm_bo_validate_failed_alloc
[14:40:15] [PASSED] ttm_bo_validate_pinned
[14:40:15] [PASSED] ttm_bo_validate_busy_placement
[14:40:15] ================ ttm_bo_validate_multihop =================
[14:40:15] [PASSED] Buffer object for userspace
[14:40:15] [PASSED] Kernel buffer object
[14:40:15] [PASSED] Shared buffer object
[14:40:15] ============ [PASSED] ttm_bo_validate_multihop =============
[14:40:15] ========== ttm_bo_validate_no_placement_signaled ==========
[14:40:15] [PASSED] Buffer object in system domain, no page vector
[14:40:15] [PASSED] Buffer object in system domain with an existing page vector
[14:40:15] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[14:40:15] ======== ttm_bo_validate_no_placement_not_signaled ========
[14:40:15] [PASSED] Buffer object for userspace
[14:40:15] [PASSED] Kernel buffer object
[14:40:15] [PASSED] Shared buffer object
[14:40:15] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[14:40:15] [PASSED] ttm_bo_validate_move_fence_signaled
[14:40:16] ========= ttm_bo_validate_move_fence_not_signaled =========
[14:40:16] [PASSED] Waits for GPU
[14:40:16] [PASSED] Tries to lock straight away
[14:40:16] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[14:40:16] [PASSED] ttm_bo_validate_swapout
[14:40:16] [PASSED] ttm_bo_validate_happy_evict
[14:40:16] [PASSED] ttm_bo_validate_all_pinned_evict
[14:40:16] [PASSED] ttm_bo_validate_allowed_only_evict
[14:40:16] [PASSED] ttm_bo_validate_deleted_evict
[14:40:16] [PASSED] ttm_bo_validate_busy_domain_evict
[14:40:16] [PASSED] ttm_bo_validate_evict_gutting
[14:40:16] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[14:40:16] ================= [PASSED] ttm_bo_validate =================
[14:40:16] ============================================================
[14:40:16] Testing complete. Ran 102 tests: passed: 102
[14:40:16] Elapsed time: 10.154s total, 1.713s configuring, 7.824s building, 0.522s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ CI.Build: failure for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
` (3 preceding siblings ...)
2025-04-07 14:40 ` ✓ CI.KUnit: " Patchwork
@ 2025-04-07 14:43 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2025-04-07 14:43 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap
URL : https://patchwork.freedesktop.org/series/147332/
State : failure
== Summary ==
CC [M] drivers/mfd/tps65086.o
CC [M] net/netfilter/xt_owner.o
AR drivers/regulator/built-in.a
CC [M] drivers/mfd/tps6594-core.o
CC [M] drivers/mfd/tps6594-i2c.o
CC [M] net/netfilter/xt_cgroup.o
CC [M] net/netfilter/xt_physdev.o
CC [M] drivers/mfd/tps6594-spi.o
CC [M] net/netfilter/xt_pkttype.o
CC [M] drivers/mfd/mc13xxx-core.o
CC [M] drivers/mfd/mc13xxx-spi.o
CC [M] drivers/mfd/mc13xxx-i2c.o
CC [M] drivers/mfd/ocelot-core.o
CC [M] net/netfilter/xt_policy.o
CC [M] net/netfilter/xt_quota.o
CC [M] drivers/mfd/ocelot-spi.o
CC [M] net/netfilter/xt_rateest.o
CC [M] drivers/mfd/axp20x.o
AR fs/built-in.a
CC [M] net/netfilter/xt_realm.o
CC [M] drivers/mfd/axp20x-i2c.o
CC [M] net/netfilter/xt_recent.o
CC [M] drivers/mfd/lp3943.o
CC [M] drivers/mfd/ti-lmu.o
CC [M] net/netfilter/xt_sctp.o
CC [M] drivers/mfd/da9062-core.o
CC [M] net/netfilter/xt_socket.o
CC [M] drivers/mfd/da9150-core.o
CC [M] net/netfilter/xt_state.o
CC [M] drivers/mfd/max77541.o
CC [M] net/netfilter/xt_statistic.o
CC [M] net/netfilter/xt_string.o
AR lib/built-in.a
CC [M] net/netfilter/xt_tcpmss.o
CC [M] net/netfilter/xt_time.o
CC [M] drivers/mfd/max8907.o
CC [M] net/netfilter/xt_u32.o
CC [M] drivers/mfd/mp2629.o
CC [M] drivers/mfd/mt6360-core.o
CC [M] drivers/mfd/mt6370.o
CC [M] drivers/mfd/mt6397-core.o
CC [M] drivers/mfd/mt6397-irq.o
CC [M] drivers/mfd/mt6358-irq.o
CC [M] drivers/mfd/kempld-core.o
CC [M] drivers/mfd/intel_quark_i2c_gpio.o
CC [M] drivers/mfd/lpc_sch.o
CC [M] drivers/mfd/lpc_ich.o
CC [M] drivers/mfd/rdc321x-southbridge.o
CC [M] drivers/mfd/janz-cmodio.o
CC [M] drivers/mfd/vx855.o
CC [M] drivers/mfd/wl1273-core.o
CC [M] drivers/mfd/si476x-cmd.o
CC [M] drivers/mfd/si476x-prop.o
CC [M] drivers/mfd/si476x-i2c.o
CC [M] drivers/mfd/intel_pmc_bxt.o
CC [M] drivers/mfd/viperboard.o
CC [M] drivers/mfd/lm3533-core.o
CC [M] drivers/mfd/lm3533-ctrlbank.o
CC [M] drivers/mfd/retu-mfd.o
CC [M] drivers/mfd/iqs62x.o
CC [M] drivers/mfd/menf21bmc.o
CC [M] drivers/mfd/dln2.o
CC [M] drivers/mfd/rt4831.o
CC [M] drivers/mfd/rt5033.o
CC [M] drivers/mfd/rt5120.o
CC [M] drivers/mfd/sky81452.o
CC [M] drivers/mfd/intel_soc_pmic_bxtwc.o
CC [M] drivers/mfd/intel_soc_pmic_chtdc_ti.o
CC [M] drivers/mfd/intel_soc_pmic_mrfld.o
CC [M] drivers/mfd/rave-sp.o
CC [M] drivers/mfd/simple-mfd-i2c.o
CC [M] drivers/mfd/smpro-core.o
CC [M] drivers/mfd/intel-m10-bmc-core.o
CC [M] drivers/mfd/intel-m10-bmc-spi.o
CC [M] drivers/mfd/atc260x-core.o
CC [M] drivers/mfd/atc260x-i2c.o
LD [M] net/netfilter/nf_conntrack.o
LD [M] net/netfilter/nf_conntrack_h323.o
LD [M] net/netfilter/nf_nat.o
LD [M] net/netfilter/nf_tables.o
LD [M] net/netfilter/nf_flow_table.o
AR net/netfilter/built-in.a
LD [M] drivers/mfd/arizona.o
LD [M] drivers/mfd/wm8994.o
LD [M] drivers/mfd/madera.o
LD [M] drivers/mfd/mt6397.o
AR drivers/mfd/built-in.a
LD [M] drivers/mfd/ocelot-soc.o
AR net/built-in.a
LD [M] drivers/mfd/si476x-core.o
make[3]: *** [../scripts/Makefile.build:461: drivers] Error 2
make[3]: *** Waiting for unfinished jobs....
CC [M] kernel/kheaders.o
make[2]: *** [/kernel/Makefile:2006: .] Error 2
make[1]: *** [/kernel/Makefile:248: __sub-make] Error 2
make[1]: Leaving directory '/kernel/build64-default'
make: *** [Makefile:248: __sub-make] Error 2
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:32 ` Christian König
@ 2025-04-07 14:44 ` Matthew Auld
2025-04-07 14:46 ` Christian König
2025-04-07 15:05 ` Alex Deucher
1 sibling, 1 reply; 11+ messages in thread
From: Matthew Auld @ 2025-04-07 14:44 UTC (permalink / raw)
To: Christian König, intel-xe; +Cc: Christian König, amd-gfx, stable
On 07/04/2025 15:32, Christian König wrote:
> Am 07.04.25 um 16:18 schrieb Matthew Auld:
>> The page_link lower bits of the first sg could contain something like
>> SG_END, if we are mapping a single VRAM page or contiguous blob which
>> fits into one sg entry. Rather pull out the struct page, and use that in
>> our check to know if we mapped struct pages vs VRAM.
>>
>> Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: <stable@vger.kernel.org> # v5.8+
>
> Good point, haven't thought about that at all since we only abuse the sg table as DMA addr container.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Were is patch #1 from this series?
That one is xe specific:
https://lore.kernel.org/intel-xe/20250407141823.44504-3-matthew.auld@intel.com/T/#m4ef16e478cfc8853d4518448dd345a66d5a7f6d9
I copied your approach with using page_link here, but with added sg_page().
>
> Thanks,
> Christian.
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>> index 9f627caedc3f..c9842a0e2a1c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>> @@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
>> struct sg_table *sgt,
>> enum dma_data_direction dir)
>> {
>> - if (sgt->sgl->page_link) {
>> + if (sg_page(sgt->sgl)) {
>> dma_unmap_sgtable(attach->dev, sgt, dir, 0);
>> sg_free_table(sgt);
>> kfree(sgt);
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:44 ` Matthew Auld
@ 2025-04-07 14:46 ` Christian König
2025-04-07 15:01 ` Matthew Auld
0 siblings, 1 reply; 11+ messages in thread
From: Christian König @ 2025-04-07 14:46 UTC (permalink / raw)
To: Matthew Auld, Christian König, intel-xe; +Cc: amd-gfx, stable
Am 07.04.25 um 16:44 schrieb Matthew Auld:
> On 07/04/2025 15:32, Christian König wrote:
>> Am 07.04.25 um 16:18 schrieb Matthew Auld:
>>> The page_link lower bits of the first sg could contain something like
>>> SG_END, if we are mapping a single VRAM page or contiguous blob which
>>> fits into one sg entry. Rather pull out the struct page, and use that in
>>> our check to know if we mapped struct pages vs VRAM.
>>>
>>> Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Cc: amd-gfx@lists.freedesktop.org
>>> Cc: <stable@vger.kernel.org> # v5.8+
>>
>> Good point, haven't thought about that at all since we only abuse the sg table as DMA addr container.
>>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Were is patch #1 from this series?
>
> That one is xe specific:
> https://lore.kernel.org/intel-xe/20250407141823.44504-3-matthew.auld@intel.com/T/#m4ef16e478cfc8853d4518448dd345a66d5a7f6d9
>
> I copied your approach with using page_link here, but with added sg_page().
Feel free to add my Acked-by to that one as well.
I just wanted to double check if we need to push the patches upstream together, but that looks like we can take each through individual branches.
Thanks,
Christian.
>
>>
>> Thanks,
>> Christian.
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>> index 9f627caedc3f..c9842a0e2a1c 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>> @@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
>>> struct sg_table *sgt,
>>> enum dma_data_direction dir)
>>> {
>>> - if (sgt->sgl->page_link) {
>>> + if (sg_page(sgt->sgl)) {
>>> dma_unmap_sgtable(attach->dev, sgt, dir, 0);
>>> sg_free_table(sgt);
>>> kfree(sgt);
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:46 ` Christian König
@ 2025-04-07 15:01 ` Matthew Auld
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2025-04-07 15:01 UTC (permalink / raw)
To: Christian König, Christian König, intel-xe; +Cc: amd-gfx, stable
On 07/04/2025 15:46, Christian König wrote:
> Am 07.04.25 um 16:44 schrieb Matthew Auld:
>> On 07/04/2025 15:32, Christian König wrote:
>>> Am 07.04.25 um 16:18 schrieb Matthew Auld:
>>>> The page_link lower bits of the first sg could contain something like
>>>> SG_END, if we are mapping a single VRAM page or contiguous blob which
>>>> fits into one sg entry. Rather pull out the struct page, and use that in
>>>> our check to know if we mapped struct pages vs VRAM.
>>>>
>>>> Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>> Cc: Christian König <christian.koenig@amd.com>
>>>> Cc: amd-gfx@lists.freedesktop.org
>>>> Cc: <stable@vger.kernel.org> # v5.8+
>>>
>>> Good point, haven't thought about that at all since we only abuse the sg table as DMA addr container.
>>>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>
>>> Were is patch #1 from this series?
>>
>> That one is xe specific:
>> https://lore.kernel.org/intel-xe/20250407141823.44504-3-matthew.auld@intel.com/T/#m4ef16e478cfc8853d4518448dd345a66d5a7f6d9
>>
>> I copied your approach with using page_link here, but with added sg_page().
>
> Feel free to add my Acked-by to that one as well.
Thanks.
>
> I just wanted to double check if we need to push the patches upstream together, but that looks like we can take each through individual branches.
Sounds good.
>
> Thanks,
> Christian.
>
>>
>>>
>>> Thanks,
>>> Christian.
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>>> index 9f627caedc3f..c9842a0e2a1c 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
>>>> @@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
>>>> struct sg_table *sgt,
>>>> enum dma_data_direction dir)
>>>> {
>>>> - if (sgt->sgl->page_link) {
>>>> + if (sg_page(sgt->sgl)) {
>>>> dma_unmap_sgtable(attach->dev, sgt, dir, 0);
>>>> sg_free_table(sgt);
>>>> kfree(sgt);
>>>
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check
2025-04-07 14:32 ` Christian König
2025-04-07 14:44 ` Matthew Auld
@ 2025-04-07 15:05 ` Alex Deucher
1 sibling, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2025-04-07 15:05 UTC (permalink / raw)
To: Christian König
Cc: Matthew Auld, intel-xe, Christian König, amd-gfx, stable
Applied. Thanks!
On Mon, Apr 7, 2025 at 10:42 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 07.04.25 um 16:18 schrieb Matthew Auld:
> > The page_link lower bits of the first sg could contain something like
> > SG_END, if we are mapping a single VRAM page or contiguous blob which
> > fits into one sg entry. Rather pull out the struct page, and use that in
> > our check to know if we mapped struct pages vs VRAM.
> >
> > Fixes: f44ffd677fb3 ("drm/amdgpu: add support for exporting VRAM using DMA-buf v3")
> > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: <stable@vger.kernel.org> # v5.8+
>
> Good point, haven't thought about that at all since we only abuse the sg table as DMA addr container.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Were is patch #1 from this series?
>
> Thanks,
> Christian.
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> > index 9f627caedc3f..c9842a0e2a1c 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> > @@ -184,7 +184,7 @@ static void amdgpu_dma_buf_unmap(struct dma_buf_attachment *attach,
> > struct sg_table *sgt,
> > enum dma_data_direction dir)
> > {
> > - if (sgt->sgl->page_link) {
> > + if (sg_page(sgt->sgl)) {
> > dma_unmap_sgtable(attach->dev, sgt, dir, 0);
> > sg_free_table(sgt);
> > kfree(sgt);
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-04-07 15:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 14:18 [PATCH 1/2] drm/xe/dma_buf: stop relying on placement in unmap Matthew Auld
2025-04-07 14:18 ` [PATCH 2/2] drm/amdgpu/dma_buf: fix page_link check Matthew Auld
2025-04-07 14:32 ` Christian König
2025-04-07 14:44 ` Matthew Auld
2025-04-07 14:46 ` Christian König
2025-04-07 15:01 ` Matthew Auld
2025-04-07 15:05 ` Alex Deucher
2025-04-07 14:38 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/dma_buf: stop relying on placement in unmap Patchwork
2025-04-07 14:39 ` ✓ CI.checkpatch: " Patchwork
2025-04-07 14:40 ` ✓ CI.KUnit: " Patchwork
2025-04-07 14:43 ` ✗ CI.Build: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox