From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/xe: make hwmon_info const
Date: Wed, 17 Jan 2024 13:38:12 +0100 [thread overview]
Message-ID: <53f0feffdaece8a49ace72451b568439ed5a973d.camel@linux.intel.com> (raw)
In-Reply-To: <20240117122044.1544174-3-jani.nikula@intel.com>
On Wed, 2024-01-17 at 14:20 +0200, Jani Nikula wrote:
> Make hwmon_info a const array of const pointers, and let it be placed
> in
> rodata.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
> ---
>
> Note: Lots more in this file will end up in rodata with the hwmon
> change:
>
> https://lore.kernel.org/r/20240117114405.1506775-1-jani.nikula@intel.com
> ---
> drivers/gpu/drm/xe/xe_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c
> b/drivers/gpu/drm/xe/xe_hwmon.c
> index 6ef2aa1eae8b..e6acdf682d2a 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -402,7 +402,7 @@ static const struct attribute_group
> *hwmon_groups[] = {
> NULL
> };
>
> -static const struct hwmon_channel_info *hwmon_info[] = {
> +static const struct hwmon_channel_info * const hwmon_info[] = {
> HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX |
> HWMON_P_CRIT),
> HWMON_CHANNEL_INFO(curr, HWMON_C_CRIT),
> HWMON_CHANNEL_INFO(in, HWMON_I_INPUT),
next prev parent reply other threads:[~2024-01-17 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 12:20 [PATCH 1/5] drm/xe: make xe_ttm_funcs const Jani Nikula
2024-01-17 12:20 ` [PATCH 2/5] drm/xe: make heci_gsc_irq_chip const Jani Nikula
2024-01-17 12:37 ` Thomas Hellström
2024-01-17 12:20 ` [PATCH 3/5] drm/xe: make hwmon_info const Jani Nikula
2024-01-17 12:38 ` Thomas Hellström [this message]
2024-01-17 12:20 ` [PATCH 4/5] drm/xe: make gpuvm_ops const Jani Nikula
2024-01-17 12:38 ` Thomas Hellström
2024-01-17 12:20 ` [PATCH 5/5] drm/xe: constify engine class sysfs attributes Jani Nikula
2024-01-17 12:39 ` Thomas Hellström
2024-01-17 12:36 ` [PATCH 1/5] drm/xe: make xe_ttm_funcs const Thomas Hellström
2024-01-17 14:56 ` ✓ CI.Patch_applied: success for series starting with [1/5] " Patchwork
2024-01-17 14:57 ` ✓ CI.checkpatch: " Patchwork
2024-01-17 14:58 ` ✓ CI.KUnit: " Patchwork
2024-01-17 15:05 ` ✓ CI.Build: " Patchwork
2024-01-17 15:05 ` ✓ CI.Hooks: " Patchwork
2024-01-17 15:06 ` ✓ CI.checksparse: " Patchwork
2024-01-17 15:32 ` ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f0feffdaece8a49ace72451b568439ed5a973d.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox