Re: [PATCH 1/5] drm/xe: make xe_ttm_funcs const

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Wed, 2024-01-17 at 14:20 +0200, Jani Nikula wrote:
> Place the function pointers in rodata. Also drop the extra
> declaration
> while at it.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_bo.c | 2 +-
>  drivers/gpu/drm/xe/xe_bo.h | 2 +-
>  drivers/gpu/drm/xe/xe_vm.h | 2 --
>  3 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index 26fe73f58d72..686d716c5581 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -1041,7 +1041,7 @@ static void xe_ttm_bo_delete_mem_notify(struct
> ttm_buffer_object *ttm_bo)
>  	}
>  }
>  
> -struct ttm_device_funcs xe_ttm_funcs = {
> +const struct ttm_device_funcs xe_ttm_funcs = {
>  	.ttm_tt_create = xe_ttm_tt_create,
>  	.ttm_tt_populate = xe_ttm_tt_populate,
>  	.ttm_tt_unpopulate = xe_ttm_tt_unpopulate,
> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> index 350cc73cadf8..db4b2db6b073 100644
> --- a/drivers/gpu/drm/xe/xe_bo.h
> +++ b/drivers/gpu/drm/xe/xe_bo.h
> @@ -243,7 +243,7 @@ int xe_bo_evict(struct xe_bo *bo, bool
> force_alloc);
>  int xe_bo_evict_pinned(struct xe_bo *bo);
>  int xe_bo_restore_pinned(struct xe_bo *bo);
>  
> -extern struct ttm_device_funcs xe_ttm_funcs;
> +extern const struct ttm_device_funcs xe_ttm_funcs;
>  
>  int xe_gem_create_ioctl(struct drm_device *dev, void *data,
>  			struct drm_file *file);
> diff --git a/drivers/gpu/drm/xe/xe_vm.h b/drivers/gpu/drm/xe/xe_vm.h
> index cf2f96e8c1ab..e9c907cbcd89 100644
> --- a/drivers/gpu/drm/xe/xe_vm.h
> +++ b/drivers/gpu/drm/xe/xe_vm.h
> @@ -199,8 +199,6 @@ struct dma_fence *xe_vm_rebind(struct xe_vm *vm,
> bool rebind_worker);
>  
>  int xe_vm_invalidate_vma(struct xe_vma *vma);
>  
> -extern struct ttm_device_funcs xe_ttm_funcs;
> -
>  static inline void xe_vm_queue_rebind_worker(struct xe_vm *vm)
>  {
>  	xe_assert(vm->xe, xe_vm_in_preempt_fence_mode(vm));