Re: [PATCH i-g-t 0/8] dmem: add amdgpu support and one more test

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Wed, 2026-05-13 at 10:06 +0200, Christian König wrote:
> On 5/12/26 23:51, Thadeu Lima de Souza Cascardo wrote:
> > This work builds on top of Thomas Hellström's patches at [1].
> > 
> > Besides the case of eviction when setting dmem.max, which still
> > needs
> > support from [2], there are other cases for testing dmem behavior
> > and
> > potential regressions. Thomas' patches lay over the groundwork for
> > this,
> > while this patchset addes one basic test of checking current usage
> > and that
> > drivers respect max setting when no eviction is taking place yet.
> > 
> > This patchset also introduces a driver layer such that the same
> > tests can
> > work with different drivers. amdgpu support is here added too.
> 
> Of hand that looks really nice.
> 
> Please always keep Vitaly CCed for igt test patches which affect
> amdgpu as well.
> 
> Thanks,
> Christian.

Agree this looks nice.
For the xe changes (once [1] gets merged)
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

Thanks,
Thomas


> 
> > 
> > [1] https://patchwork.freedesktop.org/series/163935/
> > 
> > Thadeu Lima de Souza Cascardo (8):
> >   Introduce dmem driver and implement Xe support
> >   Adjust xe_cgroups test to use igt_dmem_driver
> >   Make xe_cgroup test a generic test
> >   amdgpu: add amdgpu_cgroup_region_name
> >   igt_dmem_driver: add amdgpu support
> >   dmem: add test for current/max
> >   dmem: only check for dmem availability once
> >   dmem: get region once per driver
> > 
> >  lib/amdgpu/amd_dmem.c    |  94 ++++++++++
> >  lib/amdgpu/amd_memory.c  |  25 +++
> >  lib/amdgpu/amd_memory.h  |   2 +
> >  lib/igt_dmem_driver.h    |  25 +++
> >  lib/meson.build          |   2 +
> >  lib/xe/xe_dmem.c         | 145 +++++++++++++++
> >  tests/drv_dmem_cgroups.c | 390
> > +++++++++++++++++++++++++++++++++++++++
> >  tests/intel/xe_cgroups.c | 296 -----------------------------
> >  tests/meson.build        |   2 +-
> >  9 files changed, 684 insertions(+), 297 deletions(-)
> >  create mode 100644 lib/amdgpu/amd_dmem.c
> >  create mode 100644 lib/igt_dmem_driver.h
> >  create mode 100644 lib/xe/xe_dmem.c
> >  create mode 100644 tests/drv_dmem_cgroups.c
> >  delete mode 100644 tests/intel/xe_cgroups.c
> >