Re: [PATCH 02/10] drm/i915/display: Introduce HAS_CASF for sharpness support

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 30 Jul 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 24 Jul 2025, Nemesa Garg <nemesa.garg@intel.com> wrote:
>> Add HAS_CASF macro to check whether platform supports
>> the content adaptive sharpness capability or not.
>>
>> v2: Update commit message[Ankit]
>>
>> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
>> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 7 +++++++
>>  drivers/gpu/drm/i915/display/intel_display_device.h  | 1 +
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
>> index 0c7f91046996..33ec30123214 100644
>> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
>> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
>> @@ -373,6 +373,13 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
>>  
>>  	intel_vdsc_state_dump(&p, 0, pipe_config);
>>  
>> +	if (HAS_CASF(display)) {
>> +		drm_printf(&p, "sharpness strength: %d, sharpness tap size :%d\n sharpness enable :%d\n",
>
> No \n in the middle please.

Moreover, place the space after ":" not before.

>
>> +			   pipe_config->hw.casf_params.strength,
>> +			   pipe_config->hw.casf_params.win_size,
>> +			   pipe_config->hw.casf_params.casf_enable);
>> +	}
>> +
>>  dump_planes:
>>  	if (!state)
>>  		return;
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
>> index 4308822f0415..7f76215195d8 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
>> @@ -145,6 +145,7 @@ struct intel_display_platforms {
>>  #define HAS_ASYNC_FLIPS(__display)	(DISPLAY_VER(__display) >= 5)
>>  #define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>>  #define HAS_BIGJOINER(__display)	(DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
>> +#define HAS_CASF(__display)		(DISPLAY_VER(__display) >= 20)
>>  #define HAS_CDCLK_CRAWL(__display)	(DISPLAY_INFO(__display)->has_cdclk_crawl)
>>  #define HAS_CDCLK_SQUASH(__display)	(DISPLAY_INFO(__display)->has_cdclk_squash)
>>  #define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)

-- 
Jani Nikula, Intel