From: "Summers, Stuart" <stuart.summers@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>
Cc: "Tauro, Riana" <riana.tauro@intel.com>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [PATCH 1/3] drm/xe/configfs: Don't touch survivability_mode on fini
Date: Tue, 2 Sep 2025 16:37:48 +0000 [thread overview]
Message-ID: <5a5bf5041a0ae987b73df34a79bbc64ea11cc7e9.camel@intel.com> (raw)
In-Reply-To: <20250902131744.5076-2-michal.wajdeczko@intel.com>
On Tue, 2025-09-02 at 15:17 +0200, Michal Wajdeczko wrote:
> This is a user controlled configfs attribute, we should not
> modify that outside the configfs attr.store() implementation.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
Yeah I agree, makes sense.
Reviewed-by: Stuart Summers <stuart.summers@intel.com>
> ---
> drivers/gpu/drm/xe/xe_survivability_mode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c
> b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 53c5af4b810c..79426ea46861 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -180,7 +180,6 @@ static void xe_survivability_mode_fini(void *arg)
> struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
> struct device *dev = &pdev->dev;
>
> - xe_configfs_clear_survivability_mode(pdev);
> sysfs_remove_file(&dev->kobj,
> &dev_attr_survivability_mode.attr);
> }
>
next prev parent reply other threads:[~2025-09-02 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 13:17 [PATCH 0/3] Allow to filter-out some configfs attrs Michal Wajdeczko
2025-09-02 13:17 ` [PATCH 1/3] drm/xe/configfs: Don't touch survivability_mode on fini Michal Wajdeczko
2025-09-02 16:37 ` Summers, Stuart [this message]
2025-09-02 18:04 ` Lucas De Marchi
2025-09-03 5:39 ` Riana Tauro
2025-09-03 5:49 ` Michal Wajdeczko
2025-09-03 17:50 ` Lucas De Marchi
2025-09-03 19:47 ` Michal Wajdeczko
2025-09-04 4:36 ` Riana Tauro
2025-09-04 10:35 ` [PATCH v2 " Michal Wajdeczko
2025-09-04 15:56 ` Lucas De Marchi
2025-09-09 5:16 ` Riana Tauro
2025-09-02 13:17 ` [PATCH 2/3] drm/xe/configfs: Prepare to filter-out configfs attributes Michal Wajdeczko
2025-09-02 13:17 ` [PATCH 3/3] drm/xe/configfs: Don't expose survivability_mode if not applicable Michal Wajdeczko
2025-09-02 17:25 ` Summers, Stuart
2025-09-02 18:16 ` Michal Wajdeczko
2025-09-02 18:19 ` Summers, Stuart
2025-09-02 18:10 ` Lucas De Marchi
2025-09-02 15:19 ` ✓ CI.KUnit: success for Allow to filter-out some configfs attrs Patchwork
2025-09-02 15:56 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-02 20:41 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-04 10:54 ` ✓ CI.KUnit: success for Allow to filter-out some configfs attrs (rev2) Patchwork
2025-09-04 11:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-04 23:14 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a5bf5041a0ae987b73df34a79bbc64ea11cc7e9.camel@intel.com \
--to=stuart.summers@intel.com \
--cc=Michal.Wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox