Re: [PATCH v2 1/3] drm/xe/configfs: Don't touch survivability_mode on fini

[Riana Tauro <riana.tauro@intel.com>]

On 9/4/2025 4:05 PM, Michal Wajdeczko wrote:
> This is a user controlled configfs attribute, we should not
> modify that outside the configfs attr.store() implementation.
> 
> Fixes: bc417e54e24b ("drm/xe: Enable configfs support for survivability mode")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Reviewed-by: Stuart Summers <stuart.summers@intel.com>

Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>> ---
> v2: add Fixes tag (Lucas) and update the doc (Riana)
> ---
>   drivers/gpu/drm/xe/xe_survivability_mode.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 53c5af4b810c..7999cc5262a5 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -44,6 +44,8 @@
>    *
>    *	# echo 1 > /sys/kernel/config/xe/0000:03:00.0/survivability_mode
>    *
> + * It is the responsibility of the user to clear the mode once firmware flash is complete.
> + *
>    * Refer :ref:`xe_configfs` for more details on how to use configfs
>    *
>    * Survivability mode is indicated by the below admin-only readable sysfs which provides additional
> @@ -180,7 +182,6 @@ static void xe_survivability_mode_fini(void *arg)
>   	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
>   	struct device *dev = &pdev->dev;
>   
> -	xe_configfs_clear_survivability_mode(pdev);
>   	sysfs_remove_file(&dev->kobj, &dev_attr_survivability_mode.attr);
>   }
>