Re: [CI] HAX: Try SR-IOV on ADLP/ATSM

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 28.06.2024 20:51, Rodrigo Vivi wrote:
> On Mon, Jun 24, 2024 at 02:02:03PM +0200, Michal Wajdeczko wrote:
>> This is for CI only. DO NOT REVIEW. DO NOT MERGE.
> 
> how are these tests looking like at this moment?

IMO quite good

recent run [1] just uncovered two existing issues that actually are not
related to the Xe SR-IOV code:

first problem [2]:

Starting dynamic subtest: vf-2
(sriov_basic:1395) igt_device-WARNING: Couldn't find PCI device
0000:00:02:02

was due to a test bug, attempt to fix that is under review [3]


second problem [4]:

<7> [259.552619] BUG: MAX_LOCKDEP_KEYS too low!
<7> [259.552626] turning off the locking correctness validator.

was reproduced on driver running in non-SRIOV mode (native), not sure
whether public bug was created for it, though


[1]
https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-135295v2/index.html?testfilter=iov

[2]
https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-135295v2/shard-adlp-2/igt@sriov_basic@bind-unbind-vf.html

[3] https://patchwork.freedesktop.org/series/135476/

[4]
https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-135295v2/shard-adlp-1/igt@sriov_basic@enable-vfs-autoprobe-on.html#dmesg-warnings1677


> I'm wondering if it is already time to add this patch to topic/xe-for-CI

it would be great, as this patch allows running few basic SR-IOV tests
(including VF driver probe) on the existing BAT/FULL CI runs, so with
minimal effort we will be able to catch regressions/breaks that impacts
the VF driver.

note that being a PF driver by default shouldn't impact any existing
results or functionality, as any resources needed for VFs are reserved
only when VFs are enable during the SR-IOV tests.

additional resources used by the PF until VF are enabled are negligible

> 
> Thomas? Lucas? thoughts?
> 
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_module.c | 1 +
>>  drivers/gpu/drm/xe/xe_pci.c    | 2 ++
>>  2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
>> index 893858a2eea0..c0cf3b8ad815 100644
>> --- a/drivers/gpu/drm/xe/xe_module.c
>> +++ b/drivers/gpu/drm/xe/xe_module.c
>> @@ -18,6 +18,7 @@ struct xe_modparam xe_modparam = {
>>  	.enable_display = true,
>>  	.guc_log_level = 5,
>>  	.force_probe = CONFIG_DRM_XE_FORCE_PROBE,
>> +	.max_vfs = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? ~0 : 0,
>>  	.wedged_mode = 1,
>>  	/* the rest are 0 by default */
>>  };
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index ebff5ea79b1d..488a444b7b5c 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -261,6 +261,7 @@ static const struct xe_device_desc adl_p_desc = {
>>  		{ XE_SUBPLATFORM_ALDERLAKE_P_RPLU, "RPLU", adlp_rplu_ids },
>>  		{},
>>  	},
>> +	.has_sriov = IS_ENABLED(CONFIG_DRM_XE_DEBUG),
>>  };
>>  
>>  static const struct xe_device_desc adl_n_desc = {
>> @@ -307,6 +308,7 @@ static const struct xe_device_desc ats_m_desc = {
>>  
>>  	DG2_FEATURES,
>>  	.has_display = false,
>> +	.has_sriov = IS_ENABLED(CONFIG_DRM_XE_DEBUG),
>>  };
>>  
>>  static const struct xe_device_desc dg2_desc = {
>> -- 
>> 2.43.0
>>