Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Remove vram size info from sysfs
@ 2023-12-12  0:20 Rodrigo Vivi
  2023-12-12  2:08 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 17+ messages in thread
From: Rodrigo Vivi @ 2023-12-12  0:20 UTC (permalink / raw)
  To: intel-xe; +Cc: Matt Roper, Rodrigo Vivi

This information is already part of the query IOCTL.
Let's not duplicate it here in the sysfs.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_tile_sysfs.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
index 16376607c68f..0f8d3e7fce46 100644
--- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
@@ -20,20 +20,6 @@ static const struct kobj_type xe_tile_sysfs_kobj_type = {
 	.sysfs_ops = &kobj_sysfs_ops,
 };
 
-static ssize_t
-physical_vram_size_bytes_show(struct device *kdev, struct device_attribute *attr,
-			      char *buf)
-{
-	struct xe_tile *tile = kobj_to_tile(&kdev->kobj);
-
-	return sysfs_emit(buf, "%llu\n", tile->mem.vram.actual_physical_size);
-}
-
-static DEVICE_ATTR_RO(physical_vram_size_bytes);
-
-static const struct attribute *physical_memsize_attr =
-	&dev_attr_physical_vram_size_bytes.attr;
-
 static void tile_sysfs_fini(struct drm_device *drm, void *arg)
 {
 	struct xe_tile *tile = arg;
@@ -64,15 +50,8 @@ void xe_tile_sysfs_init(struct xe_tile *tile)
 
 	tile->sysfs = &kt->base;
 
-	if (IS_DGFX(xe) && xe->info.platform != XE_DG1 &&
-	    sysfs_create_file(tile->sysfs, physical_memsize_attr))
-		drm_warn(&xe->drm,
-			 "Sysfs creation to read addr_range per tile failed\n");
-
 	err = drmm_add_action_or_reset(&xe->drm, tile_sysfs_fini, tile);
-	if (err) {
+	if (err)
 		drm_warn(&xe->drm, "%s: drmm_add_action_or_reset failed, err: %d\n",
 			 __func__, err);
-		return;
-	}
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2023-12-15  3:54 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-12  0:20 [PATCH] drm/xe: Remove vram size info from sysfs Rodrigo Vivi
2023-12-12  2:08 ` ✓ CI.Patch_applied: success for " Patchwork
2023-12-12  2:09 ` ✓ CI.checkpatch: " Patchwork
2023-12-12  2:10 ` ✓ CI.KUnit: " Patchwork
2023-12-12  2:17 ` ✓ CI.Build: " Patchwork
2023-12-12  2:17 ` ✓ CI.Hooks: " Patchwork
2023-12-12  2:19 ` ✓ CI.checksparse: " Patchwork
2023-12-12  2:54 ` ✓ CI.BAT: " Patchwork
2023-12-12 17:35 ` [PATCH] " Matt Roper
2023-12-13  4:13 ` Upadhyay, Tejas
2023-12-13  5:18   ` Aravind Iddamsetty
2023-12-13 15:53     ` Vivi, Rodrigo
2023-12-14  5:52       ` Aravind Iddamsetty
2023-12-14  9:43         ` Matthew Auld
2023-12-14 11:20           ` Aravind Iddamsetty
2023-12-15  2:20           ` Upadhyay, Tejas
2023-12-15  3:57             ` Aravind Iddamsetty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox