Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: Re: [PATCH] drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc
Date: Mon, 23 Feb 2026 20:18:51 +0100	[thread overview]
Message-ID: <666476e1-3cfb-4574-af74-b9feda2d57ca@linux.intel.com> (raw)
In-Reply-To: <20260219205029.1011336-1-matthew.brost@intel.com>

Hey,

Den 2026-02-19 kl. 21:50, skrev Matthew Brost:
> The kernel-doc for drm_gpusvm_pages_valid_unlocked() was stale and still
> referenced old range-based arguments and naming. Update the documentation
> to match the current function arguments and signature.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/drm_gpusvm.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
> index 81626b00b755..2e229bc944f0 100644
> --- a/drivers/gpu/drm/drm_gpusvm.c
> +++ b/drivers/gpu/drm/drm_gpusvm.c
> @@ -1338,14 +1338,14 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm,
>  EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
>  
>  /**
> - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
> + * drm_gpusvm_pages_valid_unlocked() - GPU SVM pages valid unlocked
>   * @gpusvm: Pointer to the GPU SVM structure
> - * @range: Pointer to the GPU SVM range structure
> + * @svm_pages: Pointer to the GPU SVM pages structure
>   *
> - * This function determines if a GPU SVM range pages are valid. Expected be
> - * called without holding gpusvm->notifier_lock.
> + * This function determines if a GPU SVM pages are valid. Expected be called
> + * without holding gpusvm->notifier_lock.
>   *
> - * Return: True if GPU SVM range has valid pages, False otherwise
> + * Return: True if GPU SVM pages are valid, False otherwise
>   */
>  static bool drm_gpusvm_pages_valid_unlocked(struct drm_gpusvm *gpusvm,
>  					    struct drm_gpusvm_pages *svm_pages)

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

      parent reply	other threads:[~2026-02-23 19:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 20:50 [PATCH] drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc Matthew Brost
2026-02-19 21:06 ` ✓ CI.KUnit: success for " Patchwork
2026-02-20  8:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-20 15:08 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-23 19:18 ` Maarten Lankhorst [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=666476e1-3cfb-4574-af74-b9feda2d57ca@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox