Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/6] drm/xe: Add functions to convert regular address to canonical address and back
@ 2024-01-29 18:17 José Roberto de Souza
  2024-01-29 18:17 ` [PATCH v3 2/6] drm/xe: Add batch buffer addresses to devcoredump José Roberto de Souza
                   ` (12 more replies)
  0 siblings, 13 replies; 22+ messages in thread
From: José Roberto de Souza @ 2024-01-29 18:17 UTC (permalink / raw)
  To: intel-xe; +Cc: Jani Nikula, Maarten Lankhorst, Rodrigo Vivi

Some instructions requires canonical address like
MI_BATCH_BUFFER_START(UMDs must call xe_exec with a canonical address
for Xe2+).

So here adding functions to convert regular address to canonical
address and back, the first user of this functions will be added
in the next patches.

v3:
- inline removed
- rename highest_address_bit_get() to ppgtt_msb_get()

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 15 +++++++++++++++
 drivers/gpu/drm/xe/xe_device.h |  3 +++
 2 files changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 6faa7865b1aab..6172d4f987937 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -747,3 +747,18 @@ void xe_device_snapshot_print(struct xe_device *xe, struct drm_printer *p)
 		drm_printf(p, "\tCS reference clock: %u\n", gt->info.reference_clock);
 	}
 }
+
+static int ppgtt_msb_get(struct xe_device *xe)
+{
+	return xe->info.dma_mask_size > 48 ? 57 : 47;
+}
+
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address)
+{
+	return sign_extend64(address, ppgtt_msb_get(xe));
+}
+
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address)
+{
+	return address & GENMASK_ULL(ppgtt_msb_get(xe), 0);
+}
diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index 270124da1e00e..462f59e902b12 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -177,4 +177,7 @@ u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size);
 
 void xe_device_snapshot_print(struct xe_device *xe, struct drm_printer *p);
 
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address);
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address);
+
 #endif
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2024-01-30 17:22 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29 18:17 [PATCH v3 1/6] drm/xe: Add functions to convert regular address to canonical address and back José Roberto de Souza
2024-01-29 18:17 ` [PATCH v3 2/6] drm/xe: Add batch buffer addresses to devcoredump José Roberto de Souza
2024-01-29 18:17 ` [PATCH v3 3/6] drm/xe: Store xe_he_engine in xe_hw_engine_snapshot José Roberto de Souza
2024-01-29 21:16   ` Matt Roper
2024-01-29 21:20     ` Souza, Jose
2024-01-29 18:17 ` [PATCH v3 4/6] drm/xe: Add misc functions to support read of specific DSS registers José Roberto de Souza
2024-01-29 21:24   ` Matt Roper
2024-01-30 14:42     ` Souza, Jose
2024-01-30 15:54       ` Dong, Zhanjun
2024-01-30 16:14         ` Souza, Jose
2024-01-30 16:52           ` Dong, Zhanjun
2024-01-29 18:17 ` [PATCH v3 5/6] drm/xe: Move XE_MAX_EU_FUSE_BITS to xe_gt_types.h José Roberto de Souza
2024-01-29 18:17 ` [PATCH v3 6/6] drm/xe: Add INSTDONE registers to devcoredump José Roberto de Souza
2024-01-29 18:21 ` ✓ CI.Patch_applied: success for series starting with [v3,1/6] drm/xe: Add functions to convert regular address to canonical address and back Patchwork
2024-01-29 18:21 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-29 18:22 ` ✓ CI.KUnit: success " Patchwork
2024-01-29 18:29 ` ✓ CI.Build: " Patchwork
2024-01-29 18:30 ` ✗ CI.Hooks: failure " Patchwork
2024-01-29 18:31 ` ✓ CI.checksparse: success " Patchwork
2024-01-29 18:55 ` ✓ CI.BAT: " Patchwork
2024-01-29 21:13 ` [PATCH v3 1/6] " Matt Roper
2024-01-29 21:24   ` Souza, Jose

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox